github-actions[bot] commented on code in PR #36281:
URL: https://github.com/apache/doris/pull/36281#discussion_r1639371507
##########
be/src/vec/aggregate_functions/aggregate_function_min_max.h:
##########
@@ -436,41 +432,43 @@ struct SingleValueDataString {
}
}
- bool change_first_time(const IColumn& column, size_t row_num, Arena*
arena) {
- if (!has()) {
+ void change_first_time(const IColumn& column, size_t row_num, Arena*
arena) {
+ if (UNLIKELY(!has())) {
change(column, row_num, arena);
- return true;
- } else {
- return false;
}
}
- bool change_first_time(const Self& to, Arena* arena) {
- if (!has() && to.has()) {
+ void change_first_time(const Self& to, Arena* arena) {
+ if (UNLIKELY(!has() && to.has())) {
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```cpp
if (UNLIKELY(!has() && to.has())) {
^
```
<details>
<summary>Additional context</summary>
**be/src/common/compiler_util.h:35:** expanded from macro 'UNLIKELY'
```cpp
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
