Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-26 Thread via GitHub
wangbo merged PR #41193: URL: https://github.com/apache/doris/pull/41193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
github-actions[bot] commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2376072432 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2375894125 ClickBench: Total hot run time: 33.11 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2375889121 TPC-DS: Total hot run time: 192538 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2375877188 TeamCity be ut coverage result: Function Coverage: 37.30% (9632/25822) Line Coverage: 28.70% (79682/277619) Region Coverage: 28.12% (41199/146492) Branch Coverage: 24.7

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2375876665 TPC-H: Total hot run time: 41015 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2375809847 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2375800576 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
github-actions[bot] commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2374354987 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2374183422 TeamCity be ut coverage result: Function Coverage: 37.30% (9631/25819) Line Coverage: 28.70% (79657/277538) Region Coverage: 28.13% (41195/146457) Branch Coverage: 24.7

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2374126864 ClickBench: Total hot run time: 32.35 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2374111477 TPC-DS: Total hot run time: 191636 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2374080104 TPC-H: Total hot run time: 41354 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2373920032 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2373901795 TeamCity be ut coverage result: Function Coverage: 37.31% (9633/25816) Line Coverage: 28.71% (79668/277528) Region Coverage: 28.13% (41190/146450) Branch Coverage: 24.7

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2373893404 TPC-H: Total hot run time: 41233 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-25 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2373736470 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2372938167 TeamCity be ut coverage result: Function Coverage: 37.33% (9628/25791) Line Coverage: 28.73% (79675/277311) Region Coverage: 28.17% (41199/146264) Branch Coverage: 24.7

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2372938011 ClickBench: Total hot run time: 32.29 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2372918665 TPC-DS: Total hot run time: 192376 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2372893216 TPC-H: Total hot run time: 41191 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
yiguolei commented on code in PR #41193: URL: https://github.com/apache/doris/pull/41193#discussion_r1774395214 ## be/src/olap/rowid_conversion.h: ## @@ -22,6 +22,7 @@ #include "olap/olap_common.h" #include "olap/utils.h" +#include "runtime/thread_context.h" namespace dor

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
yiguolei commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2372871204 We dont need assume memtracker == nullptr OR thread changed during rowid conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
yiguolei commented on code in PR #41193: URL: https://github.com/apache/doris/pull/41193#discussion_r1774372420 ## be/src/vec/common/custom_allocator.h: ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2372850085 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
yiguolei commented on code in PR #41193: URL: https://github.com/apache/doris/pull/41193#discussion_r1774371238 ## be/src/vec/common/custom_allocator.h: ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2372820307 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370985577 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370919686 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370690566 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
github-actions[bot] commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370657303 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-24 Thread via GitHub
github-actions[bot] commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370657218 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370161381 ClickBench: Total hot run time: 32.31 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370155483 TPC-DS: Total hot run time: 191736 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370142901 TPC-H: Total hot run time: 41665 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
wangbo commented on code in PR #41193: URL: https://github.com/apache/doris/pull/41193#discussion_r1772569212 ## be/src/olap/rowid_conversion.h: ## @@ -115,6 +121,7 @@ class RowIdConversion { // value indicates row id of destination segment. // indicates current row n

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
zhannngchen commented on code in PR #41193: URL: https://github.com/apache/doris/pull/41193#discussion_r1772560656 ## be/src/olap/rowid_conversion.h: ## @@ -115,6 +121,7 @@ class RowIdConversion { // value indicates row id of destination segment. // indicates current

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
xinyiZzz commented on code in PR #41193: URL: https://github.com/apache/doris/pull/41193#discussion_r1772551660 ## be/src/vec/common/custom_allocator.h: ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
xinyiZzz commented on code in PR #41193: URL: https://github.com/apache/doris/pull/41193#discussion_r1772551014 ## be/src/olap/rowid_conversion.h: ## @@ -33,17 +33,23 @@ namespace doris { class RowIdConversion { public: RowIdConversion() = default; -~RowIdConversion()

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
wangbo commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370063082 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
doris-robot commented on PR #41193: URL: https://github.com/apache/doris/pull/41193#issuecomment-2370062912 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Improvement]Add customStdAllocator for vector/map [doris]

2024-09-23 Thread via GitHub
wangbo opened a new pull request, #41193: URL: https://github.com/apache/doris/pull/41193 ## Proposed changes 1 Add customStdAllocator for vector/map. 2 Manually count memory for delete bitmap. -- This is an automated message from the Apache Git Service. To respond to the mes