zhannngchen commented on code in PR #41193: URL: https://github.com/apache/doris/pull/41193#discussion_r1772560656
########## be/src/olap/rowid_conversion.h: ########## @@ -115,6 +121,7 @@ class RowIdConversion { // value indicates row id of destination segment. // <UINT32_MAX, UINT32_MAX> indicates current row not exist. std::vector<std::vector<std::pair<uint32_t, uint32_t>>> _segments_rowid_map; Review Comment: Why not replace to MyVector here (just like what you did in SimpleRowidConversion)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org