yiguolei merged PR #31398:
URL: https://github.com/apache/doris/pull/31398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
wangbo commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502273369
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Intern
wangbo commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502273369
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Intern
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963575084
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 718ee3f058879644dac08de2fc94d32b7ccdca3b with
default session variables
Stream
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963570059
ClickBench: Total hot run time: 30.98 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963561599
TPC-DS: Total hot run time: 176104 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
github-actions[bot] commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963546422
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963544572
TPC-H: Total hot run time: 40940 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963537055
TeamCity be ut coverage result:
Function Coverage: 35.73% (8548/23924)
Line Coverage: 27.53% (69363/251946)
Region Coverage: 26.68% (35971/134828)
Branch Coverage: 23.4
cambyzju commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502175794
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Inte
github-actions[bot] commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963514720
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963512085
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wangbo commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502164825
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Intern
wangbo commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963504150
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
wangbo commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502101415
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Intern
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963448417
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 7dffa716876cdbc8a8146143a13d91d720173387 with
default session variables
Stream
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963444717
ClickBench: Total hot run time: 30.58 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963438662
TPC-DS: Total hot run time: 176083 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963426780
TPC-H: Total hot run time: 40757 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963426214
TeamCity be ut coverage result:
Function Coverage: 35.72% (8546/23923)
Line Coverage: 27.52% (69333/251939)
Region Coverage: 26.67% (35953/134827)
Branch Coverage: 23.4
github-actions[bot] commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963418707
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
wangbo commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502101415
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Intern
wangbo commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502095642
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Intern
github-actions[bot] commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963399678
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cambyzju commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502088999
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Inte
cambyzju commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502088519
##
be/src/agent/cgroup_cpu_ctl.cpp:
##
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::Inte
wangbo commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963389445
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
doris-robot commented on PR #31398:
URL: https://github.com/apache/doris/pull/31398#issuecomment-1963389369
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
wangbo opened a new pull request, #31398:
URL: https://github.com/apache/doris/pull/31398
## Proposed changes
Fix cgroup cpu controller file leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
29 matches
Mail list logo
