wangbo commented on code in PR #31398:
URL: https://github.com/apache/doris/pull/31398#discussion_r1502273369
##########
be/src/agent/cgroup_cpu_ctl.cpp:
##########
@@ -91,6 +91,9 @@ Status CgroupCpuCtl::write_cg_sys_file(std::string file_path,
int value, std::st
return Status::InternalError<false>("{} write sys file failed", msg);
}
LOG(INFO) << msg << " success";
+ if (-1 == ::close(fd)) {
+ LOG(WARNING) << "close file fd failed";
Review Comment:
主要是知道了这个路径之后，根据这个信息做啥操作呢，如果没有额外操作，那么加这个信息就没意义。打这个日志的意义在于，有文件句柄泄露时看下是否有这个日志，如果没有说明不是cgroup模块的问题就行了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
