Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-04-05 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2758193201 TPC-DS: Total hot run time: 193984 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-04-05 Thread via GitHub
amorynan commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2022060123 ## be/test/vec/columns/column_object_test.cpp: ## @@ -160,11 +162,11 @@ TEST_F(ColumnObjectTest, test_insert_indices_from) { Field result1; dst_col

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-04-05 Thread via GitHub
hello-stephen commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2760224256 # BE UT Coverage Report Increment line coverage `22.22% (2/9)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/d28d543d9f4a00498beae62cb9b813b10f

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-04-05 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2758152291 TPC-H: Total hot run time: 34190 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-04-01 Thread via GitHub
eldenmoon commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2023885001 ## be/src/vec/data_types/data_type_object.cpp: ## @@ -70,6 +70,7 @@ int64_t DataTypeObject::get_uncompressed_serialized_bytes(const IColumn& column, }

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-04-01 Thread via GitHub
xiaokang commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2023324266 ## be/src/vec/data_types/data_type_object.cpp: ## @@ -70,6 +70,7 @@ int64_t DataTypeObject::get_uncompressed_serialized_bytes(const IColumn& column, }

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-31 Thread via GitHub
eldenmoon commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2022105407 ## be/test/vec/columns/column_object_test.cpp: ## @@ -160,11 +162,11 @@ TEST_F(ColumnObjectTest, test_insert_indices_from) { Field result1; dst_co

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-31 Thread via GitHub
eldenmoon commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2022105177 ## be/test/vec/columns/column_object_test.cpp: ## @@ -160,11 +162,11 @@ TEST_F(ColumnObjectTest, test_insert_indices_from) { Field result1; dst_co

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-30 Thread via GitHub
github-actions[bot] commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2764965538 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2760107169 TPC-DS: Total hot run time: 193280 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2760112015 ClickBench: Total hot run time: 31.89 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2760096748 TPC-H: Total hot run time: 34135 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
eldenmoon commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2017853087 ## be/src/vec/data_types/data_type_object.cpp: ## @@ -113,6 +114,7 @@ char* DataTypeObject::serialize(const IColumn& column, char* buf, int be_exec_ve ++num

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2760075409 TeamCity cloud ut coverage result: Function Coverage: 83.04% (1087/1309) Line Coverage: 66.10% (18106/27390) Region Coverage: 65.47% (8911/13611) Branch Coverage: 55.27

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
csun5285 commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2017848611 ## be/src/vec/data_types/data_type_object.cpp: ## @@ -113,6 +114,7 @@ char* DataTypeObject::serialize(const IColumn& column, char* buf, int be_exec_ve ++num_

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
eldenmoon commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2017830733 ## be/src/vec/data_types/data_type_object.cpp: ## @@ -113,6 +115,8 @@ char* DataTypeObject::serialize(const IColumn& column, char* buf, int be_exec_ve ++num

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
eldenmoon commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2760037966 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
eldenmoon commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2017808597 ## be/src/vec/data_types/data_type_object.cpp: ## @@ -70,6 +70,8 @@ int64_t DataTypeObject::get_uncompressed_serialized_bytes(const IColumn& column, }

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
simges commented on code in PR #49594: URL: https://github.com/apache/doris/pull/49594#discussion_r2017632484 ## be/src/vec/data_types/data_type_object.cpp: ## @@ -70,6 +70,8 @@ int64_t DataTypeObject::get_uncompressed_serialized_bytes(const IColumn& column, }

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2758986612 ClickBench: Total hot run time: 31.67 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2758971782 TPC-DS: Total hot run time: 192063 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2758940533 TPC-H: Total hot run time: 34035 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2758612980 TeamCity cloud ut coverage result: Function Coverage: 83.04% (1087/1309) Line Coverage: 66.09% (18101/27390) Region Coverage: 65.45% (8909/13611) Branch Coverage: 55.31

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
eldenmoon commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2758587699 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2758213476 ClickBench: Total hot run time: 31.68 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
hello-stephen commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2757772682 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
doris-robot commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2757811234 TeamCity cloud ut coverage result: Function Coverage: 83.04% (1087/1309) Line Coverage: 66.13% (18112/27390) Region Coverage: 65.49% (8914/13611) Branch Coverage: 55.35

Re: [PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
eldenmoon commented on PR #49594: URL: https://github.com/apache/doris/pull/49594#issuecomment-2757772977 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [Fix](Variant) fix serialize with json key contains `.` as name [doris]

2025-03-27 Thread via GitHub
eldenmoon opened a new pull request, #49594: URL: https://github.com/apache/doris/pull/49594 ### What problem does this PR solve? 1. `get_path` with lost object nesting level information when calling `ColumnObject::get` when VariantMap is `std::map`, so change VariantMap to ``std:: `to m