simges commented on code in PR #49594:
URL: https://github.com/apache/doris/pull/49594#discussion_r2017632484


##########
be/src/vec/data_types/data_type_object.cpp:
##########
@@ -70,6 +70,8 @@ int64_t 
DataTypeObject::get_uncompressed_serialized_bytes(const IColumn& column,
         }
         PColumnMeta column_meta_pb;
         column_meta_pb.set_name(entry->path.get_path());
+        segment_v2::ColumnPathInfo path;

Review Comment:
   The variable **path** seems declared but not used within this scope. It 
might be a leftover from a previous implementation or an unnecessary 
declaration. 
   Please check if this line is being used, and if not, kindly remove it to 
avoid redundancy.



##########
be/src/vec/data_types/data_type_object.cpp:
##########
@@ -113,6 +115,8 @@ char* DataTypeObject::serialize(const IColumn& column, 
char* buf, int be_exec_ve
         ++num_of_columns;
         PColumnMeta column_meta_pb;
         column_meta_pb.set_name(entry->path.get_path());
+        segment_v2::ColumnPathInfo path;

Review Comment:
   the same comment as above, i could not find the line where the **path** 
variable is used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to