koarz commented on code in PR #31701:
URL: https://github.com/apache/doris/pull/31701#discussion_r1522414096
##
regression-test/suites/nereids_syntax_p0/array_compare.groovy:
##
@@ -0,0 +1,83 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
amorynan commented on code in PR #31701:
URL: https://github.com/apache/doris/pull/31701#discussion_r1522408447
##
regression-test/suites/nereids_syntax_p0/array_compare.groovy:
##
@@ -0,0 +1,83 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
github-actions[bot] commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1991524007
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1991524063
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1989127612
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1989121063
run fe_ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1988812441
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1988750659
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1988457717
> why here no need to change file FunctionComparison.h to make be support
work out ?
Because compare was implemented here before
--
This is an automated message from the Apache Git
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1988458313
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
github-actions[bot] commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1988079534
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
amorynan commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1988048027
why here no need to change file FunctionComparison.h to make be support work
out ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
HappenLee commented on code in PR #31701:
URL: https://github.com/apache/doris/pull/31701#discussion_r1519433112
##
regression-test/suites/nereids_syntax_p0/array_compare.groovy:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
amorynan commented on code in PR #31701:
URL: https://github.com/apache/doris/pull/31701#discussion_r1519389919
##
be/src/vec/columns/column_array.cpp:
##
@@ -89,7 +89,7 @@ INSTANTIATE_INDEX_IMPL(ColumnArray)
ColumnArray::ColumnArray(MutableColumnPtr&& nested_column, MutableC
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987830960
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987812697
TeamCity be ut coverage result:
Function Coverage: 35.00% (8556/24446)
Line Coverage: 26.83% (69533/259207)
Region Coverage: 26.08% (36079/138336)
Branch Coverage: 23.0
github-actions[bot] commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987781744
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987771270
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
doris-robot commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987636866
TeamCity be ut coverage result:
Function Coverage: 34.99% (8554/24446)
Line Coverage: 26.82% (69523/259205)
Region Coverage: 26.07% (36068/138336)
Branch Coverage: 23.0
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987619456
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987600199
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987593452
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
github-actions[bot] commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1987585461
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on code in PR #31701:
URL: https://github.com/apache/doris/pull/31701#discussion_r1514019231
##
fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java:
##
@@ -814,6 +814,9 @@ public TColumnType toColumnTypeThrift() {
* here is to avoid special-ca
github-actions[bot] commented on code in PR #31701:
URL: https://github.com/apache/doris/pull/31701#discussion_r1513907888
##
be/src/vec/columns/column_array.cpp:
##
@@ -1076,10 +1145,67 @@ ColumnPtr ColumnArray::permute(const Permutation& perm,
size_t limit) const {
koarz commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1975015257
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
doris-robot commented on PR #31701:
URL: https://github.com/apache/doris/pull/31701#issuecomment-1975013607
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
koarz opened a new pull request, #31701:
URL: https://github.com/apache/doris/pull/31701
## Proposed changes
Issue Number: #31157
support Array Type Compare ( ">", "=","<",...)
```
mysql> select [1,2] = [1,2];
+---+
| ([1, 2] = [1, 2]) |
+-
28 matches
Mail list logo
