github-actions[bot] commented on code in PR #31701:
URL: https://github.com/apache/doris/pull/31701#discussion_r1513907888
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -1076,10 +1145,67 @@ ColumnPtr ColumnArray::permute(const Permutation& perm,
size_t limit) const {
nested_perm.push_back(offset_at(perm[i]) + j);
}
}
- if (nested_perm.size() != 0) {
+ if (!nested_perm.empty()) {
res->data = data->permute(nested_perm, nested_perm.size());
}
return res;
}
+size_t ColumnArray::get_max_row_byte_size() const {
Review Comment:
warning: method 'get_max_row_byte_size' can be made static
[readability-convert-member-functions-to-static]
```suggestion
size_t ColumnArray::get_max_row_byte_size() {
```
be/src/vec/columns/column_array.h:141:
```diff
- size_t get_max_row_byte_size() const override;
+ static size_t get_max_row_byte_size() override;
```
##########
be/src/vec/columns/column_array.h:
##########
@@ -124,21 +122,49 @@ class ColumnArray final : public COWHelper<IColumn,
ColumnArray> {
using ColumnOffsets = ColumnVector<Offset64>;
std::string get_name() const override;
+
const char* get_family_name() const override { return "Array"; }
+
bool is_column_array() const override { return true; }
+
MutableColumnPtr clone_resized(size_t size) const override;
+
size_t size() const override;
+
void resize(size_t n) override;
+
Field operator[](size_t n) const override;
+
void get(size_t n, Field& res) const override;
+
+ void deserialize_vec(std::vector<StringRef>& keys, const size_t num_rows)
override;
Review Comment:
warning: parameter 'num_rows' is const-qualified in the function
declaration; const-qualification of parameters only has an effect in function
definitions [readability-avoid-const-params-in-decls]
```suggestion
void deserialize_vec(std::vector<StringRef>& keys, size_t num_rows)
override;
```
##########
be/src/vec/columns/column_array.h:
##########
@@ -124,21 +122,49 @@
using ColumnOffsets = ColumnVector<Offset64>;
std::string get_name() const override;
+
const char* get_family_name() const override { return "Array"; }
+
bool is_column_array() const override { return true; }
+
MutableColumnPtr clone_resized(size_t size) const override;
+
size_t size() const override;
+
void resize(size_t n) override;
+
Field operator[](size_t n) const override;
+
void get(size_t n, Field& res) const override;
+
+ void deserialize_vec(std::vector<StringRef>& keys, const size_t num_rows)
override;
+
+ size_t get_max_row_byte_size() const override;
+
+ void serialize_vec(std::vector<StringRef>& keys, size_t num_rows,
+ size_t max_row_byte_size) const override;
+
+ void serialize_vec_with_null_map(std::vector<StringRef>& keys, size_t
num_rows,
+ const uint8_t* null_map) const override;
+
+ void deserialize_vec_with_null_map(std::vector<StringRef>& keys, const
size_t num_rows,
Review Comment:
warning: parameter 'num_rows' is const-qualified in the function
declaration; const-qualification of parameters only has an effect in function
definitions [readability-avoid-const-params-in-decls]
```suggestion
void deserialize_vec_with_null_map(std::vector<StringRef>& keys, size_t
num_rows,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
