koi2000 commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1992873068
##
be/src/geo/geo_types.cpp:
##
@@ -476,6 +656,156 @@ std::string GeoPolygon::as_wkt() const {
return ss.str();
}
+bool GeoPolygon::intersects(const GeoShape* r
HappenLee commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1990904546
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -672,43 +674,37 @@ struct StContains {
break;
}
}
-
-if (i == 2) {
-
koi2000 commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1991067521
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -672,43 +674,37 @@ struct StContains {
break;
}
}
-
-if (i == 2) {
-
HappenLee commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1990905509
##
be/src/geo/geo_types.cpp:
##
@@ -476,6 +656,156 @@ std::string GeoPolygon::as_wkt() const {
return ss.str();
}
+bool GeoPolygon::intersects(const GeoShape*
koi2000 commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1987224192
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -721,6 +721,291 @@ struct StContains {
}
}; // namespace doris::vectorized
+struct StIntersects {
+static c
koi2000 commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1987223758
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -721,6 +721,291 @@ struct StContains {
}
}; // namespace doris::vectorized
+struct StIntersects {
+static c
HappenLee commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1986588001
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -721,6 +721,291 @@ struct StContains {
}
}; // namespace doris::vectorized
+struct StIntersects {
+static
HappenLee commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1986588628
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -721,6 +721,291 @@ struct StContains {
}
}; // namespace doris::vectorized
+struct StIntersects {
+static
HappenLee commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1986588420
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -721,6 +721,291 @@ struct StContains {
}
}; // namespace doris::vectorized
+struct StIntersects {
+static
hello-stephen commented on PR #48695:
URL: https://github.com/apache/doris/pull/48695#issuecomment-2703195401
# BE UT Coverage Report
Increment line coverage `41.30% (304/736)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/20e36804dccf1e258ac43ac8b94c06
doris-robot commented on PR #48695:
URL: https://github.com/apache/doris/pull/48695#issuecomment-2703127862
ClickBench: Total hot run time: 30.75 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48695:
URL: https://github.com/apache/doris/pull/48695#issuecomment-2703093621
TPC-H: Total hot run time: 32854 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #48695:
URL: https://github.com/apache/doris/pull/48695#issuecomment-2702997323
TeamCity cloud ut coverage result:
Function Coverage: 82.15% (1063/1294)
Line Coverage: 65.72% (17638/26840)
Region Coverage: 65.16% (8692/13340)
Branch Coverage: 55.17
koi2000 commented on PR #48695:
URL: https://github.com/apache/doris/pull/48695#issuecomment-2702961630
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
koi2000 opened a new pull request, #48695:
URL: https://github.com/apache/doris/pull/48695
### What problem does this PR solve?
Issue Number: close #48203
Problem Summary:
Support for ST_Intersects, ST_Disjoint, ST_Touches sql functions.
### Release note
Non
Thearas commented on PR #48695:
URL: https://github.com/apache/doris/pull/48695#issuecomment-2700435382
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
16 matches
Mail list logo
