HappenLee commented on code in PR #48695:
URL: https://github.com/apache/doris/pull/48695#discussion_r1990904546
##########
be/src/vec/functions/functions_geo.cpp:
##########
@@ -672,43 +674,37 @@ struct StContains {
break;
}
}
-
- if (i == 2) {
- auto contains_value = shapes[0]->contains(shapes[1].get());
- res->insert_data(const_cast<const char*>((char*)&contains_value),
0);
- }
+ auto relation_value = Func::evaluate(shapes[0].get(), shapes[1].get());
+ res->insert_data(const_cast<const char*>((char*)&relation_value), 0);
Review Comment:
why here and 673line use insert, better like `null_map` 672. `res[row] =
Func::evaluate(shapes[0].get(), shapes[1].get());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
