Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-29 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2444892618 ClickBench: Total hot run time: 32.61 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-29 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2444879934 TPC-DS: Total hot run time: 196980 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-29 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2444849726 TPC-H: Total hot run time: 40982 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2444754598 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-29 Thread via GitHub
Yoruet commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2444739923 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2444694297 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-29 Thread via GitHub
Yoruet commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2444681270 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-29 Thread via GitHub
luwei16 commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1821078539 ## be/src/cloud/cloud_base_compaction.cpp: ## @@ -48,8 +48,16 @@ CloudBaseCompaction::CloudBaseCompaction(CloudStorageEngine& engine, CloudTablet CloudBaseCompaction:

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2437624172 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2437447758 ClickBench: Total hot run time: 33.01 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2437438193 TPC-DS: Total hot run time: 192472 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2437416472 TPC-H: Total hot run time: 41795 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
Yoruet commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2437294988 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2437288850 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435962564 TPC-DS: Total hot run time: 192227 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
Yoruet commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435076295 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435791474 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-25 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435983577 ClickBench: Total hot run time: 32.57 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2436768947 TPC-DS: Total hot run time: 191450 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2436760178 TPC-H: Total hot run time: 41567 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2436773065 ClickBench: Total hot run time: 33.14 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
Yoruet commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2436696324 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2436700497 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435920770 TPC-H: Total hot run time: 41537 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
Yoruet commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435782801 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435290370 ClickBench: Total hot run time: 33.27 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435277020 TPC-DS: Total hot run time: 191918 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435247507 TPC-H: Total hot run time: 41424 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
Yukang-Lian commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435150778 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435064364 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-24 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2435016181 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2428359867 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2428285909 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2428198455 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
Yoruet commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1809830396 ## be/src/cloud/cloud_cumulative_compaction.cpp: ## @@ -53,7 +53,10 @@ Status CloudCumulativeCompaction::prepare_compact() { if (_tablet->tablet_state() != TABLET_R

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
Yoruet commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1809830119 ## be/src/cloud/cloud_full_compaction.cpp: ## @@ -52,13 +52,26 @@ CloudFullCompaction::~CloudFullCompaction() = default; Status CloudFullCompaction::prepare_compact()

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
Yoruet commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1809796176 ## be/src/cloud/cloud_compaction_action.cpp: ## @@ -196,10 +196,16 @@ Status CloudCompactionAction::_handle_run_status_compaction(HttpRequest* req, std::string

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
Yoruet commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1809736366 ## be/src/cloud/cloud_tablet.cpp: ## @@ -557,23 +557,81 @@ void CloudTablet::get_compaction_status(std::string* json_result) { std::vector rowsets; std::vec

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
gavinchou commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1809142823 ## be/src/cloud/cloud_compaction_action.cpp: ## @@ -196,10 +196,16 @@ Status CloudCompactionAction::_handle_run_status_compaction(HttpRequest* req, std::str

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
gavinchou commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1809142031 ## be/src/cloud/cloud_full_compaction.cpp: ## @@ -52,13 +52,26 @@ CloudFullCompaction::~CloudFullCompaction() = default; Status CloudFullCompaction::prepare_compac

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
gavinchou commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1809142606 ## be/src/cloud/cloud_base_compaction.cpp: ## @@ -49,7 +49,10 @@ CloudBaseCompaction::~CloudBaseCompaction() = default; Status CloudBaseCompaction::prepare_compact

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
gavinchou commented on code in PR #42227: URL: https://github.com/apache/doris/pull/42227#discussion_r1809137774 ## be/src/cloud/cloud_tablet.cpp: ## @@ -557,23 +557,81 @@ void CloudTablet::get_compaction_status(std::string* json_result) { std::vector rowsets; std::

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
github-actions[bot] commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2427126607 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] Improve Compaction Profiling and Logging-task2 [doris]

2024-10-21 Thread via GitHub
doris-robot commented on PR #42227: URL: https://github.com/apache/doris/pull/42227#issuecomment-2427113893 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y