gavinchou commented on code in PR #42227:
URL: https://github.com/apache/doris/pull/42227#discussion_r1809142823
##########
be/src/cloud/cloud_compaction_action.cpp:
##########
@@ -196,10 +196,16 @@ Status
CloudCompactionAction::_handle_run_status_compaction(HttpRequest* req,
std::string compaction_type;
bool run_status = false;
+ CloudTabletSPtr cloud_tablet =
DORIS_TRY(_engine.tablet_mgr().get_tablet(tablet_id));
Review Comment:
ditto
##########
be/src/cloud/cloud_cumulative_compaction.cpp:
##########
@@ -53,7 +53,10 @@ Status CloudCumulativeCompaction::prepare_compact() {
if (_tablet->tablet_state() != TABLET_RUNNING &&
(!config::enable_new_tablet_do_compaction ||
static_cast<CloudTablet*>(_tablet.get())->alter_version() == -1)) {
- return Status::InternalError("invalid tablet state. tablet_id={}",
_tablet->tablet_id());
+ Status res = Status::InternalError("invalid tablet state.
tablet_id={}", _tablet->tablet_id());
Review Comment:
ditto
##########
be/src/olap/base_compaction.cpp:
##########
@@ -45,19 +45,31 @@ BaseCompaction::~BaseCompaction() = default;
Status BaseCompaction::prepare_compact() {
if (!tablet()->init_succeeded()) {
- return Status::Error<INVALID_ARGUMENT, false>("_tablet init failed");
+ Status res = Status::Error<INVALID_ARGUMENT, false>("_tablet init
failed");
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
