BiteThet merged PR #42344:
URL: https://github.com/apache/doris/pull/42344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2552685132
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2550530461
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2550444182
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2550196245
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
doris-robot commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2548934090
TeamCity be ut coverage result:
Function Coverage: 38.87% (10129/26061)
Line Coverage: 29.78% (85138/285905)
Region Coverage: 28.88% (43419/150344)
Branch Coverage: 25.
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2548632501
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2548613027
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2547784465
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2547766321
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2540298125
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2540297439
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2539675916
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2539674879
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2539001971
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2538987545
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2538726606
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2538725464
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2530274075
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2530254749
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2517976303
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-251161
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
linrrzqqq commented on PR #42344:
URL: https://github.com/apache/doris/pull/42344#issuecomment-2516495609
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1868815212
##
be/src/vec/common/assert_cast.h:
##
@@ -45,33 +45,33 @@ PURE To assert_cast(From&& from) {
if (auto ptr = dynamic_cast(from); ptr != nullptr) {
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1868813940
##
be/src/vec/exec/format/parquet/decoder.h:
##
@@ -79,7 +79,8 @@ class Decoder {
}
virtual MutableColumnPtr convert_dict_column_to_string_column(const
C
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1867503443
##
be/src/service/backend_options.cpp:
##
Review Comment:
dont change this file
##
be/src/vec/exec/format/parquet/decoder.h:
##
@@ -79,8 +79,8
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1865210378
##
be/src/vec/runtime/vdatetime_value.cpp:
##
@@ -3433,8 +3433,7 @@ void DateV2Value::unchecked_set_time(uint8_t hour,
uint8_t minute, uint8_t se
date_v2_va
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1865207309
##
be/src/util/expected.hpp:
##
Review Comment:
dont change this file
--
This is an automated message from the Apache Git Service.
To respond to the message,
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863794472
##
be/test/testutil/test_util.cpp:
##
Review Comment:
dont change this file
##
be/src/olap/tablet_meta.cpp:
##
Review Comment:
dont chang
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863787324
##
be/src/pipeline/exec/operator.cpp:
##
@@ -398,8 +398,7 @@ std::shared_ptr
DataSinkOperatorX::create_shar
return nullptr;
} else if constexpr (std::i
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863198314
##
be/src/vec/functions/function_binary_arithmetic.h:
##
@@ -423,8 +423,8 @@ struct DecimalBinaryOperation {
if constexpr (check_overflow && !is_to_null_ty
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863197534
##
be/src/vec/data_types/data_type_quantilestate.h:
##
@@ -94,9 +94,7 @@ class DataTypeQuantileState : public IDataType {
Field get_default() const override { re
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863192822
##
be/src/olap/key_coder.h:
##
@@ -300,7 +300,7 @@ class KeyCoderTraits {
}
static Status decode_ascending(Slice* encoded_key, size_t index_size,
uint8_t
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863192371
##
be/src/olap/in_list_predicate.h:
##
@@ -431,8 +431,8 @@ class InListPredicateBase : public ColumnPredicate {
}
}
zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863190834
##
be/src/gutil/strings/util.cc:
##
@@ -489,7 +491,7 @@ const char* strstr_delimited(const char* haystack, const
char* needle, char deli
++haystack;
35 matches
Mail list logo
