zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863192822
##########
be/src/olap/key_coder.h:
##########
@@ -300,7 +300,7 @@ class KeyCoderTraits<FieldType::OLAP_FIELD_TYPE_CHAR> {
}
static Status decode_ascending(Slice* encoded_key, size_t index_size,
uint8_t* cell_ptr) {
- LOG(FATAL) << "decode_ascending is not implemented";
+ throw Exception(Status::FatalError("decode_ascending is not
implemented"));
return Status::OK();
Review Comment:
remove the `return`s
##########
be/src/olap/memtable.cpp:
##########
@@ -28,6 +28,7 @@
#include "bvar/bvar.h"
#include "common/config.h"
+#include "common/exception.h"
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
