[GitHub] [doris] github-actions[bot] commented on pull request #16251: [refactor](row-store) make row store column a hidden column in meta

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16251: URL: https://github.com/apache/doris/pull/16251#issuecomment-1412359375 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #15663: [Improvement](topn) order by key topn query optimization

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #15663: URL: https://github.com/apache/doris/pull/15663#issuecomment-1412319422 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #15663: [Improvement](topn) order by key topn query optimization

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #15663: URL: https://github.com/apache/doris/pull/15663#issuecomment-1412316013 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16333: [Refactor](function) remove useless function get to create column

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16333: URL: https://github.com/apache/doris/pull/16333#issuecomment-1412307392 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16333: [Refactor](function) remove useless function get to create column

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16333: URL: https://github.com/apache/doris/pull/16333#issuecomment-1412307459 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16343: [Enhancement-WIP](Stmt) Set insert_into timeout session variable separately

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16343: URL: https://github.com/apache/doris/pull/16343#issuecomment-1412244818 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16211: [bug](load) sequence column do not compare correctly in memtable

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16211: URL: https://github.com/apache/doris/pull/16211#issuecomment-1412092005 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Add cluster_token auth for stream load to avoid double auth in mysql load

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1412058375 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Add cluster_token auth for stream load to avoid double auth in mysql load

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1412055649 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16335: [WIP](dynamic-table) support dynamic schema table

2023-02-01 Thread github-actions
github-actions[bot] commented on code in PR #16335: URL: https://github.com/apache/doris/pull/16335#discussion_r1093190260 ## be/src/vec/data_types/get_least_supertype.cpp: ## @@ -50,12 +50,152 @@ } } // namespace -DataTypePtr get_least_supertype(const DataTypes& t

[GitHub] [doris] github-actions[bot] commented on pull request #16331: [bugfix](topn) fix topn runtime predicate getting value bug for decimal type

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16331: URL: https://github.com/apache/doris/pull/16331#issuecomment-1412015749 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16271: [feature](JdbcExternalCatalog) support insert data in JdbcExternalCatalog

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16271: URL: https://github.com/apache/doris/pull/16271#issuecomment-1412008082 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16335: [WIP](dynamic-table) support dynamic schema table

2023-02-01 Thread github-actions
github-actions[bot] commented on code in PR #16335: URL: https://github.com/apache/doris/pull/16335#discussion_r1093159661 ## be/src/exec/base_scanner.cpp: ## @@ -250,6 +265,28 @@ Status BaseScanner::_materialize_dest_block(vectorized::Block* dest_block) { std

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16290: [Chore](build) enable -Wpedantic and update lowest gcc version to 11.1

2023-02-01 Thread github-actions
github-actions[bot] commented on code in PR #16290: URL: https://github.com/apache/doris/pull/16290#discussion_r1093106292 ## be/test/agent/cgroups_mgr_test.cpp: ## @@ -21,13 +21,8 @@ #include #include -#include "gmock/gmock.h" #include "gtest/gtest.h"

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16337: [improvement](jdbc) refator jdbc of copy result set by batch

2023-02-01 Thread github-actions
github-actions[bot] commented on code in PR #16337: URL: https://github.com/apache/doris/pull/16337#discussion_r1093102849 ## be/src/util/jni_native_method.h: ## @@ -0,0 +1,28 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

[GitHub] [doris] github-actions[bot] commented on pull request #16336: [fix](merge-on-write) fix that the query result has duplicate keys

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16336: URL: https://github.com/apache/doris/pull/16336#issuecomment-1411911994 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16244: [fix](memtracker) Fix high frequency load slow lock in memtracker

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16244: URL: https://github.com/apache/doris/pull/16244#issuecomment-1411872106 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16309: [enhance](Nereids): polish code.

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16309: URL: https://github.com/apache/doris/pull/16309#issuecomment-1411864692 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16309: [enhance](Nereids): polish code.

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16309: URL: https://github.com/apache/doris/pull/16309#issuecomment-1411864634 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16333: [Refactor](function) remove useless function get to create column

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16333: URL: https://github.com/apache/doris/pull/16333#issuecomment-1411859971 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16330: [Bug](followup) fix datev2 functions

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16330: URL: https://github.com/apache/doris/pull/16330#issuecomment-1411836308 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16330: [Bug](followup) fix datev2 functions

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16330: URL: https://github.com/apache/doris/pull/16330#issuecomment-1411836377 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16082: [feature-wip](multi-catalog) support iceberg union catalog, and add h…

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16082: URL: https://github.com/apache/doris/pull/16082#issuecomment-1411812120 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16082: [feature-wip](multi-catalog) support iceberg union catalog, and add h…

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16082: URL: https://github.com/apache/doris/pull/16082#issuecomment-1411812024 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16268: URL: https://github.com/apache/doris/pull/16268#issuecomment-1411809408 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16268: URL: https://github.com/apache/doris/pull/16268#issuecomment-1411809481 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16260: [fix](Nereids): fix regression test in A-F.out

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16260: URL: https://github.com/apache/doris/pull/16260#issuecomment-1411802745 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16260: [fix](Nereids): fix regression test in A-F.out

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16260: URL: https://github.com/apache/doris/pull/16260#issuecomment-1411802636 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16331: [bugfix](topn) fix topn runtime predicate getting value bug for decimal type

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16331: URL: https://github.com/apache/doris/pull/16331#issuecomment-1411797947 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16331: [bugfix](topn) fix topn runtime predicate getting value bug for decimal type

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16331: URL: https://github.com/apache/doris/pull/16331#issuecomment-1411797563 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16331: [bugfix](topn) fix topn runtime predicate getting value bug for decimal type

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16331: URL: https://github.com/apache/doris/pull/16331#issuecomment-1411797481 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16330: [Bug](followup) fix datev2 functions

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16330: URL: https://github.com/apache/doris/pull/16330#issuecomment-1411777974 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16329: [improvement](global context) remove some unused method from runtime state

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16329: URL: https://github.com/apache/doris/pull/16329#issuecomment-1411772381 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #15795: [DRAFT](datev2) test auto conversion

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #15795: URL: https://github.com/apache/doris/pull/15795#issuecomment-1411770701 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16319: [DRAFT] Dynamic table

2023-02-01 Thread github-actions
github-actions[bot] commented on code in PR #16319: URL: https://github.com/apache/doris/pull/16319#discussion_r1092988066 ## be/src/vec/columns/subcolumn_tree.h: ## @@ -0,0 +1,195 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

[GitHub] [doris] github-actions[bot] commented on pull request #16328: [enhancement](profile) add the profile counter RawRowsRead to record the rows read from the parquet file

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16328: URL: https://github.com/apache/doris/pull/16328#issuecomment-1411750209 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16327: [fix](cast) fix cast date when push down predicate

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16327: URL: https://github.com/apache/doris/pull/16327#issuecomment-1411730272 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16299: [fix](cooldown) Fix bugs in cooldown single replica files

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16299: URL: https://github.com/apache/doris/pull/16299#issuecomment-1411683969 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16326: [improvement](multi-catalog) increase default batch_size to 4064

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16326: URL: https://github.com/apache/doris/pull/16326#issuecomment-1411665616 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16235: [Fix](Load) Disable for the developer to import fast json in fe

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16235: URL: https://github.com/apache/doris/pull/16235#issuecomment-1411653209 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16311: [fix](join) crash caused by canceling query

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16311: URL: https://github.com/apache/doris/pull/16311#issuecomment-1411635912 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16325: [bugfix](RemoteUDF) fix remote udf retrun `rpc env init error`

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16325: URL: https://github.com/apache/doris/pull/16325#issuecomment-1411629734 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16303: [log](compaction) add max score log for debug

2023-02-01 Thread github-actions
github-actions[bot] commented on PR #16303: URL: https://github.com/apache/doris/pull/16303#issuecomment-1411619130 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16166: [fix](hashjoin) join produce blocks with rows larger than batch size

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16166: URL: https://github.com/apache/doris/pull/16166#issuecomment-1411602341 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16089: URL: https://github.com/apache/doris/pull/16089#issuecomment-1411599264 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16319: [DRAFT] Dynamic table

2023-01-31 Thread github-actions
github-actions[bot] commented on code in PR #16319: URL: https://github.com/apache/doris/pull/16319#discussion_r1092848363 ## be/src/exec/base_scanner.cpp: ## @@ -251,6 +266,28 @@ std::move(column_ptr), slot_desc->get_data_type_ptr(), slot_desc->co

[GitHub] [doris] github-actions[bot] commented on pull request #16303: [log](compaction) add max score log for debug

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16303: URL: https://github.com/apache/doris/pull/16303#issuecomment-1411582055 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16190: URL: https://github.com/apache/doris/pull/16190#issuecomment-1411580688 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16190: URL: https://github.com/apache/doris/pull/16190#issuecomment-1411580629 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16303: [log](compaction) add max score log for debug

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16303: URL: https://github.com/apache/doris/pull/16303#issuecomment-1411575410 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16275: [typo](doc) fix mistake word Update cn_doc and en_doc for elt.md

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16275: URL: https://github.com/apache/doris/pull/16275#issuecomment-1411561948 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16275: [typo](doc) fix mistake word Update cn_doc and en_doc for elt.md

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16275: URL: https://github.com/apache/doris/pull/16275#issuecomment-1411561891 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16196: [Chore](build) enable ignored-qualifiers check

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16196: URL: https://github.com/apache/doris/pull/16196#issuecomment-1411556386 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16055: [feature](Load)Suppot skip specific lines number for csv stream load

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16055: URL: https://github.com/apache/doris/pull/16055#issuecomment-1411547843 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16299: [fix](cooldown) Fix bugs in cooldown single replica files

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16299: URL: https://github.com/apache/doris/pull/16299#issuecomment-1411542806 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16302: [fix](multi-catalog) remove the eof check among parquet columns

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16302: URL: https://github.com/apache/doris/pull/16302#issuecomment-1411542215 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16247: [Bug](date) remove MinuteFloor/MinuteCeil for datev2

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16247: URL: https://github.com/apache/doris/pull/16247#issuecomment-1411540003 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16290: [Chore](build) enable -Wpedantic and update lowest gcc version to 11.1

2023-01-31 Thread github-actions
github-actions[bot] commented on code in PR #16290: URL: https://github.com/apache/doris/pull/16290#discussion_r1092807070 ## be/src/vec/aggregate_functions/aggregate_function_sort.h: ## @@ -34,7 +34,7 @@ struct AggregateFunctionSortData { Block block; // The

[GitHub] [doris] github-actions[bot] commented on pull request #16308: [bug](function) fix mask_first_n function can't handle const value

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16308: URL: https://github.com/apache/doris/pull/16308#issuecomment-1411525647 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16149: [Fix](MTMV)Support master and follow change in multi fe for mtmv

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16149: URL: https://github.com/apache/doris/pull/16149#issuecomment-1411519609 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16149: [Fix](MTMV)Support master and follow change in multi fe for mtmv

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16149: URL: https://github.com/apache/doris/pull/16149#issuecomment-1411519562 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16304: [improvement](multi-catalog) use date/datetimev2 as default col type for catalog table

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16304: URL: https://github.com/apache/doris/pull/16304#issuecomment-1411507494 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16290: [Chore](build) enable -Wpedantic and update lowest gcc version to 11.1

2023-01-31 Thread github-actions
github-actions[bot] commented on code in PR #16290: URL: https://github.com/apache/doris/pull/16290#discussion_r1092790221 ## be/src/vec/aggregate_functions/aggregate_function_sort.h: ## @@ -34,7 +34,7 @@ struct AggregateFunctionSortData { Block block; // The

[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16126: URL: https://github.com/apache/doris/pull/16126#issuecomment-1411463523 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16281: [Bug](date) fix BE crash if month_floor 's argument is null

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16281: URL: https://github.com/apache/doris/pull/16281#issuecomment-1411442910 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16281: [Bug](date) fix BE crash if month_floor 's argument is null

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16281: URL: https://github.com/apache/doris/pull/16281#issuecomment-1411442889 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16159: [datev2](function) make function nullable DEPEND_ON_ARGUMENT

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16159: URL: https://github.com/apache/doris/pull/16159#issuecomment-1411437842 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16159: [datev2](function) make function nullable DEPEND_ON_ARGUMENT

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16159: URL: https://github.com/apache/doris/pull/16159#issuecomment-1411437690 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16299: [fix](cooldown) Fix bugs in cooldown single replica files

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16299: URL: https://github.com/apache/doris/pull/16299#issuecomment-1411433638 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16311: [fix](join) crash caused by canceling query

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16311: URL: https://github.com/apache/doris/pull/16311#issuecomment-1411423218 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16306: [test](function)add function case `date_sub(datetime,INTERVAL dayofmonth(datetime)-1 DAY)`

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16306: URL: https://github.com/apache/doris/pull/16306#issuecomment-1411418291 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16308: [bug](function) fix mask_first_n function can't handle const value

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16308: URL: https://github.com/apache/doris/pull/16308#issuecomment-1411405691 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16306: [test](function)add function case `date_sub(datetime,INTERVAL dayofmonth(datetime)-1 DAY)`

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16306: URL: https://github.com/apache/doris/pull/16306#issuecomment-1411401916 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16268: [improvement](session variable)Add enable_file_cache session variable.

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16268: URL: https://github.com/apache/doris/pull/16268#issuecomment-1411387750 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16172: [fix-core](block) clear block row_same_bit when block reuse

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16172: URL: https://github.com/apache/doris/pull/16172#issuecomment-1411378504 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16185: [BugFix](sort) use correct agg function when using 2 phase sort for agg table

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16185: URL: https://github.com/apache/doris/pull/16185#issuecomment-1411372728 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #15509: [feature](partition)add default list partition

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #15509: URL: https://github.com/apache/doris/pull/15509#issuecomment-1411372067 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16196: [Chore](build) enable ignored-qualifiers check

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16196: URL: https://github.com/apache/doris/pull/16196#issuecomment-1411349564 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16298: [feature](nereids) 4 phase aggregation

2023-01-31 Thread github-actions
github-actions[bot] commented on code in PR #16298: URL: https://github.com/apache/doris/pull/16298#discussion_r1092682580 ## be/test/olap/remote_rowset_gc_test.cpp: ## @@ -52,9 +53,14 @@ class RemoteRowsetGcTest : public testing::Test { s3_conf.region = config

[GitHub] [doris] github-actions[bot] commented on pull request #16274: [Bug](function) enchance esquery error msg && forbid to_quantile_state

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16274: URL: https://github.com/apache/doris/pull/16274#issuecomment-1411345200 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16103: [enhance](nereids) show exprid in slot descriptor

2023-01-31 Thread github-actions
github-actions[bot] commented on code in PR #16103: URL: https://github.com/apache/doris/pull/16103#discussion_r1092679948 ## be/src/olap/tablet_meta.cpp: ## @@ -877,13 +877,13 @@ bool operator==(const TabletMeta& a, const TabletMeta& b) { } if (a._in_rest

[GitHub] [doris] github-actions[bot] commented on pull request #16055: [feature](Load)Suppot skip specific lines number for csv stream load

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16055: URL: https://github.com/apache/doris/pull/16055#issuecomment-1411340298 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Add cluster_token auth for stream load to avoid double auth in mysql load

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1411340550 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15816: [enhance](planner)add parenthesis `()` for expr automatically if necessary

2023-01-31 Thread github-actions
github-actions[bot] commented on code in PR #15816: URL: https://github.com/apache/doris/pull/15816#discussion_r1092677534 ## be/src/io/fs/s3_file_system.h: ## @@ -71,16 +71,14 @@ class S3FileSystem final : public RemoteFileSystem { }; // Guarded by external lock

[GitHub] [doris] github-actions[bot] commented on pull request #16256: [Refactor](function) opt the exec of function with null column

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16256: URL: https://github.com/apache/doris/pull/16256#issuecomment-1411338130 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16190: URL: https://github.com/apache/doris/pull/16190#issuecomment-1411336520 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16159: [datev2](function) make function nullable DEPEND_ON_ARGUMENT

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16159: URL: https://github.com/apache/doris/pull/16159#issuecomment-1411336696 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16269: [fix](auth)fix external catalog cannot use db

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16269: URL: https://github.com/apache/doris/pull/16269#issuecomment-1411333809 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16269: [fix](auth)fix external catalog cannot use db

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16269: URL: https://github.com/apache/doris/pull/16269#issuecomment-1411333841 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16272: [improve](file cache) rename the var QueryContext to QueryFileCacheContext

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16272: URL: https://github.com/apache/doris/pull/16272#issuecomment-1411331900 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16166: [fix](hashjoin) join produce blocks with rows larger than batch size

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16166: URL: https://github.com/apache/doris/pull/16166#issuecomment-1411327884 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16295: [Bug](decimalv3) always use `decimalv3` for `show create table`

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16295: URL: https://github.com/apache/doris/pull/16295#issuecomment-1411309736 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16295: [Bug](decimalv3) always use `decimalv3` for `show create table`

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16295: URL: https://github.com/apache/doris/pull/16295#issuecomment-1411309763 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #10236: [feature] add python-doris

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #10236: URL: https://github.com/apache/doris/pull/10236#issuecomment-1411247473 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of

[GitHub] [doris] github-actions[bot] commented on pull request #16244: [fix](memtracker) Fix high frequency load slow lock in memtracker

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16244: URL: https://github.com/apache/doris/pull/16244#issuecomment-1410866788 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc

2023-01-31 Thread github-actions
github-actions[bot] commented on code in PR #16123: URL: https://github.com/apache/doris/pull/16123#discussion_r1092165206 ## be/src/http/brpc/handler_dispatcher.h: ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [doris] github-actions[bot] commented on pull request #16304: [improvement](multi-catalog) use date/datetimev2 as default col type for catalog table

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16304: URL: https://github.com/apache/doris/pull/16304#issuecomment-1410669996 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16304: [improvement](multi-catalog) use date/datetimev2 as default col type for catalog table

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16304: URL: https://github.com/apache/doris/pull/16304#issuecomment-1410665440 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16256: [Refactor](function) opt the exec of function with null column

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16256: URL: https://github.com/apache/doris/pull/16256#issuecomment-1410598720 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16299: [fix](cooldown) Fix bugs in cooldown single replica files

2023-01-31 Thread github-actions
github-actions[bot] commented on PR #16299: URL: https://github.com/apache/doris/pull/16299#issuecomment-1410520830 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

  1   2   3   4   5   >