[GitHub] [doris] ByteYue commented on pull request #25025: [bugfix](policy) Forbid creating policy with same name with different resource name

2023-09-29 Thread via GitHub
ByteYue commented on PR #25025: URL: https://github.com/apache/doris/pull/25025#issuecomment-1741694691 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] ByteYue commented on pull request #25025: [bugfix](policy) Forbid creating policy with same name with different resource name

2023-09-29 Thread via GitHub
ByteYue commented on PR #25025: URL: https://github.com/apache/doris/pull/25025#issuecomment-1741688705 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #25010: [chore](case) Simplify cold heat separation case

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #25010: URL: https://github.com/apache/doris/pull/25010#issuecomment-1741688053 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #25010: [chore](case) Simplify cold heat separation case

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #25010: URL: https://github.com/apache/doris/pull/25010#issuecomment-1741688037 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] doris-robot commented on pull request #25029: [opt](function) Use Dict to opt the function of time_round

2023-09-29 Thread via GitHub
doris-robot commented on PR #25029: URL: https://github.com/apache/doris/pull/25029#issuecomment-1741687984 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.15 seconds stream load tsv: 562 seconds loaded 74807831229 Bytes,

[GitHub] [doris] doris-robot commented on pull request #25029: [opt](function) Use Dict to opt the function of time_round

2023-09-29 Thread via GitHub
doris-robot commented on PR #25029: URL: https://github.com/apache/doris/pull/25029#issuecomment-1741685089 TeamCity be ut coverage result: Function Coverage: 36.31% (8150/22445) Line Coverage: 28.45% (65203/229163) Region Coverage: 27.40% (33771/123268) Branch Coverage: 24.0

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #25029: [opt](function) Use Dict to opt the function of time_round

2023-09-29 Thread via GitHub
github-actions[bot] commented on code in PR #25029: URL: https://github.com/apache/doris/pull/25029#discussion_r1341909180 ## be/src/vec/runtime/vdatetime_value.h: ## @@ -1524,9 +1524,30 @@ class date_day_offset_dict { static constexpr int DAY_AFTER_EPOCH = 25500; // 2039-

[GitHub] [doris] HappenLee commented on pull request #25029: [opt](function) Use Dict to opt the function of time_round

2023-09-29 Thread via GitHub
HappenLee commented on PR #25029: URL: https://github.com/apache/doris/pull/25029#issuecomment-1741673327 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] HappenLee opened a new pull request, #25029: [opt](function) Use Dict to opt the function of time_round

2023-09-29 Thread via GitHub
HappenLee opened a new pull request, #25029: URL: https://github.com/apache/doris/pull/25029 ## Proposed changes Before: ``` select hour_floor(`@timestamp`, 7) as t, count() as cnt from httplogs_date group by t order by t limit 10; +-++ | t

[GitHub] [doris] doris-robot commented on pull request #25025: [bugfix](policy) Forbid creating policy with same name with different resource name

2023-09-29 Thread via GitHub
doris-robot commented on PR #25025: URL: https://github.com/apache/doris/pull/25025#issuecomment-1741647014 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.25 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes,

[GitHub] [doris] ByteYue commented on pull request #25025: [bugfix](policy) Forbid creating policy with same name with different resource name

2023-09-29 Thread via GitHub
ByteYue commented on PR #25025: URL: https://github.com/apache/doris/pull/25025#issuecomment-1741639201 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #25024: [Fix](replayer) Fix `FE` crash when replaying analysis logs.

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #25024: URL: https://github.com/apache/doris/pull/25024#issuecomment-1741625765 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #25024: [Fix](replayer) Fix `FE` crash when replaying analysis logs.

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #25024: URL: https://github.com/apache/doris/pull/25024#issuecomment-1741625274 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] doris-robot commented on pull request #25007: [FIX](filter) update for filter_by_select logic

2023-09-29 Thread via GitHub
doris-robot commented on PR #25007: URL: https://github.com/apache/doris/pull/25007#issuecomment-1741600808 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.65 seconds stream load tsv: 580 seconds loaded 74807831229 Bytes,

[GitHub] [doris] amorynan commented on pull request #25007: [FIX](filter) update for filter_by_select logic

2023-09-29 Thread via GitHub
amorynan commented on PR #25007: URL: https://github.com/apache/doris/pull/25007#issuecomment-1741564283 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #25007: [FIX](filter) update for filter_by_select logic

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #25007: URL: https://github.com/apache/doris/pull/25007#issuecomment-1741565061 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] doris-robot commented on pull request #25026: [Opt](performance) refactor and opt time round floor function

2023-09-29 Thread via GitHub
doris-robot commented on PR #25026: URL: https://github.com/apache/doris/pull/25026#issuecomment-1741550462 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46 seconds stream load tsv: 579 seconds loaded 74807831229 Bytes, abo

[doris] branch dependabot/maven/fe/org.apache.avro-avro-1.11.3 created (now ef721b3176)

2023-09-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/fe/org.apache.avro-avro-1.11.3 in repository https://gitbox.apache.org/repos/asf/doris.git at ef721b3176 Bump org.apache.avro:avro from 1.11.2 to 1.11.3 in /fe No new

[GitHub] [doris] dependabot[bot] opened a new pull request, #25028: Bump org.apache.avro:avro from 1.11.2 to 1.11.3 in /fe

2023-09-29 Thread via GitHub
dependabot[bot] opened a new pull request, #25028: URL: https://github.com/apache/doris/pull/25028 Bumps org.apache.avro:avro from 1.11.2 to 1.11.3. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.avr

[doris] branch dependabot/maven/fe/be-java-extensions/hudi-scanner/org.apache.avro-avro-1.11.3 created (now c98b6e8928)

2023-09-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/fe/be-java-extensions/hudi-scanner/org.apache.avro-avro-1.11.3 in repository https://gitbox.apache.org/repos/asf/doris.git at c98b6e8928 Bump org.apache.avro:avro in

[GitHub] [doris] dependabot[bot] opened a new pull request, #25027: Bump org.apache.avro:avro from 1.11.2 to 1.11.3 in /fe/be-java-extensions/hudi-scanner

2023-09-29 Thread via GitHub
dependabot[bot] opened a new pull request, #25027: URL: https://github.com/apache/doris/pull/25027 Bumps org.apache.avro:avro from 1.11.2 to 1.11.3. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.avr

[GitHub] [doris] HappenLee commented on pull request #25026: [Opt](performance) refactor and opt time round floor function

2023-09-29 Thread via GitHub
HappenLee commented on PR #25026: URL: https://github.com/apache/doris/pull/25026#issuecomment-1741522641 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] doris-robot commented on pull request #25026: [Opt](performance) refactor and opt time round floor function

2023-09-29 Thread via GitHub
doris-robot commented on PR #25026: URL: https://github.com/apache/doris/pull/25026#issuecomment-1741320352 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.52 seconds stream load tsv: 577 seconds loaded 74807831229 Bytes,

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #25026: [Opt](performance) refactor and opt time round floor function

2023-09-29 Thread via GitHub
github-actions[bot] commented on code in PR #25026: URL: https://github.com/apache/doris/pull/25026#discussion_r1341628679 ## be/src/vec/functions/function_datetime_floor_ceil.cpp: ## @@ -682,97 +755,69 @@ ts1.template date_add_interval(interval); } -template

[GitHub] [doris] HappenLee commented on pull request #25026: [Opt](performance) refactor and opt time round floor function

2023-09-29 Thread via GitHub
HappenLee commented on PR #25026: URL: https://github.com/apache/doris/pull/25026#issuecomment-1741236132 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] HappenLee opened a new pull request, #25026: [Opt](performance) refactor and opt time round floor function

2023-09-29 Thread via GitHub
HappenLee opened a new pull request, #25026: URL: https://github.com/apache/doris/pull/25026 ## Proposed changes Before: ``` [testdb]>select hour_floor(`@timestamp`, 4) as t, count() as cnt from httplogs_date group by t order by t limit 10; +-++

[GitHub] [doris] ByteYue commented on pull request #25025: [bugfix](policy) Forbid creating policy with same name with different resource name

2023-09-29 Thread via GitHub
ByteYue commented on PR #25025: URL: https://github.com/apache/doris/pull/25025#issuecomment-1741198438 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] ByteYue opened a new pull request, #25025: [bugfix](policy) Forbid creating policy with same name with different resource name

2023-09-29 Thread via GitHub
ByteYue opened a new pull request, #25025: URL: https://github.com/apache/doris/pull/25025 ## Proposed changes Issue Number: close #xxx ![image](https://github.com/apache/doris/assets/43750022/bdbf3339-93b2-4678-942f-db627f0fe01b) ## Further comments If th

[GitHub] [doris] doris-robot commented on pull request #25021: [bugfix](DDL) Fix the bug of incorrect partition policy setting

2023-09-29 Thread via GitHub
doris-robot commented on PR #25021: URL: https://github.com/apache/doris/pull/25021#issuecomment-1741147783 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.8 seconds stream load tsv: 574 seconds loaded 74807831229 Bytes, a

[GitHub] [doris] ByteYue commented on pull request #25021: [bugfix](DDL) Fix the bug of incorrect partition policy setting

2023-09-29 Thread via GitHub
ByteYue commented on PR #25021: URL: https://github.com/apache/doris/pull/25021#issuecomment-1741079928 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] ByteYue commented on pull request #25010: [chore](case) Simplify cold heat separation case

2023-09-29 Thread via GitHub
ByteYue commented on PR #25010: URL: https://github.com/apache/doris/pull/25010#issuecomment-1741079206 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] yiguolei merged pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
yiguolei merged PR #23395: URL: https://github.com/apache/doris/pull/23395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] yiguolei closed issue #23825: [Enhancement] Make `class Status` `[[nodiscard]]` to force the developer to consider error handling seriously

2023-09-29 Thread via GitHub
yiguolei closed issue #23825: [Enhancement] Make `class Status` `[[nodiscard]]` to force the developer to consider error handling seriously URL: https://github.com/apache/doris/issues/23825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [doris] github-actions[bot] commented on pull request #24735: [enhancement](invert index) read columns by index reduce seek time

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #24735: URL: https://github.com/apache/doris/pull/24735#issuecomment-1740976267 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #25017: [Bug](migration) Enhance invalid behavior handling in `copy_files_to`

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #25017: URL: https://github.com/apache/doris/pull/25017#issuecomment-1740977393 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] doris-robot commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
doris-robot commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740871936 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.02 seconds stream load tsv: 580 seconds loaded 74807831229 Bytes,

[GitHub] [doris] doris-robot commented on pull request #25012: [Opt](parquet reader) Optimize the performance of reading decimal in parquet reader.

2023-09-29 Thread via GitHub
doris-robot commented on PR #25012: URL: https://github.com/apache/doris/pull/25012#issuecomment-1740872370 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.09 seconds stream load tsv: 586 seconds loaded 74807831229 Bytes,

[GitHub] [doris] doris-robot commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
doris-robot commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740848969 TeamCity be ut coverage result: Function Coverage: 36.30% (8145/22440) Line Coverage: 28.44% (65160/229131) Region Coverage: 27.38% (33750/123247) Branch Coverage: 24.0

[GitHub] [doris] github-actions[bot] commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740838335 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740808308 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] yiguolei commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
yiguolei commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740807407 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] yiguolei commented on a diff in pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
yiguolei commented on code in PR #23395: URL: https://github.com/apache/doris/pull/23395#discussion_r1341295695 ## be/src/vec/sink/writer/vtablet_writer.cpp: ## @@ -1686,7 +1686,7 @@ Status VTabletWriter::append_block(doris::vectorized::Block& input_block) { int result

[GitHub] [doris] github-actions[bot] commented on pull request #25012: [Opt](parquet reader) Optimize the performance of reading decimal in parquet reader.

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #25012: URL: https://github.com/apache/doris/pull/25012#issuecomment-1740792779 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] kaka11chen commented on pull request #25012: [Opt](parquet reader) Optimize the performance of reading decimal in parquet reader.

2023-09-29 Thread via GitHub
kaka11chen commented on PR #25012: URL: https://github.com/apache/doris/pull/25012#issuecomment-1740782753 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] doris-robot commented on pull request #25024: [Fix](replayer) Fix `FE` crash when replaying analysis logs.

2023-09-29 Thread via GitHub
doris-robot commented on PR #25024: URL: https://github.com/apache/doris/pull/25024#issuecomment-1740719356 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.92 seconds stream load tsv: 583 seconds loaded 74807831229 Bytes,

[GitHub] [doris] dutyu commented on pull request #25024: [Fix](replayer) Fix `FE` crash when replaying analysis logs.

2023-09-29 Thread via GitHub
dutyu commented on PR #25024: URL: https://github.com/apache/doris/pull/25024#issuecomment-1740663564 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] doris-robot commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
doris-robot commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740647865 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.31 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes,

[GitHub] [doris] dutyu opened a new pull request, #25024: [Fix](replayer) Fix `FE` crash when replaying analysis logs.

2023-09-29 Thread via GitHub
dutyu opened a new pull request, #25024: URL: https://github.com/apache/doris/pull/25024 ## Proposed changes Issue Number: close #25023 Check if current `FE` is a master node. ## Further comments If this is a relatively large or complex change, kick off the discuss

[GitHub] [doris] doris-robot commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
doris-robot commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740629410 TeamCity be ut coverage result: Function Coverage: 36.30% (8145/22440) Line Coverage: 28.44% (65176/229131) Region Coverage: 27.39% (33757/123248) Branch Coverage: 24.0

[GitHub] [doris] github-actions[bot] commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740623557 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] dutyu opened a new issue, #25023: [Bug] FE exit when replaying analysis log

2023-09-29 Thread via GitHub
dutyu opened a new issue, #25023: URL: https://github.com/apache/doris/issues/25023 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's W

[GitHub] [doris] doris-robot commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
doris-robot commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740614089 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.34 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes,

[GitHub] [doris] doris-robot commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
doris-robot commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740613867 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.64 seconds stream load tsv: 578 seconds loaded 74807831229 Bytes,

[GitHub] [doris] bobhan1 commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
bobhan1 commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740588715 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740527228 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #25012: [Opt](parquet reader) Optimize the performance of reading decimal in parquet reader.

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #25012: URL: https://github.com/apache/doris/pull/25012#issuecomment-1740521936 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740521707 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] kaka11chen commented on pull request #25012: [Opt](parquet reader) Optimize the performance of reading decimal in parquet reader.

2023-09-29 Thread via GitHub
kaka11chen commented on PR #25012: URL: https://github.com/apache/doris/pull/25012#issuecomment-1740511474 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
github-actions[bot] commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740500200 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] bobhan1 commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
bobhan1 commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740498228 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] bobhan1 commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly

2023-09-29 Thread via GitHub
bobhan1 commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1740495622 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] TangSiyang2001 commented on pull request #23620: [enhancement](table-property) forbid old schema change

2023-09-29 Thread via GitHub
TangSiyang2001 commented on PR #23620: URL: https://github.com/apache/doris/pull/23620#issuecomment-1740477198 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] BiteTheDDDDt commented on pull request #24966: [Improvement](hash) refactor of hash map context

2023-09-29 Thread via GitHub
BiteThet commented on PR #24966: URL: https://github.com/apache/doris/pull/24966#issuecomment-1740424168 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #24966: [Improvement](hash) refactor of hash map context

2023-09-29 Thread via GitHub
github-actions[bot] commented on code in PR #24966: URL: https://github.com/apache/doris/pull/24966#discussion_r1340996953 ## be/src/vec/columns/column_decimal.h: ## @@ -159,14 +159,13 @@ class ColumnDecimal final : public COWHelperhttp://www.apache.org/licenses/LICENSE-2.0 +//