yiguolei commented on code in PR #23395:
URL: https://github.com/apache/doris/pull/23395#discussion_r1341295695
##########
be/src/vec/sink/writer/vtablet_writer.cpp:
##########
@@ -1686,7 +1686,7 @@ Status
VTabletWriter::append_block(doris::vectorized::Block& input_block) {
int result_idx;
if (_vpartition->is_projection_partition()) {
// calc the start value of missing partition ranges.
- part_func->execute(part_ctx.get(), block.get(), &result_idx);
+ RETURN_IF_ERROR(part_func->execute(part_ctx.get(), block.get(),
&result_idx));
Review Comment:
not change it
##########
be/src/vec/sink/writer/vfile_result_writer.cpp:
##########
@@ -393,7 +393,7 @@ Status VFileResultWriter::_delete_dir() {
case TStorageBackendType::HDFS: {
THdfsParams hdfs_params =
parse_properties(_file_opts->broker_properties);
std::shared_ptr<io::HdfsFileSystem> hdfs_fs = nullptr;
- RETURN_IF_ERROR(
+ static_cast<void>(
Review Comment:
why chnage it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
