[GitHub] [doris] github-actions[bot] commented on pull request #18736: [enhance](buffered reader)add bvar to detect download bytes and download speed

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18736: URL: https://github.com/apache/doris/pull/18736#issuecomment-1510805929 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] gavinchou commented on pull request #18530: [enhancement](mysql) enable two-way ssl authentication

2023-04-16 Thread via GitHub
gavinchou commented on PR #18530: URL: https://github.com/apache/doris/pull/18530#issuecomment-1510803163 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [doris] ByteYue commented on pull request #18736: [enhance](buffered reader)add bvar to detect download bytes and download speed

2023-04-16 Thread via GitHub
ByteYue commented on PR #18736: URL: https://github.com/apache/doris/pull/18736#issuecomment-1510802435 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] ByteYue opened a new pull request, #18736: [enhance](buffered reader)add bvar to detect download bytes and download speed

2023-04-16 Thread via GitHub
ByteYue opened a new pull request, #18736: URL: https://github.com/apache/doris/pull/18736 # Proposed changes Issue Number: close #xxx Add bvar to detect the speed and downloaded bytes for buffered reader ![image](https://user-images.githubusercontent.com/43750022/232407713-

[GitHub] [doris] github-actions[bot] commented on pull request #18735: [chore](hashtable) Use doris' Allocator to replace std::allocator in phmap

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18735: URL: https://github.com/apache/doris/pull/18735#issuecomment-1510801634 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #17585: [feature](io) enable s3 file writer with multi part uploading concurrently

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #17585: URL: https://github.com/apache/doris/pull/17585#issuecomment-1510801358 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #18734: [fix](merge-on-write) enable_unique_key_merge_on_write property should only be used for unique table

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18734: URL: https://github.com/apache/doris/pull/18734#issuecomment-1510798508 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18734: [fix](merge-on-write) enable_unique_key_merge_on_write property should only be used for unique table

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18734: URL: https://github.com/apache/doris/pull/18734#issuecomment-1510798462 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] ByteYue commented on pull request #17585: [feature](io) enable s3 file writer with multi part uploading concurrently

2023-04-16 Thread via GitHub
ByteYue commented on PR #17585: URL: https://github.com/apache/doris/pull/17585#issuecomment-1510797110 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] mrhhsg opened a new pull request, #18735: [chore](hashtable) Use doris' Allocator to replace std::allocator in phmap

2023-04-16 Thread via GitHub
mrhhsg opened a new pull request, #18735: URL: https://github.com/apache/doris/pull/18735 # Proposed changes There is a logic for monitoring memory usage in Doris' `Allocator`, so this pr use `Allocator` to replace `std::allocator` in phmap. ## Problem summary Descri

[GitHub] [doris] liaoxin01 commented on pull request #18734: [fix](merge-on-write) enable_unique_key_merge_on_write property should only be used for unique table

2023-04-16 Thread via GitHub
liaoxin01 commented on PR #18734: URL: https://github.com/apache/doris/pull/18734#issuecomment-1510795850 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] liaoxin01 opened a new pull request, #18734: [fix](merge-on-write) enable_unique_key_merge_on_write property should only be used for unique table

2023-04-16 Thread via GitHub
liaoxin01 opened a new pull request, #18734: URL: https://github.com/apache/doris/pull/18734 # Proposed changes Issue Number: close #xxx ## Problem summary enable_unique_key_merge_on_write property should only be used for unique table. When creating a DUP or AGG tabl

[GitHub] [doris] github-actions[bot] commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18721: URL: https://github.com/apache/doris/pull/18721#issuecomment-1510794467 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Gabriel39 opened a new pull request, #18733: [Bug](DECIMALV3) report failure if a decimal value is overflow (#18336)

2023-04-16 Thread via GitHub
Gabriel39 opened a new pull request, #18733: URL: https://github.com/apache/doris/pull/18733 # Proposed changes pick #18336 ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been a

[GitHub] [doris] TangSiyang2001 commented on issue #18732: [Bug] support altering the property "light_schema_change" for the old tables cause rename colunm fail

2023-04-16 Thread via GitHub
TangSiyang2001 commented on issue #18732: URL: https://github.com/apache/doris/issues/18732#issuecomment-1510792815 Bug is confirmed to be caused by missing enough replay logic, so that it fails in multi-FEs case. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [doris] github-actions[bot] commented on pull request #18669: [feature](Nereids): pullup semiJoin through aggregate.

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18669: URL: https://github.com/apache/doris/pull/18669#issuecomment-1510792454 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18669: [feature](Nereids): pullup semiJoin through aggregate.

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18669: URL: https://github.com/apache/doris/pull/18669#issuecomment-1510792419 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18721: URL: https://github.com/apache/doris/pull/18721#issuecomment-1510790057 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] LemonLiTree commented on a diff in pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

2023-04-16 Thread via GitHub
LemonLiTree commented on code in PR #18721: URL: https://github.com/apache/doris/pull/18721#discussion_r1168244015 ## be/src/geo/wkb_parse.cpp: ## @@ -43,6 +87,36 @@ GeoParseStatus WkbParse::parse_wkb(std::istream& is, bool isEwkb, GeoShape** sha return ctx.parse_status;

[GitHub] [doris] SWJTU-ZhangLei commented on issue #18732: [Bug] support altering the property "light_schema_change" for the old tables cause rename colunm fail

2023-04-16 Thread via GitHub
SWJTU-ZhangLei commented on issue #18732: URL: https://github.com/apache/doris/issues/18732#issuecomment-1510777516 this bug is introduced by https://github.com/apache/doris/pull/17704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] SWJTU-ZhangLei opened a new issue, #18732: [Bug] support altering the property "light_schema_change" for the old tables cause rename colunm fail

2023-04-16 Thread via GitHub
SWJTU-ZhangLei opened a new issue, #18732: URL: https://github.com/apache/doris/issues/18732 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master d2efc619b0

[GitHub] [doris] github-actions[bot] commented on pull request #18615: [Feature](orc-reader) Implements ORC lazy materialization.

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18615: URL: https://github.com/apache/doris/pull/18615#issuecomment-1510770657 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4718082281";) output. shellcheck err

[GitHub] [doris] aprilsoo commented on issue #17176: [Good First Issue] Doris' Future

2023-04-16 Thread via GitHub
aprilsoo commented on issue #17176: URL: https://github.com/apache/doris/issues/17176#issuecomment-1510762321 I would like to give it a try,please assign it to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] amorynan commented on pull request #18627: [Refact](type system) refact serde for type system and pb serde impl

2023-04-16 Thread via GitHub
amorynan commented on PR #18627: URL: https://github.com/apache/doris/pull/18627#issuecomment-1510753793 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [doris] nextdreamblue commented on pull request #18731: (fix)[olap] not support in_memory=true now

2023-04-16 Thread via GitHub
nextdreamblue commented on PR #18731: URL: https://github.com/apache/doris/pull/18731#issuecomment-1510743705 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] jackwener commented on pull request #18599: [feature](Nereids): infer not null from Agg Count() without groupby.

2023-04-16 Thread via GitHub
jackwener commented on PR #18599: URL: https://github.com/apache/doris/pull/18599#issuecomment-1510742491 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [doris] nextdreamblue commented on pull request #18731: (fix)[olap] not support in_memory=true now

2023-04-16 Thread via GitHub
nextdreamblue commented on PR #18731: URL: https://github.com/apache/doris/pull/18731#issuecomment-1510741248 sh buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] nextdreamblue opened a new pull request, #18731: (fix)[olap] not support in_memory=true now

2023-04-16 Thread via GitHub
nextdreamblue opened a new pull request, #18731: URL: https://github.com/apache/doris/pull/18731 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ]

[GitHub] [doris] ZhangYu0123 commented on a diff in pull request #18692: [optimize](string) optimize instr and locate function for constant arguments

2023-04-16 Thread via GitHub
ZhangYu0123 commented on code in PR #18692: URL: https://github.com/apache/doris/pull/18692#discussion_r1168181847 ## be/src/vec/functions/function_string.h: ## @@ -2292,30 +2292,76 @@ class FunctionStringLocatePos : public IFunction { Status execute_impl(FunctionContext*

[doris] branch branch-1.2-lts updated (346b0b05ac -> b6448285d5)

2023-04-16 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git from 346b0b05ac [improvement](release) add release download scripts (#18703) add b6448285d5 [enhancement](p

[GitHub] [doris] zclllyybb commented on pull request #18730: Revert "[refactor](planner) using crchash replace murmurhash in the runtime filter"

2023-04-16 Thread via GitHub
zclllyybb commented on PR #18730: URL: https://github.com/apache/doris/pull/18730#issuecomment-1510724280 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] zclllyybb commented on pull request #18730: Revert "[refactor](planner) using crchash replace murmurhash in the runtime filter"

2023-04-16 Thread via GitHub
zclllyybb commented on PR #18730: URL: https://github.com/apache/doris/pull/18730#issuecomment-1510724190 tpcds_sf1_p1_q85 failed. https://github.com/apache/doris/pull/18472 didn't really test for this because it didn't change be_exec_version in FE. after test in https://github.com/apache/d

[GitHub] [doris] github-actions[bot] commented on pull request #18730: Revert "[refactor](planner) using crchash replace murmurhash in the runtime filter"

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18730: URL: https://github.com/apache/doris/pull/18730#issuecomment-1510724067 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated (5300b21db7 -> 1e06763366)

2023-04-16 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 5300b21db7 [Bug](DECIMALV3) report failure if a decimal value is overflow (#18336) add 1e06763366 [fix](bitmap)

[GitHub] [doris] yiguolei closed issue #17841: [Bug] [daily] bitmap_count() cause BE core

2023-04-16 Thread via GitHub
yiguolei closed issue #17841: [Bug] [daily] bitmap_count() cause BE core URL: https://github.com/apache/doris/issues/17841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] Mryange opened a new pull request, #18730: Revert "[refactor](planner) using crchash replace murmurhash in the runtime filter"

2023-04-16 Thread via GitHub
Mryange opened a new pull request, #18730: URL: https://github.com/apache/doris/pull/18730 Reverts apache/doris#18472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] yiguolei merged pull request #18689: [fix](bitmap) fix bitmap_count errors to set nullable to non-nullable bitmap col

2023-04-16 Thread via GitHub
yiguolei merged PR #18689: URL: https://github.com/apache/doris/pull/18689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] yiguolei merged pull request #18336: [Bug](DECIMALV3) report failure if a decimal value is overflow

2023-04-16 Thread via GitHub
yiguolei merged PR #18336: URL: https://github.com/apache/doris/pull/18336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] bigben0204 opened a new pull request, #18729: [Feature] Add a new rest api to query instance host and ip information for query profile action in branch-1.2-lts

2023-04-16 Thread via GitHub
bigben0204 opened a new pull request, #18729: URL: https://github.com/apache/doris/pull/18729 # Proposed changes Issue Number: close 18726 ## Problem summary Add a new api to query instance host ip and port ## Checklist(Required) * [ ] Does it affect the ori

[GitHub] [doris] Gabriel39 merged pull request #18715: [Opt](pipeline) opt pipeline shared scan

2023-04-16 Thread via GitHub
Gabriel39 merged PR #18715: URL: https://github.com/apache/doris/pull/18715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated (9e960f4c4f -> eb128753ac)

2023-04-16 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 9e960f4c4f [chore](build) Use include-what-you-use to optimize includes (#18681) add eb128753ac [Opt](pipelin

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

2023-04-16 Thread via GitHub
github-actions[bot] commented on code in PR #18721: URL: https://github.com/apache/doris/pull/18721#discussion_r1168166090 ## be/src/geo/wkb_parse.cpp: ## @@ -43,6 +87,36 @@ GeoParseStatus WkbParse::parse_wkb(std::istream& is, bool isEwkb, GeoShape** sha return ctx.parse_s

[GitHub] [doris] bigben0204 closed pull request #18728: [Feature] Add a new rest api to query instance host and ip information for query profile action in branch-1.2-lts #18726

2023-04-16 Thread via GitHub
bigben0204 closed pull request #18728: [Feature] Add a new rest api to query instance host and ip information for query profile action in branch-1.2-lts #18726 URL: https://github.com/apache/doris/pull/18728 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [doris] hello-stephen commented on pull request #18723: [Bug](DECIMAL) Fix bug for arithmatic expr DECIMALV2 / DECIMALV3

2023-04-16 Thread via GitHub
hello-stephen commented on PR #18723: URL: https://github.com/apache/doris/pull/18723#issuecomment-1510698030 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.6 seconds stream load tsv: 433 seconds loaded 74807831229 Bytes, about 164 MB/s

[GitHub] [doris] bigben0204 opened a new pull request, #18728: [Feature] Add a new rest api to query instance host and ip information for query profile action in branch-1.2-lts #18726

2023-04-16 Thread via GitHub
bigben0204 opened a new pull request, #18728: URL: https://github.com/apache/doris/pull/18728 # Proposed changes Issue Number: close #18726 ## Problem summary Add a new api to query instance host ip and port ## Checklist(Required) * [ ] Does it affect the or

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #18421: [enhancement](load) merge single-replica related services as non-standalone

2023-04-16 Thread via GitHub
TangSiyang2001 commented on code in PR #18421: URL: https://github.com/apache/doris/pull/18421#discussion_r1168154170 ## be/src/http/action/download_action.cpp: ## @@ -114,6 +126,14 @@ void DownloadAction::handle_error_log(HttpRequest* req, const std::string& file_ } void D

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #18421: [enhancement](load) merge single-replica related services as non-standalone

2023-04-16 Thread via GitHub
TangSiyang2001 commented on code in PR #18421: URL: https://github.com/apache/doris/pull/18421#discussion_r1168154170 ## be/src/http/action/download_action.cpp: ## @@ -114,6 +126,14 @@ void DownloadAction::handle_error_log(HttpRequest* req, const std::string& file_ } void D

[GitHub] [doris] hello-stephen commented on pull request #18715: [Opt](pipeline) opt pipeline shared scan

2023-04-16 Thread via GitHub
hello-stephen commented on PR #18715: URL: https://github.com/apache/doris/pull/18715#issuecomment-1510685716 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.28 seconds stream load tsv: 432 seconds loaded 74807831229 Bytes, about 165 MB/s

[GitHub] [doris] gojumprope opened a new issue, #18727: [Bug] explode_split unable to split NULL value, return empty result

2023-04-16 Thread via GitHub
gojumprope opened a new issue, #18727: URL: https://github.com/apache/doris/issues/18727 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2.3 ### What

[GitHub] [doris] hello-stephen commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

2023-04-16 Thread via GitHub
hello-stephen commented on PR #18721: URL: https://github.com/apache/doris/pull/18721#issuecomment-1510684140 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 32.49 seconds stream load tsv: 437 seconds loaded 74807831229 Bytes, about 163 MB/s

[GitHub] [doris] platoneko commented on pull request #18688: [fix](replica) Fix inconsistent replica id between FE and BE

2023-04-16 Thread via GitHub
platoneko commented on PR #18688: URL: https://github.com/apache/doris/pull/18688#issuecomment-1510678598 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] bigben0204 opened a new issue, #18726: [Feature] Add a new rest api to query instance host and ip information for query profile action in branch-1.2-lts

2023-04-16 Thread via GitHub
bigben0204 opened a new issue, #18726: URL: https://github.com/apache/doris/issues/18726 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Currently the api

[GitHub] [doris] jackwener commented on pull request #18675: [fix](Nereids): fix sum func in eager agg

2023-04-16 Thread via GitHub
jackwener commented on PR #18675: URL: https://github.com/apache/doris/pull/18675#issuecomment-1510671229 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [doris] bigben0204 opened a new pull request, #18725: [Feature] Add a new rest api to query instance host and ip information for query profile action in branch master #18668

2023-04-16 Thread via GitHub
bigben0204 opened a new pull request, #18725: URL: https://github.com/apache/doris/pull/18725 # Proposed changes Issue Number: close #18668 ## Problem summary Add a new api to query instance host ip and port ## Checklist(Required) * [ ] Does it affect the or

[GitHub] [doris] github-actions[bot] commented on pull request #18541: [Feature](aggregate) support generic aggregate functions on pre-aggregate model

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18541: URL: https://github.com/apache/doris/pull/18541#issuecomment-1510656246 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zhangstar333 commented on pull request #18676: [vectorzied](function) fix array_map function analyzed failed with order by clause

2023-04-16 Thread via GitHub
zhangstar333 commented on PR #18676: URL: https://github.com/apache/doris/pull/18676#issuecomment-1510652621 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] BiteTheDDDDt merged pull request #18681: [chore](build) Use include-what-you-use to optimize includes

2023-04-16 Thread via GitHub
BiteThet merged PR #18681: URL: https://github.com/apache/doris/pull/18681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

[GitHub] [doris] zclllyybb commented on a diff in pull request #18557: [feature](function) support array_count function

2023-04-16 Thread via GitHub
zclllyybb commented on code in PR #18557: URL: https://github.com/apache/doris/pull/18557#discussion_r1168127735 ## be/src/vec/functions/array/function_array_count.cpp: ## @@ -0,0 +1,154 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

[doris] branch master updated (b5b0148010 -> a2278dbc6c)

2023-04-16 Thread englefly
This is an automated email from the ASF dual-hosted git repository. englefly pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b5b0148010 [feature](Nereids): when cost time > 5s, throw timeout Exception (#18316) add a2278dbc6c [opt](nerei

[GitHub] [doris] englefly merged pull request #18716: [opt](nereids) optimize filter estimation for pattern "col=col"

2023-04-16 Thread via GitHub
englefly merged PR #18716: URL: https://github.com/apache/doris/pull/18716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] zhangstar333 opened a new pull request, #18724: [refactor](jdbc) close datasource if no need to maintain the cache

2023-04-16 Thread via GitHub
zhangstar333 opened a new pull request, #18724: URL: https://github.com/apache/doris/pull/18724 # Proposed changes after pr #18670 could use jvm parameters to init jdbc datasource, but when set JDBC_MIN_POOL=0, it can be immediately closed. There is no need to wait for the recycli

[GitHub] [doris] zclllyybb commented on a diff in pull request #18692: [optimize](string) optimize instr and locate function for constant arguments

2023-04-16 Thread via GitHub
zclllyybb commented on code in PR #18692: URL: https://github.com/apache/doris/pull/18692#discussion_r1168127145 ## be/src/vec/functions/function_string.h: ## @@ -2292,30 +2292,76 @@ class FunctionStringLocatePos : public IFunction { Status execute_impl(FunctionContext* c

[GitHub] [doris] Gabriel39 commented on pull request #18723: [Bug](DECIMAL) Fix bug for arithmatic expr DECIMALV2 / DECIMALV3

2023-04-16 Thread via GitHub
Gabriel39 commented on PR #18723: URL: https://github.com/apache/doris/pull/18723#issuecomment-1510650422 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] Gabriel39 opened a new pull request, #18723: [Bug](DECIMAL) Fix bug for arithmatic expr DECIMALV2 / DECIMALV3

2023-04-16 Thread via GitHub
Gabriel39 opened a new pull request, #18723: URL: https://github.com/apache/doris/pull/18723 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] LemonLiTree commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

2023-04-16 Thread via GitHub
LemonLiTree commented on PR #18721: URL: https://github.com/apache/doris/pull/18721#issuecomment-1510649634 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #18722: [feature](segcompaction) enable segcompaction by default

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18722: URL: https://github.com/apache/doris/pull/18722#issuecomment-1510649625 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] freemandealer commented on pull request #18722: [feature](segcompaction) enable segcompaction by default

2023-04-16 Thread via GitHub
freemandealer commented on PR #18722: URL: https://github.com/apache/doris/pull/18722#issuecomment-1510647915 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] freemandealer commented on pull request #18576: [feature](segcompaction) enable segcompaction by default

2023-04-16 Thread via GitHub
freemandealer commented on PR #18576: URL: https://github.com/apache/doris/pull/18576#issuecomment-1510647760 > @freemandealer please submit to doris master directly @yiguolei done #18722 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [doris] freemandealer opened a new pull request, #18722: [feature](segcompaction) enable segcompaction by default

2023-04-16 Thread via GitHub
freemandealer opened a new pull request, #18722: URL: https://github.com/apache/doris/pull/18722 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ]

[GitHub] [doris] hello-stephen commented on pull request #18627: [Refact](type system) refact serde for type system and pb serde impl

2023-04-16 Thread via GitHub
hello-stephen commented on PR #18627: URL: https://github.com/apache/doris/pull/18627#issuecomment-1510646027 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.17 seconds stream load tsv: 434 seconds loaded 74807831229 Bytes, about 164 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #18716: [opt](nereids) optimize filter estimation for pattern "col=col"

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18716: URL: https://github.com/apache/doris/pull/18716#issuecomment-1510643282 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18716: [opt](nereids) optimize filter estimation for pattern "col=col"

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18716: URL: https://github.com/apache/doris/pull/18716#issuecomment-1510643266 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18715: [Opt](pipeline) opt pipeline shared scan

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18715: URL: https://github.com/apache/doris/pull/18715#issuecomment-1510640048 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated (32c1d0acea -> b5b0148010)

2023-04-16 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 32c1d0acea [typo](docs) Add directory level for ST doc (#18719) add b5b0148010 [feature](Nereids): when cost time

[GitHub] [doris] jackwener merged pull request #18316: [feature](Nereids): when cost time > 5s, throw timeout Exception

2023-04-16 Thread via GitHub
jackwener merged PR #18316: URL: https://github.com/apache/doris/pull/18316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] CalvinKirs commented on pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern

2023-04-16 Thread via GitHub
CalvinKirs commented on PR #18666: URL: https://github.com/apache/doris/pull/18666#issuecomment-1510637913 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] HappenLee commented on pull request #18715: [Opt](pipeline) opt pipeline shared scan

2023-04-16 Thread via GitHub
HappenLee commented on PR #18715: URL: https://github.com/apache/doris/pull/18715#issuecomment-1510637891 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] github-actions[bot] commented on pull request #18316: [feature](Nereids): when cost time > 5s, throw timeout Exception

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18316: URL: https://github.com/apache/doris/pull/18316#issuecomment-1510637798 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18316: [feature](Nereids): when cost time > 5s, throw timeout Exception

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18316: URL: https://github.com/apache/doris/pull/18316#issuecomment-1510637816 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18231: [feature](array_cum_sum) Support array_cum_sum function

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18231: URL: https://github.com/apache/doris/pull/18231#issuecomment-1510635041 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated (a8a133b497 -> 32c1d0acea)

2023-04-16 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a8a133b497 [typo](docs)Optimize Monitoring and alarming documentation (#18718) add 32c1d0acea [typo](docs) Add

[GitHub] [doris] luzhijing merged pull request #18719: [typo](docs) Add directory level for ST doc

2023-04-16 Thread via GitHub
luzhijing merged PR #18719: URL: https://github.com/apache/doris/pull/18719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] github-actions[bot] commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18721: URL: https://github.com/apache/doris/pull/18721#issuecomment-1510634027 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] brody715 commented on pull request #18231: [feature](array_cum_sum) Support array_cum_sum function

2023-04-16 Thread via GitHub
brody715 commented on PR #18231: URL: https://github.com/apache/doris/pull/18231#issuecomment-1510633446 @zhangstar333 Hello, I've resolved the conflict to merge to the latest master right now. What do I need to do to continue the PR? -- This is an automated message from the Apache Git Se

[GitHub] [doris] LemonLiTree opened a new pull request, #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

2023-04-16 Thread via GitHub
LemonLiTree opened a new pull request, #18721: URL: https://github.com/apache/doris/pull/18721 1. mysql> select ST_AsBinary(st_point(24.7, 56.7)); +--+ | st_asbinary(st_point(24.7, 56.7))| +--

[GitHub] [doris] luzhijing merged pull request #18718: [typo](docs)Optimize Monitoring and alarming documentation

2023-04-16 Thread via GitHub
luzhijing merged PR #18718: URL: https://github.com/apache/doris/pull/18718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated (3eac53f75d -> a8a133b497)

2023-04-16 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 3eac53f75d [enhancement](Nereids) optimize bloom filter size reducing strategy (#18596) add a8a133b497 [typo](

[GitHub] [doris] github-actions[bot] commented on pull request #18719: [typo](docs) Add directory level for ST doc

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18719: URL: https://github.com/apache/doris/pull/18719#issuecomment-1510623403 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18719: [typo](docs) Add directory level for ST doc

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18719: URL: https://github.com/apache/doris/pull/18719#issuecomment-1510623364 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] levy5307 commented on pull request #18249: [refactor](fe): Remove resource group which is useless

2023-04-16 Thread via GitHub
levy5307 commented on PR #18249: URL: https://github.com/apache/doris/pull/18249#issuecomment-1510620279 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18702: URL: https://github.com/apache/doris/pull/18702#issuecomment-1510615899 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] gitccl commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped

2023-04-16 Thread via GitHub
gitccl commented on PR #18702: URL: https://github.com/apache/doris/pull/18702#issuecomment-1510615730 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] weizuo93 commented on a diff in pull request #18421: [enhancement](load) merge single-replica related services as non-standalone

2023-04-16 Thread via GitHub
weizuo93 commented on code in PR #18421: URL: https://github.com/apache/doris/pull/18421#discussion_r1168110824 ## be/src/http/action/download_action.cpp: ## @@ -114,6 +126,14 @@ void DownloadAction::handle_error_log(HttpRequest* req, const std::string& file_ } void Downloa

[GitHub] [doris] Kikyou1997 commented on pull request #18720: [fix](stats) Stats still in cache when user dropped it.

2023-04-16 Thread via GitHub
Kikyou1997 commented on PR #18720: URL: https://github.com/apache/doris/pull/18720#issuecomment-1510615509 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[doris] branch master updated: [enhancement](Nereids) optimize bloom filter size reducing strategy (#18596)

2023-04-16 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 3eac53f75d [enhancement](Nereids) optimize bl

[GitHub] [doris] Gabriel39 merged pull request #18596: [enhancement](Nereids) optimize bloom filter size computing strategy

2023-04-16 Thread via GitHub
Gabriel39 merged PR #18596: URL: https://github.com/apache/doris/pull/18596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] Kikyou1997 opened a new pull request, #18720: [fix](stats) Stats still in cache when user dropped it.

2023-04-16 Thread via GitHub
Kikyou1997 opened a new pull request, #18720: URL: https://github.com/apache/doris/pull/18720 # Proposed changes 1. Evict the dropped stats from cache 2. Remove codes for the partition level stats collection ## Checklist(Required) * [ ] Does it affect the original beha

[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL

2023-04-16 Thread via GitHub
github-actions[bot] commented on PR #18565: URL: https://github.com/apache/doris/pull/18565#issuecomment-1510607908 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yixiutt commented on pull request #18643: [improvement](merge-on-write) move segment check to delta writer

2023-04-16 Thread via GitHub
yixiutt commented on PR #18643: URL: https://github.com/apache/doris/pull/18643#issuecomment-1510607386 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] zy-kkk commented on pull request #18719: [typo](docs) Add directory level for ST doc

2023-04-16 Thread via GitHub
zy-kkk commented on PR #18719: URL: https://github.com/apache/doris/pull/18719#issuecomment-1510606416 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

  1   2   3   >