github-actions[bot] commented on PR #18615:
URL: https://github.com/apache/doris/pull/18615#issuecomment-1510770657
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/4718082281";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 253:
if [ $? -ne 0 ]; then
^----------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
Did you mean:
if [[ $? -ne 0 ]]; then
In build.sh line 255:
mkdir -p ${DORIS_HOME}/be/src/apache-orc
^-----------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
mkdir -p "${DORIS_HOME}"/be/src/apache-orc
In build.sh line 256:
curl -L
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.zip | tar -xz
-C ${DORIS_HOME}/be/src/apache-orc
^-----------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
curl -L
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.zip | tar -xz
-C "${DORIS_HOME}"/be/src/apache-orc
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with
e.g...
https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests
i...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -251,9 +251,9 @@
echo "apache-orc not exists, need to update submodules ..."
git submodule update --init --recursive
if [ $? -ne 0 ]; then
- wget
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.zip
- mkdir -p ${DORIS_HOME}/be/src/apache-orc
- curl -L
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.zip | tar -xz
-C ${DORIS_HOME}/be/src/apache-orc
+ wget
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.zip
+ mkdir -p ${DORIS_HOME}/be/src/apache-orc
+ curl -L
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.zip | tar -xz
-C ${DORIS_HOME}/be/src/apache-orc
fi
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
