[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-24 Thread via GitHub
amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1086264303 ## be/src/vec/functions/array/function_array_element.h: ## @@ -44,12 +46,18 @@ class FunctionArrayElement : public IFunction { size_t get_number_of_arguments() co

[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-24 Thread via GitHub
amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1086258307 ## be/src/vec/olap/olap_data_convertor.cpp: ## @@ -712,4 +723,79 @@ Status OlapBlockDataConvertor::OlapColumnDataConvertorArray::convert_to_olap( return Status::

[GitHub] [doris] dutyu commented on a diff in pull request #15128: [Feature](export) Support cancel export statement

2023-01-24 Thread via GitHub
dutyu commented on code in PR #15128: URL: https://github.com/apache/doris/pull/15128#discussion_r1086250497 ## fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java: ## @@ -294,12 +351,12 @@ public void replayCreateExportJob(ExportJob job) { } public void re

[GitHub] [doris] yiguolei merged pull request #16138: [refactor](remove non vec code) remove non vec functions and AggregateInfo

2023-01-24 Thread via GitHub
yiguolei merged PR #16138: URL: https://github.com/apache/doris/pull/16138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #16138: [refactor](remove non vec code) remove non vec functions and AggregateInfo

2023-01-24 Thread github-actions
github-actions[bot] commented on PR #16138: URL: https://github.com/apache/doris/pull/16138#issuecomment-1403075755 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16138: [refactor](remove non vec code) remove non vec functions and AggregateInfo

2023-01-24 Thread github-actions
github-actions[bot] commented on PR #16138: URL: https://github.com/apache/doris/pull/16138#issuecomment-1403075686 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16111: [fix](multi catalog)Support parquet and orc upper case column name.

2023-01-24 Thread github-actions
github-actions[bot] commented on PR #16111: URL: https://github.com/apache/doris/pull/16111#issuecomment-1403033290 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] ByteYue opened a new issue, #16139: [Bug] vertical compaction segment writer's rows count is not consistent

2023-01-24 Thread via GitHub
ByteYue opened a new issue, #16139: URL: https://github.com/apache/doris/issues/16139 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version commit id: d062ca2944763

[GitHub] [doris] hello-stephen commented on pull request #16138: [refactor](remove non vec code) remove non vec functions and AggregateInfo

2023-01-24 Thread via GitHub
hello-stephen commented on PR #16138: URL: https://github.com/apache/doris/pull/16138#issuecomment-1402184200 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.2 seconds load time: 491 seconds storage size: 17121772789 Bytes https://doris-com

[doris] branch master updated: [doc](cold hot separation)cold hot separation document adjustment (#15811)

2023-01-24 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new aa87e31b6f [doc](cold hot separation)cold hot se

[GitHub] [doris] jackwener merged pull request #15811: [doc](cold hot separation)cold hot separation document adjustment

2023-01-24 Thread via GitHub
jackwener merged PR #15811: URL: https://github.com/apache/doris/pull/15811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] morningman commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc

2023-01-24 Thread via GitHub
morningman commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1402115367 Is there a way to keep http port unchanged but using brpc implemented http server? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [doris] github-actions[bot] commented on pull request #16138: [refactor](remove non vec code) remove non vec functions and AggregateInfo

2023-01-24 Thread github-actions
github-actions[bot] commented on PR #16138: URL: https://github.com/apache/doris/pull/16138#issuecomment-1402114529 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yiguolei opened a new pull request, #16138: [refactor](remove non vec code) remove non vec functions and AggregateInfo

2023-01-24 Thread via GitHub
yiguolei opened a new pull request, #16138: URL: https://github.com/apache/doris/pull/16138 # Proposed changes remove these functions: CastFunctions EncryptionFunctions TimestampFunctions UtilityFunctions BitmapFunctions QuantileStateFunctions

[GitHub] [doris] morningman commented on a diff in pull request #16111: [fix](multi catalog)Support parquet and orc upper case column name.

2023-01-24 Thread via GitHub
morningman commented on code in PR #16111: URL: https://github.com/apache/doris/pull/16111#discussion_r1085449722 ## be/src/vec/exec/format/orc/vorc_reader.cpp: ## @@ -780,7 +791,9 @@ Status OrcReader::get_next_block(Block* block, size_t* read_rows, bool* eof) { }

[GitHub] [doris] yiguolei merged pull request #16137: [refactor](remove unused code) remove storage buffer and orc reader

2023-01-24 Thread via GitHub
yiguolei merged PR #16137: URL: https://github.com/apache/doris/pull/16137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #16137: [refactor](remove unused code) remove storage buffer and orc reader

2023-01-24 Thread github-actions
github-actions[bot] commented on PR #16137: URL: https://github.com/apache/doris/pull/16137#issuecomment-1402021738 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16137: [refactor](remove unused code) remove storage buffer and orc reader

2023-01-24 Thread github-actions
github-actions[bot] commented on PR #16137: URL: https://github.com/apache/doris/pull/16137#issuecomment-1402021651 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[doris] branch branch-1.2-lts updated: [fix](icebergv2) fix icebergv2 delete file open bug and column case insensitive (#16135)

2023-01-24 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new 5c5030b6dd [fix](icebergv2) f

[GitHub] [doris] morningman merged pull request #16135: [fix](icebergv2) fix icebergv2 delete file open bug and column case insensitive

2023-01-24 Thread via GitHub
morningman merged PR #16135: URL: https://github.com/apache/doris/pull/16135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] github-actions[bot] commented on pull request #16137: [refactor](remove unused code) remove storage buffer and orc reader

2023-01-24 Thread github-actions
github-actions[bot] commented on PR #16137: URL: https://github.com/apache/doris/pull/16137#issuecomment-1401798070 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-24 Thread via GitHub
amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1085068246 ## be/src/vec/functions/array/function_array_element.h: ## @@ -81,6 +94,79 @@ class FunctionArrayElement : public IFunction { } private: +//===

[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-24 Thread via GitHub
amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1085058385 ## be/src/vec/functions/array/function_array_element.h: ## @@ -81,6 +94,79 @@ class FunctionArrayElement : public IFunction { } private: +//===

[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-24 Thread via GitHub
amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1084974457 ## fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java: ## @@ -0,0 +1,179 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-24 Thread via GitHub
amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1084963919 ## fe/fe-core/src/main/java/org/apache/doris/catalog/MapType.java: ## @@ -98,4 +134,16 @@ public void toThrift(TTypeDesc container) { keyType.toThrift(contain

[GitHub] [doris] amorynan commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-24 Thread via GitHub
amorynan commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1084955323 ## fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java: ## @@ -185,6 +185,9 @@ public void finalize(Analyzer analyzer) throws UserException {