morningman commented on code in PR #16111: URL: https://github.com/apache/doris/pull/16111#discussion_r1085449722
########## be/src/vec/exec/format/orc/vorc_reader.cpp: ########## @@ -780,7 +791,9 @@ Status OrcReader::get_next_block(Block* block, size_t* read_rows, bool* eof) { } } const auto& batch_vec = down_cast<orc::StructVectorBatch*>(_batch.get())->fields; - for (auto& col : _read_cols) { + for (auto& origin_col : _read_cols) { + std::string col = origin_col; + transform(col.begin(), col.end(), col.begin(), ::tolower); Review Comment: save `lower case _read_cols` so that we don't need to transform it for each block -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org