[GitHub] [doris] github-actions[bot] commented on pull request #15549: [chore](Sink)remove useless OlapTablePartitionParam-related code

github-actions[bot] commented on PR #15549: URL: https://github.com/apache/doris/pull/15549#issuecomment-1368705321 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15549: [chore](Sink)remove useless OlapTablePartitionParam-related code

github-actions[bot] commented on code in PR #15549: URL: https://github.com/apache/doris/pull/15549#discussion_r1059859759 ## be/src/vec/sink/vtablet_sink.h: ## @@ -535,7 +535,6 @@ class VOlapTableSink final : public DataSink { enum FindTabletMode { FIND_TABLET_EVERY_ROW, F

[GitHub] [doris] ByteYue opened a new pull request, #15549: [chore](Sink)remove useless OlapTablePartitionParam-related code

ByteYue opened a new pull request, #15549: URL: https://github.com/apache/doris/pull/15549 # Proposed changes Issue Number: close #xxx Previously we use `OlapTablePartitionParam` to store tables information of one table but actually no one uses it any more. It is useless now since

[GitHub] [doris] englefly commented on a diff in pull request #15240: [fix](nereids) binding priority in agg-sort, having, group_by_key

englefly commented on code in PR #15240: URL: https://github.com/apache/doris/pull/15240#discussion_r1059846750 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java: ## @@ -194,11 +195,55 @@ public List buildRules() {

[GitHub] [doris] XieJiann commented on a diff in pull request #15479: [fix](Nereids): generate colocate join when property is different with require property

XieJiann commented on code in PR #15479: URL: https://github.com/apache/doris/pull/15479#discussion_r1059810215 ## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/mv/SelectMvIndexTest.java: ## @@ -760,7 +760,7 @@ public void testBitmapUnionInSubquery() throws Exception {

[GitHub] [doris] XieJiann commented on a diff in pull request #15479: [fix](Nereids): generate colocate join when property is different with require property

XieJiann commented on code in PR #15479: URL: https://github.com/apache/doris/pull/15479#discussion_r1059810215 ## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/mv/SelectMvIndexTest.java: ## @@ -760,7 +760,7 @@ public void testBitmapUnionInSubquery() throws Exception {

[GitHub] [doris] hello-stephen commented on pull request #15548: [DRAFT](Nereids) test fix binary arithmetic

hello-stephen commented on PR #15548: URL: https://github.com/apache/doris/pull/15548#issuecomment-1368502697 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 37.12 seconds load time: 652 seconds storage size: 17123361153 Bytes https://doris-co

[GitHub] [doris] morrySnow commented on a diff in pull request #15479: [fix](Nereids): generate colocate join when property is different with require property

morrySnow commented on code in PR #15479: URL: https://github.com/apache/doris/pull/15479#discussion_r1059781227 ## fe/fe-core/src/main/java/org/apache/doris/nereids/properties/DistributionSpecHash.java: ## @@ -174,7 +182,13 @@ public boolean satisfy(DistributionSpec required) {

[GitHub] [doris] morrySnow opened a new pull request, #15548: [DRAFT](Nereids) test fix binary arithmetic

morrySnow opened a new pull request, #15548: URL: https://github.com/apache/doris/pull/15548 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] morrySnow commented on a diff in pull request #15240: [fix](nereids) binding priority in agg-sort, having, group_by_key

morrySnow commented on code in PR #15240: URL: https://github.com/apache/doris/pull/15240#discussion_r1059777460 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/CheckAfterRewrite.java: ## @@ -45,11 +48,31 @@ public class CheckAfterRewrite extends OneAnalysis

[GitHub] [doris] hello-stephen commented on pull request #15547: [Fix](Nereids)fix aggregation result error when child is empty relation

hello-stephen commented on PR #15547: URL: https://github.com/apache/doris/pull/15547#issuecomment-1368464807 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.49 seconds load time: 656 seconds storage size: 17123551530 Bytes https://doris-co

[GitHub] [doris] starocean999 opened a new pull request, #15547: [Fix](Nereids)fix aggregation result error when child is empty relation

starocean999 opened a new pull request, #15547: URL: https://github.com/apache/doris/pull/15547 # Proposed changes this pr is follow up of https://github.com/apache/doris/pull/14964 ## Problem summary consider the query bellow: _SELECT * FROM subquery1 WHERE subquery

[GitHub] [doris] hello-stephen commented on pull request #15339: [Feature](aggregate-function) support funtion group_uniq_array

hello-stephen commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1368432413 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35 seconds load time: 639 seconds storage size: 17123141162 Bytes https://doris-commu

[GitHub] [doris] github-actions[bot] commented on pull request #15509: [feature](partition)add default list partition

github-actions[bot] commented on PR #15509: URL: https://github.com/apache/doris/pull/15509#issuecomment-1368432036 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [Feature](aggregate-function) support funtion group_uniq_array

github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1368429604 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [Feature](aggregate-function) support funtion group_uniq_array

github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1368422308 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15509: [feature](partition)add default list partition

github-actions[bot] commented on PR #15509: URL: https://github.com/apache/doris/pull/15509#issuecomment-1368411812 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL