[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15549: [chore](Sink)remove useless OlapTablePartitionParam-related code

[GitBox]

github-actions[bot] commented on code in PR #15549:
URL: https://github.com/apache/doris/pull/15549#discussion_r1059859759


##########
be/src/vec/sink/vtablet_sink.h:
##########
@@ -535,7 +535,6 @@ class VOlapTableSink final : public DataSink {
     enum FindTabletMode { FIND_TABLET_EVERY_ROW, FIND_TABLET_EVERY_BATCH, 
FIND_TABLET_EVERY_SINK };
     FindTabletMode findTabletMode = FindTabletMode::FIND_TABLET_EVERY_ROW;
 
-    OlapTablePartitionParam* _partition = nullptr;
     std::vector<ExprContext*> _output_expr_ctxs;

Review Comment:
   warning: use of undeclared identifier 'ExprContext' [clang-diagnostic-error]
   ```cpp
       std::vector<ExprContext*> _output_expr_ctxs;
                   ^
   ```
   



##########
be/src/vec/sink/vtablet_sink.h:
##########
@@ -535,7 +535,6 @@
     enum FindTabletMode { FIND_TABLET_EVERY_ROW, FIND_TABLET_EVERY_BATCH, 
FIND_TABLET_EVERY_SINK };
     FindTabletMode findTabletMode = FindTabletMode::FIND_TABLET_EVERY_ROW;
 
-    OlapTablePartitionParam* _partition = nullptr;
     std::vector<ExprContext*> _output_expr_ctxs;

Review Comment:
   warning: private field '_output_expr_ctxs' is not used 
[clang-diagnostic-unused-private-field]
   ```cpp
       std::vector<ExprContext*> _output_expr_ctxs;
                                 ^
   ```
   



##########
be/src/vec/sink/vtablet_sink.h:
##########
@@ -535,7 +535,6 @@
     enum FindTabletMode { FIND_TABLET_EVERY_ROW, FIND_TABLET_EVERY_BATCH, 
FIND_TABLET_EVERY_SINK };
     FindTabletMode findTabletMode = FindTabletMode::FIND_TABLET_EVERY_ROW;
 
-    OlapTablePartitionParam* _partition = nullptr;
     std::vector<ExprContext*> _output_expr_ctxs;

Review Comment:
   warning: expected expression [clang-diagnostic-error]
   ```cpp
       std::vector<ExprContext*> _output_expr_ctxs;
                               ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org