kangkaisen commented on pull request #4168:
URL: https://github.com/apache/incubator-doris/pull/4168#issuecomment-663796296
Please add a UT to cover this bug.
This is an automated message from the Apache Git Service.
To respo
This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a change to branch imay-patch-1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 9108a99 Let linked-schema change work for BETA tablet
add ed44a50 Update comment
No new revisio
kangkaisen commented on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-663794124
@yangzhg @morningman Hi, The sql_parser.cup file seems has conflict issue
frequently. could we put a readme file or some useful link under
`fe/fe-core/src/main/cup/`
kangkaisen closed issue #4169:
URL: https://github.com/apache/incubator-doris/issues/4169
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kangkaisen merged pull request #4170:
URL: https://github.com/apache/incubator-doris/pull/4170
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from b32500b [Script] Restore build parallel config (#4166)
add 4d828d2 Fix recover database not in "s
kangkaisen commented on pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182#issuecomment-663793293
We should cover the schema_version_convert in UT, which is error-prone.
This is an automated message
kangkaisen commented on a change in pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182#discussion_r460350162
##
File path: be/src/olap/schema_change.cpp
##
@@ -2141,7 +2141,7 @@ OLAPStatus
SchemaChangeHandler::_parse_request(TabletSharedPtr base_table
kangkaisen commented on issue #4162:
URL:
https://github.com/apache/incubator-doris/issues/4162#issuecomment-663791493
> @kangkaisen close? why?
Sorry，which should be a misoperation.
This is an automated message from
kangkaisen commented on pull request #4131:
URL: https://github.com/apache/incubator-doris/pull/4131#issuecomment-663791316
> > @caiconghui Hi，how many performance improvement this PR will get?
> > @kangkaisen
> > for single AtomicLong value and single LongAdder value, i test increment
yangzhg opened a new pull request #4183:
URL: https://github.com/apache/incubator-doris/pull/4183
## Proposed changes
from/to_base64 may return incorrect value when the value is null #4130
remove the duplicated base64 code
fix the base64 encoded string length is wrong， and this
morningman commented on a change in pull request #4163:
URL: https://github.com/apache/incubator-doris/pull/4163#discussion_r460096973
##
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/SparkResource.java
##
@@ -144,6 +146,12 @@ public SparkResource getCopiedResour
imay opened a new pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a commit to branch imay-patch-1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 9108a999a045c00133a2361165db6dbe15719348
Author: Zhao Chun
AuthorDate: Fri Jul 24 23:33:17 2020 +0800
This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a change to branch imay-patch-1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
at 9108a99 Let linked-schema change work for BETA tablet
This branch includes the following new commits:
imay opened a new issue #4181:
URL: https://github.com/apache/incubator-doris/issues/4181
If a tablet rowset type is BETA, Linked Schema change will not be triggered.
This is because, when the code see the new tablet's perfer rowset type is
BETA, it will choose a directly way to do schem
amosbird opened a new pull request #4180:
URL: https://github.com/apache/incubator-doris/pull/4180
## Proposed changes
In ClickHouse we have glibc symbols masked to backport down towards CentOS 5
(glibc 2.5). It's quite useful for creating portable executables. I'd love to
have this
xy720 commented on a change in pull request #4163:
URL: https://github.com/apache/incubator-doris/pull/4163#discussion_r460087064
##
File path:
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkRepository.java
##
@@ -0,0 +1,379 @@
+// Licensed to the Apache Software F
xy720 commented on a change in pull request #4163:
URL: https://github.com/apache/incubator-doris/pull/4163#discussion_r460087064
##
File path:
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkRepository.java
##
@@ -0,0 +1,379 @@
+// Licensed to the Apache Software F
xy720 commented on a change in pull request #4163:
URL: https://github.com/apache/incubator-doris/pull/4163#discussion_r460084182
##
File path:
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkEtlJobHandler.java
##
@@ -114,7 +142,9 @@ public void submitEtlJob(long lo
xy720 commented on a change in pull request #4163:
URL: https://github.com/apache/incubator-doris/pull/4163#discussion_r460083484
##
File path: fe/fe-core/src/main/java/org/apache/doris/common/FeConstants.java
##
@@ -39,6 +39,9 @@
// dpp version
public static String d
morningman commented on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-663557077
If we resolve the reduce conflict, I suggest to modify the
`expectedConflicts` in `fe/fe-core/pom.xml` too.
-
caiconghui commented on a change in pull request #4175:
URL: https://github.com/apache/incubator-doris/pull/4175#discussion_r460065609
##
File path:
fe/fe-core/src/main/java/org/apache/doris/transaction/UpdateDbUsedDataQuotaDaemon.java
##
@@ -44,6 +44,10 @@ private void update
morningman merged pull request #4166:
URL: https://github.com/apache/incubator-doris/pull/4166
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 4608f97 Support checking database used data quota when data load job
begin a new txn (#3955)
add
morningman commented on a change in pull request #4175:
URL: https://github.com/apache/incubator-doris/pull/4175#discussion_r460052620
##
File path:
fe/fe-core/src/main/java/org/apache/doris/transaction/UpdateDbUsedDataQuotaDaemon.java
##
@@ -44,6 +44,10 @@ private void update
caiconghui opened a new issue #4179:
URL: https://github.com/apache/incubator-doris/issues/4179
**Describe the bug**
This Bug was introduced by PR #4053, here should add db read lock when
processing unfinished publish task.
**To Reproduce**
--
caiconghui opened a new pull request #4178:
URL: https://github.com/apache/incubator-doris/pull/4178
## Proposed changes
This Bug was introduced by PR #4053, here should add db read lock when
processing unfinished publish task.
## Types of changes
What types of changes
morningman commented on pull request #4053:
URL: https://github.com/apache/incubator-doris/pull/4053#issuecomment-663523056
Hi @caiconghui , I think you forget to hold the database's readlock?
This is an automated message fro
yangzhg commented on issue #4130:
URL:
https://github.com/apache/incubator-doris/issues/4130#issuecomment-663502497
It is a bug,and I will fix it, to_base64 function also has this problem, and
to_base64 also has an bug may cause memory problem
yangzhg commented on issue #4155:
URL:
https://github.com/apache/incubator-doris/issues/4155#issuecomment-663464893
For now we not support down cast, you can refer
`org/apache/doris/catalog/ColumnType.java` for more detail
HappenLee commented on a change in pull request #4165:
URL: https://github.com/apache/incubator-doris/pull/4165#discussion_r459948700
##
File path: be/src/exec/blocking_join_node.cpp
##
@@ -74,14 +76,23 @@ Status BlockingJoinNode::prepare(RuntimeState* state) {
_probe_tupl
yangzhg opened a new pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177
## Proposed changes
Fix the Shift/Reduce conflict in cup file #4176
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes
HappenLee commented on a change in pull request #4165:
URL: https://github.com/apache/incubator-doris/pull/4165#discussion_r459944251
##
File path: be/src/exec/blocking_join_node.h
##
@@ -84,11 +88,20 @@ class BlockingJoinNode : public ExecNode {
// This should be the same
yangzhg opened a new issue #4176:
URL: https://github.com/apache/incubator-doris/issues/4176
For now our grammar file `fe/fe-core/src/main/cup/sql_parser.cup` has many
reduce conflicts, we should remove those conflicts
```
[WARNING]
/home/disk6/yang/workspace/baidu/bdg/doris/core/fe
caiconghui opened a new pull request #4175:
URL: https://github.com/apache/incubator-doris/pull/4175
## Proposed changes
This PR is to skip update data used quota for information_schema db and fix
bug for wrong time interval for UpdateDbUsedDataQuotaDaemon
## Types of changes
caiconghui opened a new issue #4174:
URL: https://github.com/apache/incubator-doris/issues/4174
**Describe the bug**
UpdateDbUsedDataQuotaDaemon has wrong time interval and not skip
information_schema db
**To Reproduce**
start fe, then see the following log :
```
2020-07-
hexian55 commented on issue #4162:
URL:
https://github.com/apache/incubator-doris/issues/4162#issuecomment-663388256
@kangkaisen close? why?
This is an automated message from the Apache Git Service.
To respond to the message
38 matches
Mail list logo
