[GitHub] [incubator-doris] HappenLee commented on a change in pull request #4165: [Spill To Disk][3/6] Add some function and variables in base class:BlockingJoinNode. Prepare for Derived class:PartitionHashJoinNode

[GitBox]

HappenLee commented on a change in pull request #4165:
URL: https://github.com/apache/incubator-doris/pull/4165#discussion_r459944251



##########
File path: be/src/exec/blocking_join_node.h
##########
@@ -84,11 +88,20 @@ class BlockingJoinNode : public ExecNode {
     // This should be the same size as the left child tuple row.
     int _result_tuple_row_size;
 
+    /// Row assembled from all lhs and rhs tuples used for evaluating the 
non-equi-join
+    /// conjuncts for semi joins. Semi joins only return the lhs or rhs output 
tuples,
+    /// so this tuple is temporarily assembled for evaluating the conjuncts.
+    TupleRow* _semi_join_staging_row;

Review comment:
       No，This comment is not very accurate. I will revise this part.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org