[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4152: [Spill To Disk][2/6] Add some runningtime function and change some function will be called in the future

2020-07-22 Thread GitBox
wutiangan commented on a change in pull request #4152: URL: https://github.com/apache/incubator-doris/pull/4152#discussion_r459245087 ## File path: be/src/runtime/bufferpool/suballocator.h ## @@ -128,6 +129,10 @@ class Suballocator { // if list is empty. std::unique_ptr P

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4152: [Spill To Disk][2/6] Add some runningtime function and change some function will be called in the future

2020-07-22 Thread GitBox
wutiangan commented on a change in pull request #4152: URL: https://github.com/apache/incubator-doris/pull/4152#discussion_r459243245 ## File path: be/src/runtime/bufferpool/suballocator.cc ## @@ -219,6 +230,10 @@ unique_ptr Suballocator::PopFreeListHead(int list_idx) { ret

[GitHub] [incubator-doris] xieyiyi opened a new pull request #4156: '[[' syntax works in bash, but is undefined in the default shell. '[[: not found' exception will raise in some cases.

2020-07-22 Thread GitBox
xieyiyi opened a new pull request #4156: URL: https://github.com/apache/incubator-doris/pull/4156 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature reque

[GitHub] [incubator-doris] yangjun616 opened a new issue #4155: Schema Change : errCode = 2, detailMessage = Can not change INT to TINYINT

2020-07-22 Thread GitBox
yangjun616 opened a new issue #4155: URL: https://github.com/apache/incubator-doris/issues/4155 here is a table `CREATE TABLE `table_v2` ( `date_partition` date NULL COMMENT "xxx", `date_time` datetime NULL COMMENT "xx", `is_some` int(11) NULL COMMENT "", `uuid` hl

[GitHub] [incubator-doris] morningman opened a new pull request #4154: [Code Structure] Move the code file to the right place

2020-07-22 Thread GitBox
morningman opened a new pull request #4154: URL: https://github.com/apache/incubator-doris/pull/4154 ## Proposed changes `IsNullPredicateTest.java` is not is right place ## Types of changes - [x] Code Refactor ---

[GitHub] [incubator-doris] wangbo commented on a change in pull request #4109: [Spark Load] add job granularity global dict lock

2020-07-22 Thread GitBox
wangbo commented on a change in pull request #4109: URL: https://github.com/apache/incubator-doris/pull/4109#discussion_r459228336 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java ## @@ -742,6 +760,26 @@ private void unprotectedLogUpdateStateInfo()

[GitHub] [incubator-doris] lovecatchuan opened a new issue #4153: Be error "Check failure stack trace"

2020-07-22 Thread GitBox
lovecatchuan opened a new issue #4153: URL: https://github.com/apache/incubator-doris/issues/4153 config: `# Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional informat

[GitHub] [incubator-doris] xy720 commented on a change in pull request #4146: [CodeRefactor] Modify FE modules

2020-07-22 Thread GitBox
xy720 commented on a change in pull request #4146: URL: https://github.com/apache/incubator-doris/pull/4146#discussion_r459217047 ## File path: build.sh ## @@ -176,34 +184,55 @@ cd ${DORIS_HOME}/docs ./build_help_zip.sh cd ${DORIS_HOME} +# Assesmble FE modules +FE_MODULES=

[GitHub] [incubator-doris] HappenLee opened a new pull request #4152: [Spill To Disk][2/6] Add some runningtime function and change some function will be called in the future

2020-07-22 Thread GitBox
HappenLee opened a new pull request #4152: URL: https://github.com/apache/incubator-doris/pull/4152 issue:#3926 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or

[GitHub] [incubator-doris] HappenLee opened a new pull request #4151: [Spill To Disk][1/6] The adjustment of the basic BufferedBlockMgr includes the following change

2020-07-22 Thread GitBox
HappenLee opened a new pull request #4151: URL: https://github.com/apache/incubator-doris/pull/4151 1. Add Exec msg for BufferedBlockMgr for debug tuning 2. Change the API of Consume Memory? We will use it in HashTable in the future 3. Fix mistake of count _unfullfille

[GitHub] [incubator-doris] morningman commented on a change in pull request #4150: [BUG] fix 4149, add sessionVariable to choose broadcastjoin first when cardinality cannot be estimated

2020-07-22 Thread GitBox
morningman commented on a change in pull request #4150: URL: https://github.com/apache/incubator-doris/pull/4150#discussion_r459195573 ## File path: docs/zh-CN/administrator-guide/variables.md ## @@ -338,3 +338,6 @@ SET forward_to_master = concat('tr', 'u', 'e'); 是否将 bit

[GitHub] [incubator-doris] zhangchangwei commented on issue #4113: 源码编译报错

2020-07-22 Thread GitBox
zhangchangwei commented on issue #4113: URL: https://github.com/apache/incubator-doris/issues/4113#issuecomment-662797890 thks,i have tried,it's ok 联系人:张长伟 公司:国网汇通金财(北京)信息科技有限公司 公司地址:北京西城区广安门内大街311号祥龙商务大厦一座 联系邮箱:zhangchang...@sgec.sgcc.com.cn > 在 2020年7月23日,10:14,fran

[GitHub] [incubator-doris] wutiangan opened a new pull request #4150: [BUG] fix 4149, add sessionVariable to choose broadcastjoin first when cardinality cannot be estimated

2020-07-22 Thread GitBox
wutiangan opened a new pull request #4150: URL: https://github.com/apache/incubator-doris/pull/4150 fix #4149 add sessionVariable "prefer_broadcast_join" to choose broadcastjoin first when cardinality cannot be estimated the sessionVariable can set local or global. the default val

[GitHub] [incubator-doris] vagetablechicken commented on pull request #4135: [MemTracker] make all MemTrackers shared

2020-07-22 Thread GitBox
vagetablechicken commented on pull request #4135: URL: https://github.com/apache/incubator-doris/pull/4135#issuecomment-662791622 > The lifecycle of MemTracker for a query is clear。Now RunningProfile don't use shared ptr, also can show running statistics of query. So it 's really necessary

[GitHub] [incubator-doris] chaoyli commented on issue #4120: [Enhancement] Add HTTP RestFul interface to get QueryPlan by QueryID

2020-07-22 Thread GitBox
chaoyli commented on issue #4120: URL: https://github.com/apache/incubator-doris/issues/4120#issuecomment-662790290 > @chaoyli can you have tools to analysis QueryPlan to find why SLOW-QUERY? QueryPlan is before query execution. Slow Query can be defined after execution. If you w

[incubator-doris] branch master updated: [Bug] Compaction row number cannot be matched between input rowsets and output rowsets. (#4139)

2020-07-22 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 75ebe2b [Bug] Compaction row numbe

[GitHub] [incubator-doris] chaoyli merged pull request #4139: [Bug] Compaction row number cannot be matched between input rowsets and output rowsets

2020-07-22 Thread GitBox
chaoyli merged pull request #4139: URL: https://github.com/apache/incubator-doris/pull/4139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-doris] chaoyli closed issue #4129: Compaction error

2020-07-22 Thread GitBox
chaoyli closed issue #4129: URL: https://github.com/apache/incubator-doris/issues/4129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] wutiangan opened a new issue #4149: choose broadcastjoin first when cardinality cannot be estimated

2020-07-22 Thread GitBox
wutiangan opened a new issue #4149: URL: https://github.com/apache/incubator-doris/issues/4149 sql: `select * from (select k1 from jointest group by k1)t2, jointest t1 where t1.k1 = t2.k1` reason: In version 0.11, the SQL choose broadcastjoin and returns it in 9s. However, in

[GitHub] [incubator-doris] WingsGo commented on pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-22 Thread GitBox
WingsGo commented on pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#issuecomment-662787157 > > > Hi @WingsGo Could you please add a document for this new feature? > > > I suggest `docs/zh-CN/administrator-guide/ui/be-ui.md` > > > > > > OK, I will a

[GitHub] [incubator-doris] francisoliverlee commented on issue #4113: 源码编译报错

2020-07-22 Thread GitBox
francisoliverlee commented on issue #4113: URL: https://github.com/apache/incubator-doris/issues/4113#issuecomment-662786957 @zhangchangwei try compile use docker, so easy. [how-to-build-doris-on-docker](http://doris.incubator.apache.org/master/zh-CN/installing/compilation.html) -

[GitHub] [incubator-doris] francisoliverlee commented on issue #4120: [Enhancement] Add HTTP RestFul interface to get QueryPlan by QueryID

2020-07-22 Thread GitBox
francisoliverlee commented on issue #4120: URL: https://github.com/apache/incubator-doris/issues/4120#issuecomment-662785764 @chaoyli can you have tools to analysis QueryPlan to find why SLOW-QUERY? This is an automated mess

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4143: Fix alter schema add key column bug in agg model

2020-07-22 Thread GitBox
yangzhg commented on a change in pull request #4143: URL: https://github.com/apache/incubator-doris/pull/4143#discussion_r459178509 ## File path: be/src/olap/schema_change.cpp ## @@ -2111,6 +2111,11 @@ OLAPStatus SchemaChangeHandler::_parse_request(TabletSharedPtr base_tablet,

[GitHub] [incubator-doris] francisoliverlee commented on issue #4147: [Bug] Lots of version incomplete replica created when decommission BE

2020-07-22 Thread GitBox
francisoliverlee commented on issue #4147: URL: https://github.com/apache/incubator-doris/issues/4147#issuecomment-662782872 @morningman what's the doris version in the issue, and how do you do to make the need-relocated-tablets relocate to D, not other BEs? as what i know, relocate

[GitHub] [incubator-doris] morningman commented on pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-22 Thread GitBox
morningman commented on pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#issuecomment-662544850 > > Hi @WingsGo Could you please add a document for this new feature? > > I suggest `docs/zh-CN/administrator-guide/ui/be-ui.md` > > OK, I will add it later.

[GitHub] [incubator-doris] morningman commented on pull request #4095: show lost tabletIds which do not have any available replica

2020-07-22 Thread GitBox
morningman commented on pull request #4095: URL: https://github.com/apache/incubator-doris/pull/4095#issuecomment-662544302 HI @spaces-X the FE code structure has been change, please rebase the code the solve the conflicts.

[GitHub] [incubator-doris] morningman commented on pull request #4086: [Feature][Meta]Update/Read/Write VisibleVersionTime for Partition#4076

2020-07-22 Thread GitBox
morningman commented on pull request #4086: URL: https://github.com/apache/incubator-doris/pull/4086#issuecomment-662543101 Hi @marising the FE code structure has been changed, please rebase the code the solve the conflicts.

[GitHub] [incubator-doris] morningman commented on pull request #4089: Fix some problem related with publish version task

2020-07-22 Thread GitBox
morningman commented on pull request #4089: URL: https://github.com/apache/incubator-doris/pull/4089#issuecomment-662539886 Hi @caiconghui , the FE code structure has been changed, please rebase the code to solve the conflicts --

[GitHub] [incubator-doris] morningman opened a new pull request #4148: [Bug][TabletRepair] Fix bug that too many replicas generated when decommission BE

2020-07-22 Thread GitBox
morningman opened a new pull request #4148: URL: https://github.com/apache/incubator-doris/pull/4148 ## Proposed changes Try to select the BE with an existing replicas as the destination BE for REPLICA_RELOCATING clone task. Fix #4147 Also add 2 new FE configs `max_clone

[GitHub] [incubator-doris] morningman opened a new issue #4147: [Bug] Lots of version incomplete replica created when decommission BE

2020-07-22 Thread GitBox
morningman opened a new issue #4147: URL: https://github.com/apache/incubator-doris/issues/4147 **Describe the bug** When decommission BE, some of tablets may has lots of replicas generated by clone task. **Why** Give examples of why: 1. Tablet X has 3 replicas on A,

[GitHub] [incubator-doris] HappenLee commented on pull request #4135: [MemTracker] make all MemTrackers shared

2020-07-22 Thread GitBox
HappenLee commented on pull request #4135: URL: https://github.com/apache/incubator-doris/pull/4135#issuecomment-662519072 > > Hello, I have two questions to ask。 > > > > 1. shared ptr use for avoid memory leaks. but at the same time, it brings about several problems: > >(1)Th

[GitHub] [incubator-doris] liutang123 closed issue #4104: No available BE to choose when repair

2020-07-22 Thread GitBox
liutang123 closed issue #4104: URL: https://github.com/apache/incubator-doris/issues/4104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated: [TabletRepair] Delete bad replicas when no BE can be used to create new replica

2020-07-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new e4f5a29 [TabletRepair] Delete bad

[GitHub] [incubator-doris] morningman merged pull request #4105: Delete bad replicas when no BE can be used to create new replica. for…

2020-07-22 Thread GitBox
morningman merged pull request #4105: URL: https://github.com/apache/incubator-doris/pull/4105 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman closed issue #4122: [BUG] Boolean support not incomplete

2020-07-22 Thread GitBox
morningman closed issue #4122: URL: https://github.com/apache/incubator-doris/issues/4122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] morningman merged pull request #4123: fix boolean support

2020-07-22 Thread GitBox
morningman merged pull request #4123: URL: https://github.com/apache/incubator-doris/pull/4123 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman merged pull request #4128: Add compaction point changing log

2020-07-22 Thread GitBox
morningman merged pull request #4128: URL: https://github.com/apache/incubator-doris/pull/4128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: [Bug][Alter] Fix boolean support (#4123)

2020-07-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 31a6c43 [Bug][Alter] Fix boolean s

[incubator-doris] branch master updated (5c4bba1 -> cc7f04d)

2020-07-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 5c4bba1 [Bug] Fix isnull(null) analyze error (#4094) add cc7f04d [Log] Add compaction point log r

[GitHub] [incubator-doris] morningman opened a new pull request #4146: [CodeRefactor] Modify FE modules

2020-07-22 Thread GitBox
morningman opened a new pull request #4146: URL: https://github.com/apache/incubator-doris/pull/4146 ## Proposed changes This CL mainly changes: 1. Add 2 new FE modules 1. fe-common save all common classes for other modules, currently only `jmockit`

[GitHub] [incubator-doris] spaces-X commented on pull request #4000: applyInnerJoinConditionReorganizeRule

2020-07-22 Thread GitBox
spaces-X commented on pull request #4000: URL: https://github.com/apache/incubator-doris/pull/4000#issuecomment-662476149 @morningman @wutiangan Fix the NullPointerException of the variable `father` in this [PR ](https://github.com/apache/incubator-doris/pull/4145) ---

[GitHub] [incubator-doris] spaces-X opened a new pull request #4145: Adjust join conditions after reorder table.

2020-07-22 Thread GitBox
spaces-X opened a new pull request #4145: URL: https://github.com/apache/incubator-doris/pull/4145 Finish this pr [applyInnerJoinConditionReorganizeRule #4000](https://github.com/apache/incubator-doris/pull/4000) This is an

[GitHub] [incubator-doris] vagetablechicken edited a comment on pull request #4135: [MemTracker] make all MemTrackers shared

2020-07-22 Thread GitBox
vagetablechicken edited a comment on pull request #4135: URL: https://github.com/apache/incubator-doris/pull/4135#issuecomment-662452697 > So the mainly reason use `shared_prt ` is only to show MemTracker on website? Yes. We had met a lot of problems of memory, they usually are accom

[GitHub] [incubator-doris] vagetablechicken commented on pull request #4135: [MemTracker] make all MemTrackers shared

2020-07-22 Thread GitBox
vagetablechicken commented on pull request #4135: URL: https://github.com/apache/incubator-doris/pull/4135#issuecomment-662452697 > So the mainly reason use `shared_prt ` is only to show MemTracker on website? Yes. We had met a lot of problems of memory, they usually are accompanied wit

[GitHub] [incubator-doris] kangkaisen commented on pull request #4135: [MemTracker] make all MemTrackers shared

2020-07-22 Thread GitBox
kangkaisen commented on pull request #4135: URL: https://github.com/apache/incubator-doris/pull/4135#issuecomment-662418107 > > Hello, I have two questions to ask。 > > > > 1. shared ptr use for avoid memory leaks. but at the same time, it brings about several problems: > >(1)T

[GitHub] [incubator-doris] kangkaisen closed issue #4093: [BUG] Analyze isnull(null) function fail

2020-07-22 Thread GitBox
kangkaisen closed issue #4093: URL: https://github.com/apache/incubator-doris/issues/4093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] kangkaisen merged pull request #4094: [Bug] Fix isnull(null) analyze error

2020-07-22 Thread GitBox
kangkaisen merged pull request #4094: URL: https://github.com/apache/incubator-doris/pull/4094 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: [Bug] Fix isnull(null) analyze error (#4094)

2020-07-22 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 5c4bba1 [Bug] Fix isnull(null) ana

[GitHub] [incubator-doris] gcnote opened a new issue #4144: decimal value can not be loaded to doris from hdfs orc file

2020-07-22 Thread GitBox
gcnote opened a new issue #4144: URL: https://github.com/apache/incubator-doris/issues/4144 decimal column value like -0.03 in orc hive file after use broker load to doris , -0.03 will become Null, how to fix it? This is

[GitHub] [incubator-doris] ZhangYu0123 opened a new pull request #4143: Fix alter schema add key column bug in agg model

2020-07-22 Thread GitBox
ZhangYu0123 opened a new pull request #4143: URL: https://github.com/apache/incubator-doris/pull/4143 ## Proposed changes Fix the bug "alter schema add key column bug in agg model when using LinkedSchemaChange policy", the detail description #4142. The change is when add key column

[GitHub] [incubator-doris] ZhangYu0123 opened a new issue #4142: Alter table add key column fails in agg module using LinkedSchemaChange policy

2020-07-22 Thread GitBox
ZhangYu0123 opened a new issue #4142: URL: https://github.com/apache/incubator-doris/issues/4142 **Describe the bug** A clear and concise description of what the bug is. When alter table add key column in agg module using LinkedSchemaChange policy, "ALTER, status_code: RUNTIME_ERROR"

[GitHub] [incubator-doris] yangzhg opened a new pull request #4141: Support batch delete syntax in fe and add pass the delete infomation to be

2020-07-22 Thread GitBox
yangzhg opened a new pull request #4141: URL: https://github.com/apache/incubator-doris/pull/4141 ## Proposed changes Part of Issues #4051 Add batch delete synatx support, support the syntax described in Issues #4051 Bring the delete infomation to be ## Types of change

[GitHub] [incubator-doris] yangzhg edited a comment on issue #4051: [Proposal] Doris supports batch delete

2020-07-22 Thread GitBox
yangzhg edited a comment on issue #4051: URL: https://github.com/apache/incubator-doris/issues/4051#issuecomment-657427484 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] vagetablechicken edited a comment on pull request #4135: [MemTracker] make all MemTrackers shared

2020-07-22 Thread GitBox
vagetablechicken edited a comment on pull request #4135: URL: https://github.com/apache/incubator-doris/pull/4135#issuecomment-662351521 > Hello, I have two questions to ask。 > > 1. shared ptr use for avoid memory leaks. but at the same time, it brings about several problems: >

[GitHub] [incubator-doris] vagetablechicken commented on pull request #4135: [MemTracker] make all MemTrackers shared

2020-07-22 Thread GitBox
vagetablechicken commented on pull request #4135: URL: https://github.com/apache/incubator-doris/pull/4135#issuecomment-662351521 > Hello, I have two questions to ask。 > > 1. shared ptr use for avoid memory leaks. but at the same time, it brings about several problems: >(1)The

[GitHub] [incubator-doris] HappenLee commented on pull request #4135: [MemTracker] make all MemTrackers shared

2020-07-22 Thread GitBox
HappenLee commented on pull request #4135: URL: https://github.com/apache/incubator-doris/pull/4135#issuecomment-662322631 Hello, I have two questions to ask。 1. shared ptr use for avoid memory leaks. but at the same time, it brings about several problems: (1)There are additional co

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #4140: Add materialized view related syntax

2020-07-22 Thread GitBox
HangyuanLiu opened a new pull request #4140: URL: https://github.com/apache/incubator-doris/pull/4140 ## Proposed changes 1、Add restrict when create materialized which partition by key mush be in group by 2、Add show alter table materialized view syntax 3、Add cancel alter mater

[GitHub] [incubator-doris] chaoyli opened a new pull request #4139: [Bug] Compaction row number cannot be matched between input rowsets and output rowsets

2020-07-22 Thread GitBox
chaoyli opened a new pull request #4139: URL: https://github.com/apache/incubator-doris/pull/4139 Unique Key table will load duplicate rows for different loads. If exists duplicate row between loads. Compaction will merge this rows. The statistics should take this merged number into co

[GitHub] [incubator-doris] chaoyli commented on pull request #4139: [Bug] Compaction row number cannot be matched between input rowsets and output rowsets

2020-07-22 Thread GitBox
chaoyli commented on pull request #4139: URL: https://github.com/apache/incubator-doris/pull/4139#issuecomment-662306667 #4129 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] HappenLee opened a new pull request #4138: [Bug] [Spill To Disk] Fix Mem exceed bug in Sort Node when use multi spill operator

2020-07-22 Thread GitBox
HappenLee opened a new pull request #4138: URL: https://github.com/apache/incubator-doris/pull/4138 1.Release the rowbatch mem, before sort node check memtracker 2.Change BufferedBlockMgr buffer check in spill sort to fix muli-operator try to use Block Buffer。use``available_buffe