yangzhg commented on a change in pull request #4143:
URL: https://github.com/apache/incubator-doris/pull/4143#discussion_r459178509
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -2111,6 +2111,11 @@ OLAPStatus
SchemaChangeHandler::_parse_request(TabletSharedPtr base_tablet,
for (size_t i = 0; i < new_tablet->num_columns(); ++i) {
ColumnMapping* column_mapping =
rb_changer->get_mutable_column_mapping(i);
if (column_mapping->ref_column < 0) {
+ // check agg model, add key-column operation use sc_directly to
build index
+ if (new_tablet_schema.keys_type() == AGG_KEYS &&
new_tablet_schema.column(i).is_key()) {
+ *sc_directly = true;
+ return OLAP_SUCCESS;
+ }
Review comment:
this will disable all linked schema in when add key column in agg table,
try some better way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
