[GitHub] [incubator-doris] morningman commented on issue #3935: [Proposal]Unify all frontend config behavior

2020-06-23 Thread GitBox
morningman commented on issue #3935: URL: https://github.com/apache/incubator-doris/issues/3935#issuecomment-648612449 that would be good This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-doris] WingsGo opened a new issue #3935: [Proposal]Unify all frontend config behavior

2020-06-23 Thread GitBox
WingsGo opened a new issue #3935: URL: https://github.com/apache/incubator-doris/issues/3935 **Is your feature request related to a problem? Please describe.** Currently in FE, we have different config, some of them are master only, so we need to directly connect the master FE to change

[GitHub] [incubator-doris] morningman merged pull request #3927: Add spark etl job main class

2020-06-23 Thread GitBox
morningman merged pull request #3927: URL: https://github.com/apache/incubator-doris/pull/3927 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: [Spark Load]Add spark etl job main class (#3927)

2020-06-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 3f7307d [Spark Load]Add spark etl

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3806: Remove order by for subquery in set opertion clause

2020-06-23 Thread GitBox
wutiangan commented on a change in pull request #3806: URL: https://github.com/apache/incubator-doris/pull/3806#discussion_r444647788 ## File path: fe/src/main/java/org/apache/doris/analysis/QueryStmt.java ## @@ -285,27 +285,25 @@ protected void createSortInfo(Analyzer analyzer

[GitHub] [incubator-doris] morningman commented on a change in pull request #3933: [Bug] Fix bug that a query plan is not correctly cancelled

2020-06-23 Thread GitBox
morningman commented on a change in pull request #3933: URL: https://github.com/apache/incubator-doris/pull/3933#discussion_r444632682 ## File path: be/src/runtime/plan_fragment_executor.cpp ## @@ -487,21 +487,22 @@ Status PlanFragmentExecutor::get_next_internal(RowBatch** bat

[GitHub] [incubator-doris] vagetablechicken commented on issue #3929: [Bug] BE crash occasionally

2020-06-23 Thread GitBox
vagetablechicken commented on issue #3929: URL: https://github.com/apache/incubator-doris/issues/3929#issuecomment-648565350 The binary use `/home/palo/thirdparty/src/incubator-brpc-0.9.5/src/bthread/mutex.cpp:809`, may be closely related to this coredump? --

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3806: Add a session variable allow remove order by for subquery in set opertion clause

2020-06-23 Thread GitBox
wutiangan commented on a change in pull request #3806: URL: https://github.com/apache/incubator-doris/pull/3806#discussion_r444626175 ## File path: docs/en/administrator-guide/variables.md ## @@ -334,3 +334,7 @@ SET forward_to_master = concat('tr', 'u', 'e'); * `rewrite_count_

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3806: Add a session variable allow remove order by for subquery in set opertion clause

2020-06-23 Thread GitBox
wutiangan commented on a change in pull request #3806: URL: https://github.com/apache/incubator-doris/pull/3806#discussion_r444617441 ## File path: docs/zh-CN/administrator-guide/variables.md ## @@ -334,3 +334,6 @@ SET forward_to_master = concat('tr', 'u', 'e'); 是否将 bitm

[GitHub] [incubator-doris] vagetablechicken removed a comment on issue #3929: [Bug] BE crash occasionally

2020-06-23 Thread GitBox
vagetablechicken removed a comment on issue #3929: URL: https://github.com/apache/incubator-doris/issues/3929#issuecomment-648548777 Maybe the `_scan_batches_lock` is far away from `_scan_batch_added_cv`? https://github.com/apache/incubator-doris/blob/b8ee84a120813181733c6ac8cd5b9fd3c9b

[GitHub] [incubator-doris] vagetablechicken commented on issue #3929: [Bug] BE crash occasionally

2020-06-23 Thread GitBox
vagetablechicken commented on issue #3929: URL: https://github.com/apache/incubator-doris/issues/3929#issuecomment-648548777 Maybe the `_scan_batches_lock` is far away from `_scan_batch_added_cv`? https://github.com/apache/incubator-doris/blob/b8ee84a120813181733c6ac8cd5b9fd3c9b2f674/be

[GitHub] [incubator-doris] yangzhg edited a comment on pull request #3898: Support import true or false as boolean value

2020-06-23 Thread GitBox
yangzhg edited a comment on pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#issuecomment-648547789 > @yangzhg Hi, I think the result of processing bool value for stream load and insert stmt should keep consistent. > For now, like insert into xx values(1), res

[GitHub] [incubator-doris] yangzhg commented on pull request #3898: Support import true or false as boolean value

2020-06-23 Thread GitBox
yangzhg commented on pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#issuecomment-648547789 > @yangzhg Hi, I think the result of processing bool value for stream load and insert stmt should keep consistent. > For now, like insert into xx values(1), result=tru

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3806: Add a session variable allow remove order by for subquery in set opertion clause

2020-06-23 Thread GitBox
wuyunfeng commented on a change in pull request #3806: URL: https://github.com/apache/incubator-doris/pull/3806#discussion_r444612890 ## File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java ## @@ -251,6 +253,9 @@ private int maxScanKeyNum = -1; @Variab

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3928: [Bug Fix]Fix the core in Data_Stream_Recvr

2020-06-23 Thread GitBox
HappenLee commented on a change in pull request #3928: URL: https://github.com/apache/incubator-doris/pull/3928#discussion_r444612282 ## File path: be/src/runtime/data_stream_recvr.cc ## @@ -176,14 +176,12 @@ Status DataStreamRecvr::SenderQueue::get_batch(RowBatch** next_batch

[GitHub] [incubator-doris] acelyc111 commented on pull request #3925: [log] Downgrade a log in RunLengthByteReader from WARNING to INFO

2020-06-23 Thread GitBox
acelyc111 commented on pull request #3925: URL: https://github.com/apache/incubator-doris/pull/3925#issuecomment-648545288 > > If its, how about move it to VLOG? > > @chaoyli Any idea? > > I agree it, downgrade to INFO will still have much of log. > You can use vlog(10) to repla

[GitHub] [incubator-doris] wangbo closed issue #3061: [Spark Load] Doris Support Using Hive Table to Build Global Dict

2020-06-23 Thread GitBox
wangbo closed issue #3061: URL: https://github.com/apache/incubator-doris/issues/3061 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[incubator-doris] branch master updated (feec4ee -> 93a0b47)

2020-06-23 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from feec4ee [UDF] Support external users to contribute udf (#3760) add 93a0b47 Revert "[Memory Engine

[incubator-doris] branch master updated (feec4ee -> 93a0b47)

2020-06-23 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from feec4ee [UDF] Support external users to contribute udf (#3760) add 93a0b47 Revert "[Memory Engine

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3933: [Bug] Fix bug that a query plan is not correctly cancelled

2020-06-23 Thread GitBox
chaoyli commented on a change in pull request #3933: URL: https://github.com/apache/incubator-doris/pull/3933#discussion_r444607501 ## File path: be/src/runtime/plan_fragment_executor.cpp ## @@ -487,21 +487,22 @@ Status PlanFragmentExecutor::get_next_internal(RowBatch** batch)

[GitHub] [incubator-doris] chaoyli merged pull request #3931: Revert "[Memory Engine] MemTablet creation and compatibility handling in BE"

2020-06-23 Thread GitBox
chaoyli merged pull request #3931: URL: https://github.com/apache/incubator-doris/pull/3931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-doris] chaoyli edited a comment on pull request #3898: Support import true or false as boolean value

2020-06-23 Thread GitBox
chaoyli edited a comment on pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#issuecomment-648537122 I think the meaning of caiconghui is to make consistent of stream load and insert in any situation. Otherwise, it will cause some misunderstanding. @yangzhg

[GitHub] [incubator-doris] chaoyli commented on pull request #3898: Support import true or false as boolean value

2020-06-23 Thread GitBox
chaoyli commented on pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898#issuecomment-648537122 I think the meaning of caiconghui is to make consistent of stream load and insert in any situation. Otherwise, it will cause some misunderstanding. -

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3928: [Bug Fix]Fix the core in Data_Stream_Recvr

2020-06-23 Thread GitBox
chaoyli commented on a change in pull request #3928: URL: https://github.com/apache/incubator-doris/pull/3928#discussion_r444601467 ## File path: be/src/runtime/data_stream_recvr.cc ## @@ -176,14 +176,12 @@ Status DataStreamRecvr::SenderQueue::get_batch(RowBatch** next_batch)

[GitHub] [incubator-doris] chaoyli commented on pull request #3925: [log] Downgrade a log in RunLengthByteReader from WARNING to INFO

2020-06-23 Thread GitBox
chaoyli commented on pull request #3925: URL: https://github.com/apache/incubator-doris/pull/3925#issuecomment-648534277 > If its, how about move it to VLOG? > @chaoyli Any idea? I agree it, downgrade to INFO will still have much of log. You can use vlog(10) to replace it. ---

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3934: [Refactor] Replace some boost to std in OlapScanNode

2020-06-23 Thread GitBox
chaoyli commented on a change in pull request #3934: URL: https://github.com/apache/incubator-doris/pull/3934#discussion_r444598726 ## File path: be/src/exec/olap_scan_node.cpp ## @@ -186,9 +185,9 @@ Status OlapScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool*

[GitHub] [incubator-doris] morningman opened a new pull request #3934: [Refactor] Replace some boost to std in OlapScanNode

2020-06-23 Thread GitBox
morningman opened a new pull request #3934: URL: https://github.com/apache/incubator-doris/pull/3934 Replace some boost to std in OlapScanNode. This refactor seems solve the problem describe in #3929. Because I found that BE will crash to calling `boost::condition_variable.notify_

[GitHub] [incubator-doris] morningman opened a new pull request #3933: [Bug] Fix bug that a query plan is not correctly cancelled

2020-06-23 Thread GitBox
morningman opened a new pull request #3933: URL: https://github.com/apache/incubator-doris/pull/3933 This bug is introduced by #3872. It will cause some expected to be cancelled queries not being cancelled. This is an auto

[GitHub] [incubator-doris] morningman commented on pull request #3925: [log] Downgrade a log in RunLengthByteReader from WARNING to INFO

2020-06-23 Thread GitBox
morningman commented on pull request #3925: URL: https://github.com/apache/incubator-doris/pull/3925#issuecomment-648199723 If its, how about move it to VLOG? This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] morningman edited a comment on pull request #3925: [log] Downgrade a log in RunLengthByteReader from WARNING to INFO

2020-06-23 Thread GitBox
morningman edited a comment on pull request #3925: URL: https://github.com/apache/incubator-doris/pull/3925#issuecomment-648199723 If its, how about move it to VLOG? @chaoyli Any idea? This is an automated message from the

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3932: [Doris On ES][Optimization] Ignore _total node for efficiency

2020-06-23 Thread GitBox
wuyunfeng opened a new pull request #3932: URL: https://github.com/apache/incubator-doris/pull/3932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman commented on a change in pull request #3927: Add spark etl job main class

2020-06-23 Thread GitBox
morningman commented on a change in pull request #3927: URL: https://github.com/apache/incubator-doris/pull/3927#discussion_r444116102 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java ## @@ -17,6 +17,8 @@ package org.apache.doris.load.loadv2;

[GitHub] [incubator-doris] chaoyli opened a new pull request #3931: Revert "[Memory Engine] MemTablet creation and compatibility handling in BE"

2020-06-23 Thread GitBox
chaoyli opened a new pull request #3931: URL: https://github.com/apache/incubator-doris/pull/3931 Reverts apache/incubator-doris#3762 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-doris] branch revert-3762-tablet-manager2 created (now 71b207b)

2020-06-23 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch revert-3762-tablet-manager2 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. at 71b207b Revert "[Memory Engine] MemTablet creation and compatibility handling in

[incubator-doris] 01/01: Revert "[Memory Engine] MemTablet creation and compatibility handling in BE (#3762)"

2020-06-23 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch revert-3762-tablet-manager2 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 71b207b2d52524bbc0de2dfc9483eb25b748c85e Author: lichaoyong AuthorDate: Tue Jun 23 16:

[GitHub] [incubator-doris] Youngwb opened a new issue #3930: [Proposal] Doris support version column for REPLACE aggregate type

2020-06-23 Thread GitBox
Youngwb opened a new issue #3930: URL: https://github.com/apache/incubator-doris/issues/3930 ### BackGround Doris currently use REPLACE to update data, but the replacement order cannot be guaranteed for the data import of the same batch. The user needs to guarantee that there is no same

[GitHub] [incubator-doris] morningman opened a new issue #3929: [Bug] BE crash occasionally

2020-06-23 Thread GitBox
morningman opened a new issue #3929: URL: https://github.com/apache/incubator-doris/issues/3929 **Describe the bug** BE crash occasionally and `be.out` shows: ``` palo_be: ../nptl/pthread_mutex_lock.c:80: __pthread_mutex_lock: Assertion `mutex->__data.__owner == 0' failed. *