[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3806: Add a session variable allow remove order by for subquery in set opertion clause

[GitBox]

wuyunfeng commented on a change in pull request #3806:
URL: https://github.com/apache/incubator-doris/pull/3806#discussion_r444612890



##########
File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -251,6 +253,9 @@
     private int maxScanKeyNum = -1;
     @VariableMgr.VarAttr(name = MAX_PUSHDOWN_CONDITIONS_PER_COLUMN)
     private int maxPushdownConditionsPerColumn = -1;
+    // TODO(Yangzhengguo) set this default value to true if we support spill 
data top disk

Review comment:
       ```suggestion
       // TODO set this default value to true if we support spill data top disk
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org