[GitHub] [incubator-doris] vagetablechicken edited a comment on pull request #3899: [Bug] fix mem_tracker use-after-free & add UT for it

2020-06-17 Thread GitBox
vagetablechicken edited a comment on pull request #3899: URL: https://github.com/apache/incubator-doris/pull/3899#issuecomment-645732574 The detected error: ``` ==11791==ERROR: AddressSanitizer: heap-use-after-free on address 0x6140d4d0 at pc 0x0173f25c bp 0x7ffc769fb940 sp 0x

[GitHub] [incubator-doris] vagetablechicken edited a comment on pull request #3899: [Bug] fix mem_tracker use-after-free & add UT for it

2020-06-17 Thread GitBox
vagetablechicken edited a comment on pull request #3899: URL: https://github.com/apache/incubator-doris/pull/3899#issuecomment-645732574 The detected error: ``` ==11791==ERROR: AddressSanitizer: heap-use-after-free on address 0x6140d4d0 at pc 0x0173f25c bp 0x7ffc769fb940 sp 0x

[GitHub] [incubator-doris] wyb commented on a change in pull request #3716: [Spark load][Fe 5/6] Fe submit spark etl job

2020-06-17 Thread GitBox
wyb commented on a change in pull request #3716: URL: https://github.com/apache/incubator-doris/pull/3716#discussion_r441988995 ## File path: fe/src/main/java/org/apache/doris/common/Pair.java ## @@ -25,7 +27,9 @@ public class Pair { public static PairComparator> PAIR_VAL

[GitHub] [incubator-doris] wyb commented on a change in pull request #3716: [Spark load][Fe 5/6] Fe submit spark etl job

2020-06-17 Thread GitBox
wyb commented on a change in pull request #3716: URL: https://github.com/apache/incubator-doris/pull/3716#discussion_r441988075 ## File path: fe/src/main/java/org/apache/doris/common/util/BrokerUtil.java ## @@ -139,4 +148,352 @@ public static String printBroker(String brokerNam

[GitHub] [incubator-doris] wuyunfeng commented on issue #3559: [Doris on ES] unix_timestamp(date_format(now(), '%Y-%m-%d')) not push down

2020-06-17 Thread GitBox
wuyunfeng commented on issue #3559: URL: https://github.com/apache/incubator-doris/issues/3559#issuecomment-645798568 emm... This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman commented on a change in pull request #3822: Add segment v2 footer meta viewer

2020-06-17 Thread GitBox
morningman commented on a change in pull request #3822: URL: https://github.com/apache/incubator-doris/pull/3822#discussion_r441983032 ## File path: docs/en/administrator-guide/operation/tablet-meta-tool.md ## @@ -130,8 +130,18 @@ Batch delete will skip the line with incorrect

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3320: (#3319) support java version hyperloglog

2020-06-17 Thread GitBox
wangbo commented on a change in pull request #3320: URL: https://github.com/apache/incubator-doris/pull/3320#discussion_r441975600 ## File path: fe/src/test/java/org/apache/doris/load/loadv2/HllTest.java ## @@ -0,0 +1,268 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3900: [Doris On ES] Support fetch `_id` field from ES

2020-06-17 Thread GitBox
wuyunfeng commented on a change in pull request #3900: URL: https://github.com/apache/incubator-doris/pull/3900#discussion_r441961150 ## File path: fe/src/main/java/org/apache/doris/common/FeNameFormat.java ## @@ -26,6 +26,7 @@ public class FeNameFormat { private static f

[GitHub] [incubator-doris] wuyunfeng opened a new issue #3901: [Doris On ES] Support fetch `_id` field from ES

2020-06-17 Thread GitBox
wuyunfeng opened a new issue #3901: URL: https://github.com/apache/incubator-doris/issues/3901 **Is your feature request related to a problem? Please describe.** Some DOE(Doris On ES)'s user maybe want to obtain the native ES document `_id` which is primary-key for ES Index. They give _i

[GitHub] [incubator-doris] morningman commented on a change in pull request #3900: [Doris On ES] Support fetch `_id` field from ES

2020-06-17 Thread GitBox
morningman commented on a change in pull request #3900: URL: https://github.com/apache/incubator-doris/pull/3900#discussion_r441952620 ## File path: fe/src/main/java/org/apache/doris/common/FeNameFormat.java ## @@ -26,6 +26,7 @@ public class FeNameFormat { private static

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3900: [Doris On ES] Support fetch field from ES

2020-06-17 Thread GitBox
wuyunfeng opened a new pull request #3900: URL: https://github.com/apache/incubator-doris/pull/3900 The created ES external Table must contains `_id` column if you want to fetch the Elasticsearch document `_id`. ``` CREATE EXTERNAL TABLE `doe_id2` ( `_id` varchar COMMENT "",

[GitHub] [incubator-doris] vagetablechicken edited a comment on pull request #3899: [Bug] fix mem_tracker use-after-free & add UT for it

2020-06-17 Thread GitBox
vagetablechicken edited a comment on pull request #3899: URL: https://github.com/apache/incubator-doris/pull/3899#issuecomment-645732574 The detected error: ``` ==11791==ERROR: AddressSanitizer: heap-use-after-free on address 0x6140d4d0 at pc 0x0173f25c bp 0x7ffc769fb940 sp 0x

[GitHub] [incubator-doris] vagetablechicken commented on pull request #3899: [Bug] fix mem_tracker use-after-free & add UT for it

2020-06-17 Thread GitBox
vagetablechicken commented on pull request #3899: URL: https://github.com/apache/incubator-doris/pull/3899#issuecomment-645732574 The detected error: ``` ==11791==ERROR: AddressSanitizer: heap-use-after-free on address 0x6140d4d0 at pc 0x0173f25c bp 0x7ffc769fb940 sp 0x7ffc769

[incubator-doris] branch master updated: [Memory Engine] MemTablet creation and compatibility handling in BE (#3762)

2020-06-17 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ca96ea3 [Memory Engine] MemTablet

[GitHub] [incubator-doris] chaoyli merged pull request #3762: [Memory Engine] MemTablet creation and compatibility handling in BE

2020-06-17 Thread GitBox
chaoyli merged pull request #3762: URL: https://github.com/apache/incubator-doris/pull/3762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #3899: [Bug] fix mem_tracker use-after-free & add UT for it

2020-06-17 Thread GitBox
vagetablechicken opened a new pull request #3899: URL: https://github.com/apache/incubator-doris/pull/3899 If NodeChannel is internal cancelled, it may has some bytes in `_cur_batch` or `_pending_batches`. And it's possible that we close these `internal cancelled` NodeChannels by `mark_clo

[GitHub] [incubator-doris] chaoyli closed issue #3669: [Memory Engine] MemTablet creation and compatibility handling in BE

2020-06-17 Thread GitBox
chaoyli closed issue #3669: URL: https://github.com/apache/incubator-doris/issues/3669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] imay merged pull request #3896: Modify docs format

2020-06-17 Thread GitBox
imay merged pull request #3896: URL: https://github.com/apache/incubator-doris/pull/3896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] yangzhg opened a new pull request #3898: Support import true or false as boolean value

2020-06-17 Thread GitBox
yangzhg opened a new pull request #3898: URL: https://github.com/apache/incubator-doris/pull/3898 Fixes #3831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[incubator-doris] branch master updated: Modify docs format (#3896)

2020-06-17 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 2f99f63 Modify docs format (#3896) 2f99

[GitHub] [incubator-doris] spaces-X opened a new issue #3897: subquery can not reslove the grandpa column

2020-06-17 Thread GitBox
spaces-X opened a new issue #3897: URL: https://github.com/apache/incubator-doris/issues/3897 In Analyzer #registerColumnRef We got warning like this: ``` /* * Now, we only support the columns in the subquery to associate the outer query columns in parent level.

[GitHub] [incubator-doris] morningman commented on a change in pull request #3716: [Spark load][Fe 5/6] Fe submit spark etl job

2020-06-17 Thread GitBox
morningman commented on a change in pull request #3716: URL: https://github.com/apache/incubator-doris/pull/3716#discussion_r437874451 ## File path: fe/src/main/java/org/apache/doris/common/Pair.java ## @@ -25,7 +27,9 @@ public class Pair { public static PairComparator> P

[GitHub] [incubator-doris] morningman commented on a change in pull request #3320: (#3319) support java version hyperloglog

2020-06-17 Thread GitBox
morningman commented on a change in pull request #3320: URL: https://github.com/apache/incubator-doris/pull/3320#discussion_r441548250 ## File path: fe/src/test/java/org/apache/doris/load/loadv2/HllTest.java ## @@ -0,0 +1,268 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] WingsGo closed issue #3880: Show create table with bitmap should not return DEFAULT value

2020-06-17 Thread GitBox
WingsGo closed issue #3880: URL: https://github.com/apache/incubator-doris/issues/3880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] ZhangYu0123 opened a new pull request #3896: modify docs format

2020-06-17 Thread GitBox
ZhangYu0123 opened a new pull request #3896: URL: https://github.com/apache/incubator-doris/pull/3896 Modify docs format, docs '##keyword' is short of a space. This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] yangzhg opened a new issue #3895: `split_range` is not implemented in BetaRowset

2020-06-17 Thread GitBox
yangzhg opened a new issue #3895: URL: https://github.com/apache/incubator-doris/issues/3895 In `olap_scan_node.cpp` the num of scan thread is base on `split_ranges` and it is generated by function `split_range`. This function in `beta_rowset.cpp` is simply return the all data as a sing

[GitHub] [incubator-doris] morningman commented on issue #3859: [Proposal] Resolve error "fail to init reader.res=-230"

2020-06-17 Thread GitBox
morningman commented on issue #3859: URL: https://github.com/apache/incubator-doris/issues/3859#issuecomment-645301694 > +1. What's the progress of this work? I'd like to help if possible. Just started, one of our team is working this. We can make a discuss after investigation. --

[GitHub] [incubator-doris] gaodayue commented on issue #3859: [Proposal] Resolve error "fail to init reader.res=-230"

2020-06-17 Thread GitBox
gaodayue commented on issue #3859: URL: https://github.com/apache/incubator-doris/issues/3859#issuecomment-645299411 The problem could also occur when follower's metadata lags behind master by a substantial time. We encountered one case recently and I'd like to share the details. F

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs

2020-06-17 Thread GitBox
wutiangan commented on a change in pull request #3858: URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r441423822 ## File path: docs/zh-CN/administrator-guide/running-profile.md ## @@ -92,18 +92,23 @@ BE端收集的统计信息较多,下面列出了各个参数的对应含义: - AverageThreadTokens: 执

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3858: [Running_Profile] Fix all counter in DataStreamRecv and change the image path in docs

2020-06-17 Thread GitBox
wutiangan commented on a change in pull request #3858: URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r441388234 ## File path: docs/zh-CN/administrator-guide/running-profile.md ## @@ -92,18 +92,23 @@ BE端收集的统计信息较多,下面列出了各个参数的对应含义: - AverageThreadTokens: 执