vagetablechicken opened a new pull request #3899: URL: https://github.com/apache/incubator-doris/pull/3899
If NodeChannel is internal cancelled, it may has some bytes in `_cur_batch` or `_pending_batches`. And it's possible that we close these `internal cancelled` NodeChannels by `mark_close()` & `close()`, cuz the OlapTableSink may be succeed and closed with `Status::OK()`. 1. In `TEST_F(OlapTableSinkTest, add_batch_failed)`, make NodeChannels has `not empty` batches, to simulate this scenario. 1. UT test couldn't detect it in normal build type, cuz the memory block usually don't be modified after free. We can use ASAN to detect `use-after-free` errors. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
