HangyuanLiu commented on a change in pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739#discussion_r439240450
##
File path: be/src/olap/schema_change.cpp
##
@@ -194,6 +188,105 @@ ColumnMapping*
RowBlockChanger::get_mutable_column_mapping(size_t column
morningman opened a new pull request #3850:
URL: https://github.com/apache/incubator-doris/pull/3850
When starting FE with `start_fe.sh --helper xxx` command, do not allow to
point helper to FE itself. Because this is meaningless and may cause some
confusing problems.
---
HangyuanLiu commented on a change in pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739#discussion_r439233209
##
File path: be/src/olap/schema_change.cpp
##
@@ -194,6 +188,105 @@ ColumnMapping*
RowBlockChanger::get_mutable_column_mapping(size_t column
kangkaisen commented on a change in pull request #3820:
URL: https://github.com/apache/incubator-doris/pull/3820#discussion_r439204078
##
File path: be/src/exec/analytic_eval_node.cpp
##
@@ -195,9 +194,19 @@ Status AnalyticEvalNode::open(RuntimeState* state) {
RETURN_IF_CA
kangkaisen commented on a change in pull request #3820:
URL: https://github.com/apache/incubator-doris/pull/3820#discussion_r439203959
##
File path: be/src/exec/exchange_node.cpp
##
@@ -110,7 +110,7 @@ Status ExchangeNode::close(RuntimeState* state) {
if (_stream_recvr !=
kangkaisen commented on a change in pull request #3820:
URL: https://github.com/apache/incubator-doris/pull/3820#discussion_r439203710
##
File path: be/src/runtime/data_stream_recvr.cc
##
@@ -360,9 +360,14 @@ DataStreamRecvr::DataStreamRecvr(
_row_desc(row_desc),
kangkaisen commented on a change in pull request #3820:
URL: https://github.com/apache/incubator-doris/pull/3820#discussion_r439203257
##
File path: be/src/runtime/data_stream_recvr.cc
##
@@ -423,7 +428,7 @@ void DataStreamRecvr::close() {
_mgr = NULL;
_merger.reset()
kangkaisen commented on a change in pull request #3820:
URL: https://github.com/apache/incubator-doris/pull/3820#discussion_r439203095
##
File path: gensrc/thrift/PaloInternalService.thrift
##
@@ -136,6 +136,8 @@ struct TQueryOptions {
// see BE config `max_pushdown_conditio
hf200012 commented on issue #3849:
URL:
https://github.com/apache/incubator-doris/issues/3849#issuecomment-643047054
> That would be good!
> But Doris currently does not have a solid framework to address the name
case sensitivity issue.
> You can show us more details about your desig
hf200012 removed a comment on issue #3849:
URL:
https://github.com/apache/incubator-doris/issues/3849#issuecomment-643046975
Thank you very much for your dedication
I study the code and think about it
This is an automated
hf200012 commented on issue #3849:
URL:
https://github.com/apache/incubator-doris/issues/3849#issuecomment-643046975
Thank you very much for your dedication
I study the code and think about it
This is an automated message
morningman commented on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-643045680
> Oh, initially memory engine only supports uniq table(which should be
enough for typical use cases), and it can support (and probably unify) other
table types later.
morningman commented on issue #3849:
URL:
https://github.com/apache/incubator-doris/issues/3849#issuecomment-643043766
That would be good!
But Doris currently does not have a solid framework to address the name case
sensitivity issue.
You can show us more details about your design.
hf200012 opened a new issue #3849:
URL: https://github.com/apache/incubator-doris/issues/3849
I want to add a case-insensitive function for table names and fields
Improve development efficiency
This is an automated message
vagetablechicken opened a new pull request #3848:
URL: https://github.com/apache/incubator-doris/pull/3848
Ref https://github.com/apache/incubator-doris/issues/3821
This fix is based on UBSAN unit test. So if we create & use class obj in a
different way, may have `runtime error: load
decster commented on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-643033840
Oh, initially memory engine only supports uniq table(which should be enough
for typical use cases), and it can support (and probably unify) other table
types later.
--
decster commented on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-643032202
> Does the "memory engine table" has primary key columns?
Yes, to support update/delete every row should have a primary key. This is
equivalent to:
Agg table wi
vagetablechicken closed issue #3817:
URL: https://github.com/apache/incubator-doris/issues/3817
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
blackfox1983 commented on issue #3306:
URL:
https://github.com/apache/incubator-doris/issues/3306#issuecomment-643028949
- [ ] Support ES partition to meet the demand of auto-deleting some data out
of data in ES
This is an
HangyuanLiu commented on a change in pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739#discussion_r439170997
##
File path: gensrc/thrift/AgentService.thrift
##
@@ -104,6 +104,13 @@ struct TAlterTabletReqV2 {
// version of data which this alter ta
chaoyli commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r439169970
##
File path: be/src/service/http_service.cpp
##
@@ -91,7 +91,7 @@ Status HttpService::start() {
// register metrics
{
auto act
blackfox1983 opened a new issue #3847:
URL: https://github.com/apache/incubator-doris/issues/3847
**Is your feature request related to a problem? Please describe.**
The current version cannot support modifying the aggregation type of columns
from REPLACE to REPLACE_IF_NOT_NULL.
```
imay merged pull request #3838:
URL: https://github.com/apache/incubator-doris/pull/3838
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
imay merged pull request #3841:
URL: https://github.com/apache/incubator-doris/pull/3841
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a commit to branch branch-0.11
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/branch-0.11 by this push:
new acc6968 Stop travis building
This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 75f4df4 Stop travis building when an er
This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a commit to branch branch-0.12
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/branch-0.12 by this push:
new 1337f2f Stop travis building
imay merged pull request #3842:
URL: https://github.com/apache/incubator-doris/pull/3842
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
imay commented on a change in pull request #3846:
URL: https://github.com/apache/incubator-doris/pull/3846#discussion_r439156446
##
File path: be/src/exprs/json_functions.cpp
##
@@ -291,7 +291,7 @@ rapidjson::Value*
JsonFunctions::get_json_array_from_parsed_json (
}
sdgshawn opened a new pull request #3846:
URL: https://github.com/apache/incubator-doris/pull/3846
fix for be server crash which throwing syntax error when parse json from
kafka message
This is an automated message from the
acelyc111 commented on pull request #3814:
URL: https://github.com/apache/incubator-doris/pull/3814#issuecomment-642776083
> It's a good job. You can add related issue about it.
Added, https://github.com/apache/incubator-doris/issues/3845
acelyc111 opened a new issue #3845:
URL: https://github.com/apache/incubator-doris/issues/3845
**Is your feature request related to a problem? Please describe.**
Both base compaction and cumulative compaction may cost a long time, say
several seconds to several minutes. But I'm not clear
vagetablechicken commented on pull request #3844:
URL: https://github.com/apache/incubator-doris/pull/3844#issuecomment-642728852
> You can add some commit info to describe the solution.
Added.
This is an automated mes
vagetablechicken commented on pull request #3837:
URL: https://github.com/apache/incubator-doris/pull/3837#issuecomment-642725825
> hi @vagetablechicken . This PR #3799 is trying to replace the `Calender`
with `ZonedDateTime`.
> So I think some of your change overlap with his work.
>
morningman commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r438853945
##
File path: be/src/service/http_service.cpp
##
@@ -91,7 +91,7 @@ Status HttpService::start() {
// register metrics
{
auto
caiconghui commented on a change in pull request #3815:
URL: https://github.com/apache/incubator-doris/pull/3815#discussion_r438852344
##
File path: fe/src/main/java/org/apache/doris/catalog/TabletInvertedIndex.java
##
@@ -298,57 +262,28 @@ public Long getTabletIdByReplica(long
morningman commented on a change in pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739#discussion_r438823024
##
File path: be/src/olap/schema_change.cpp
##
@@ -194,6 +188,105 @@ ColumnMapping*
RowBlockChanger::get_mutable_column_mapping(size_t column_
wangbo edited a comment on issue #3061:
URL:
https://github.com/apache/incubator-doris/issues/3061#issuecomment-642688333
**Why gloal dict?**
We use ```roaringbitmap``` to compute distinct value.
But ```roaringbitmap``` 's input value can only be integer.
So We need
wangbo commented on issue #3061:
URL:
https://github.com/apache/incubator-doris/issues/3061#issuecomment-642688333
**Why gloal dict?**
We use ```roaringbitmap``` to compute distinct value.
But ```roaringbitmap``` 's input value can only be integer.
So We need a data
morningman commented on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-642678732
> key column should be unique right
I have a question that: What is "key column"? Is it a kind of primary key?
Or just a partition or distribution column?
Do
morningman commented on a change in pull request #3819:
URL: https://github.com/apache/incubator-doris/pull/3819#discussion_r438219946
##
File path: fe/src/main/cup/sql_parser.cup
##
@@ -1244,6 +1244,15 @@ data_desc ::=
RESULT = new DataDescription(tableName, partition
morningman commented on pull request #3837:
URL: https://github.com/apache/incubator-doris/pull/3837#issuecomment-642651610
hi @vagetablechicken . This PR #3799 is trying to replace the `Calender`
with `ZonedDateTime`.
So I think some of your change overlap with his work.
Could y
morningman commented on a change in pull request #3815:
URL: https://github.com/apache/incubator-doris/pull/3815#discussion_r438769259
##
File path: fe/src/main/java/org/apache/doris/catalog/TabletInvertedIndex.java
##
@@ -298,57 +262,28 @@ public Long getTabletIdByReplica(long
morningman commented on issue #3827:
URL:
https://github.com/apache/incubator-doris/issues/3827#issuecomment-642643745
> If you have add TCP error, you can also add more error as follow.
>
> ```
> atmptf/s
> estres/s
> retrans/s
> isegerr/s
> orsts/s
> ```
>
chaoyli edited a comment on issue #3827:
URL:
https://github.com/apache/incubator-doris/issues/3827#issuecomment-642637789
If you have add TCP error, you can also add more error as follow.
```
atmptf/s
estres/s
retrans/s
isegerr/s
orsts/s
```
You can get the manual
chaoyli commented on issue #3827:
URL:
https://github.com/apache/incubator-doris/issues/3827#issuecomment-642637789
If you have add TCP error, you can also add more error as follow.
```
atmptf/s
estres/s
retrans/s
isegerr/s
orsts/s
```
---
morningman commented on a change in pull request #3815:
URL: https://github.com/apache/incubator-doris/pull/3815#discussion_r438767143
##
File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java
##
@@ -388,21 +389,26 @@ private static void sync(Map
backendTablets
morningman commented on pull request #3825:
URL: https://github.com/apache/incubator-doris/pull/3825#issuecomment-642634900
Hi @stalary , thank u for your PR, but this bug has been fixed in #3826.
So I will close this PR.
morningman closed pull request #3825:
URL: https://github.com/apache/incubator-doris/pull/3825
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
chaoyli commented on pull request #3844:
URL: https://github.com/apache/incubator-doris/pull/3844#issuecomment-642625889
You can add some commit info to describe the solution.
This is an automated message from the Apache Git
gaodayue commented on a change in pull request #3830:
URL: https://github.com/apache/incubator-doris/pull/3830#discussion_r438752933
##
File path: be/src/exec/tablet_sink.cpp
##
@@ -785,9 +786,14 @@ int OlapTableSink::_validate_data(RuntimeState* state,
RowBatch* batch, Bitmap
chaoyli commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r438739390
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF)
chaoyli commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r438736209
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetail.java
##
@@ -0,0 +1,125 @@
+// Licensed to the Apache Software Foundation (ASF) unde
vagetablechicken opened a new pull request #3844:
URL: https://github.com/apache/incubator-doris/pull/3844
Ref https://github.com/apache/incubator-doris/issues/3843
This is an automated message from the Apache Git Service.
To
vagetablechicken opened a new issue #3843:
URL: https://github.com/apache/incubator-doris/issues/3843
**Describe the bug**
A clear and concise description of what the bug is.
https://github.com/apache/incubator-doris/blob/e16873a6c1bbf0cf9e97f7a7bfd60b162eea4e31/be/src/udf/udf.h#L634-
hffariel opened a new pull request #3842:
URL: https://github.com/apache/incubator-doris/pull/3842
stop travis building when an error occurred #3836
This is an automated message from the Apache Git Service.
To respond to the
hffariel opened a new pull request #3841:
URL: https://github.com/apache/incubator-doris/pull/3841
stop travis building when an error occurred #3836
This is an automated message from the Apache Git Service.
To respond to the
morningman commented on issue #3840:
URL:
https://github.com/apache/incubator-doris/issues/3840#issuecomment-642567680
Looks like some of Backends are crashed during load. You can do:
1. `show backends` and see the `LastStartTime` column, it means the recent
start time of a BE. Or see i
lmalds opened a new issue #3840:
URL: https://github.com/apache/incubator-doris/issues/3840
When I execute the statement of broker load, some JobId occured an error
"ErrorMsg: type:LOAD_RUN_FAIL; msg:there is no scanNode Backend", but others is
succeed. Details is attached.
What is reas
hffariel closed pull request #3839:
URL: https://github.com/apache/incubator-doris/pull/3839
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hffariel opened a new pull request #3839:
URL: https://github.com/apache/incubator-doris/pull/3839
stop travis building when an error occurred [branch-0.11]
This is an automated message from the Apache Git Service.
To respon
hffariel opened a new pull request #3838:
URL: https://github.com/apache/incubator-doris/pull/3838
stop travis building when an error occurred
This is an automated message from the Apache Git Service.
To respond to the messag
vagetablechicken opened a new pull request #3837:
URL: https://github.com/apache/incubator-doris/pull/3837
1. timezone, ref https://github.com/apache/incubator-doris/issues/3829
1. stream load log in FE has db & tbl info, broker load log should have too.
morningman commented on issue #3832:
URL:
https://github.com/apache/incubator-doris/issues/3832#issuecomment-642515292
> > I think this problem is fixed by this PR #3768
>
> It look great!!! Maybe I should look at the commit log first at next time.
By the way, I think we should add
WingsGo commented on issue #3832:
URL:
https://github.com/apache/incubator-doris/issues/3832#issuecomment-642513744
> I think this problem is fixed by this PR #3768
It look great!!! Maybe I should look at the commit log first at next time,
by the way, I think we should add more UT i
WingsGo edited a comment on issue #3832:
URL:
https://github.com/apache/incubator-doris/issues/3832#issuecomment-642513744
> I think this problem is fixed by this PR #3768
It look great!!! Maybe I should look at the commit log first at next time.
By the way, I think we should add mo
morningman commented on a change in pull request #3760:
URL: https://github.com/apache/incubator-doris/pull/3760#discussion_r438636930
##
File path: docs/zh-CN/extending-doris/user-defined-function.md
##
@@ -74,23 +93,150 @@ under the License.
|Varchar|StringVal|
|Decimal|Dec
morningman edited a comment on issue #3834:
URL:
https://github.com/apache/incubator-doris/issues/3834#issuecomment-642500180
Currently Doris does not support making database and table name case
insensitive.
And they are both case sensitive now.
The value of `lower_case_table_names`
morningman commented on issue #3834:
URL:
https://github.com/apache/incubator-doris/issues/3834#issuecomment-642500180
Currently Doris does not support making database and table name case
insensible.
The value of `lower_case_table_names` in `information_schema` is meaningless
for now.
morningman commented on issue #3832:
URL:
https://github.com/apache/incubator-doris/issues/3832#issuecomment-642498594
I think this problem is fixed by this PR #3768
This is an automated message from the Apache Git Service.
hffariel opened a new issue #3836:
URL: https://github.com/apache/incubator-doris/issues/3836
Document site got pushed into asf-site even if a error occurred during
travis building.
## Caused by
Commands in `after_script` section will always be executed even when the
build i
imay commented on a change in pull request #3830:
URL: https://github.com/apache/incubator-doris/pull/3830#discussion_r438625046
##
File path: be/src/exec/tablet_sink.cpp
##
@@ -785,9 +786,14 @@ int OlapTableSink::_validate_data(RuntimeState* state,
RowBatch* batch, Bitmap*
morningman opened a new pull request #3835:
URL: https://github.com/apache/incubator-doris/pull/3835
1. Add 2 new metrics of TCP in both FE and BE
```
snmp{name="tcp_retrans_segs"}
snmp{name="tcp_retrans_segs"}
```
2. Add metrics document
More metrics in document will
hf200012 opened a new issue #3834:
URL: https://github.com/apache/incubator-doris/issues/3834
information_schema表中lower_case_table_names=0，已经只不区分大小写了，但是实际使用了，这个不起作用，
怎么让表名和字段名称不区分大消息
This is an automated message from the A
hf200012 closed issue #3833:
URL: https://github.com/apache/incubator-doris/issues/3833
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hf200012 opened a new issue #3833:
URL: https://github.com/apache/incubator-doris/issues/3833
Are database table names strictly case sensitive?
I see lower_case_table_names=0 in information_schema, which means it is not
case sensitive
---
WingsGo opened a new issue #3832:
URL: https://github.com/apache/incubator-doris/issues/3832
**Describe the bug**
If we create a table with column type is bitmap and aggregate type is
replace.BE will core during load data.
```
Thu Jun 11 15:23:42 CST 2020: *** Aborted at 1591860222
yangzhg opened a new issue #3831:
URL: https://github.com/apache/incubator-doris/issues/3831
**Describe the bug**
When importing bool data into doris, the result of the import is wrong, all
will be converted to 1
**To Reproduce**
the table is
```
+---+-+-
78 matches
Mail list logo
