caiconghui commented on pull request #3815:
URL: https://github.com/apache/incubator-doris/pull/3815#issuecomment-641743439
for #3816
This is an automated message from the Apache Git Service.
To respond to the message, pleas
caiconghui opened a new issue #3816:
URL: https://github.com/apache/incubator-doris/issues/3816
I find when we get the tablet related meta from TabletInvertedIndex, we need
to get read lock so many times in TabletInvertedIndex, which may cause poor
performance when TabletInvertedIndex hold
caiconghui opened a new pull request #3815:
URL: https://github.com/apache/incubator-doris/pull/3815
This PR is to optimize the logic for getting tabletMeta from
TabletInvertIndex to reduce frequence of getting read lock
Th
vagetablechicken edited a comment on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-639358916
### Prepare Phase Detail Design
Sender BE:
```
Get batch from json_scanner
For partialrow in batch:
// If missing key cols, returns err
vagetablechicken edited a comment on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-639358916
### Prepare Phase Detail Design
Sender BE:
```
Get batch from json_scanner
For partialrow in batch:
// If missing key cols, returns err
vagetablechicken edited a comment on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-639358916
### Prepare Phase Detail Design
Sender BE:
```
Get batch from json_scanner
For partialrow in batch:
// If missing key cols, returns err
vagetablechicken edited a comment on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-639358916
### Prepare Phase Detail Design
Sender BE:
```
Get batch from json_scanner
For partialrow in batch:
// If missing key cols, returns err
wuyunfeng closed issue #3757:
URL: https://github.com/apache/incubator-doris/issues/3757
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
vagetablechicken commented on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-641707582
> > ```
> > // may missing key cols(partition cols or distributed cols), should
fillin default value.
> > // If we want to support default values for each writ
acelyc111 opened a new pull request #3814:
URL: https://github.com/apache/incubator-doris/pull/3814
Trace util is helpful for diagnosing compaction performance problems,
we can get trace log for base compaction like:
```
W0610 11:26:33.804431 56452 storage_engine.cpp:552] Trace:
EmmyMiao87 closed issue #3801:
URL: https://github.com/apache/incubator-doris/issues/3801
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
EmmyMiao87 merged pull request #3813:
URL: https://github.com/apache/incubator-doris/pull/3813
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
lingmiao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8c608bb [Doris On ES] Skip function_
kangpinghuang closed pull request #3296:
URL: https://github.com/apache/incubator-doris/pull/3296
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kangpinghuang closed pull request #2949:
URL: https://github.com/apache/incubator-doris/pull/2949
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kangpinghuang closed pull request #3013:
URL: https://github.com/apache/incubator-doris/pull/3013
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kangpinghuang closed pull request #2146:
URL: https://github.com/apache/incubator-doris/pull/2146
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kangpinghuang closed pull request #2939:
URL: https://github.com/apache/incubator-doris/pull/2939
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
EmmyMiao87 commented on pull request #3812:
URL: https://github.com/apache/incubator-doris/pull/3812#issuecomment-641681154
> Create table will forbidden float/double
Already forbidden
This is an automated message from
EmmyMiao87 commented on a change in pull request #3812:
URL: https://github.com/apache/incubator-doris/pull/3812#discussion_r437823982
##
File path:
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
##
@@ -255,10 +259,15 @@ private void analyzeOrderByC
blackfox1983 commented on a change in pull request #3813:
URL: https://github.com/apache/incubator-doris/pull/3813#discussion_r437821994
##
File path: be/src/exec/es/es_predicate.cpp
##
@@ -235,13 +243,16 @@ Status EsPredicate::build_disjuncts_list(const Expr*
conjunct) {
blackfox1983 commented on a change in pull request #3813:
URL: https://github.com/apache/incubator-doris/pull/3813#discussion_r437821664
##
File path: be/src/exec/es/es_predicate.cpp
##
@@ -49,6 +49,14 @@ namespace doris {
using namespace std;
+#define RETURN_ERROR_IF_EXPR
Fay0529 opened a new pull request #3807:
URL: https://github.com/apache/incubator-doris/pull/3807
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
blackfox1983 opened a new issue #3801:
URL: https://github.com/apache/incubator-doris/issues/3801
**Describe the bug**
There is a table:
```
MySQL [mydb]> desc mytable;
+-++--+---+-+---+
| Field | Type | Null | Key | De
morningman commented on pull request #3762:
URL: https://github.com/apache/incubator-doris/pull/3762#issuecomment-640690789
> > Hi @decster , in your comment, you said `When TabletManager::get_tablet
is called, only return Tablet, if the underlying tablet is MemTablet, return an
error, thi
wuyunfeng opened a new pull request #3813:
URL: https://github.com/apache/incubator-doris/pull/3813
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wfjcmcb opened a new issue #3809:
URL: https://github.com/apache/incubator-doris/issues/3809
This plugin is used to output data to Doris for logstash.
Use the HTTP protocol to interact with the Doris FE Http interface.
Load data through Doris's stream load.
--
kangkaisen commented on a change in pull request #3805:
URL: https://github.com/apache/incubator-doris/pull/3805#discussion_r437170215
##
File path: docs/zh-CN/administrator-guide/config/user_property.md
##
@@ -0,0 +1,69 @@
+---
+{
+"title": "User 配置项",
+"language": "zh
morningman commented on a change in pull request #3812:
URL: https://github.com/apache/incubator-doris/pull/3812#discussion_r437468475
##
File path:
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
##
@@ -235,6 +236,9 @@ private void analyzeOrderByCla
morningman opened a new pull request #3804:
URL: https://github.com/apache/incubator-doris/pull/3804
1. Missing field `partitionIndexMap` in SchemaChangeJobV2
2. Pair in field `indexSchemaVersionAndHashMap` can not be persisted by GSON
3. Exit the FE process when replay edit log error.
Fay0529 closed pull request #3807:
URL: https://github.com/apache/incubator-doris/pull/3807
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
morningman commented on issue #3811:
URL:
https://github.com/apache/incubator-doris/issues/3811#issuecomment-641333837
The reproduce should be
1. create table (k1 int, k2 float, k3 int) duplicate key(k1) in segment v2
format
2. create materialized view v1 as select k1,k2 from table.
HangyuanLiu closed pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
kangkaisen closed issue #3789:
URL: https://github.com/apache/incubator-doris/issues/3789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
morningman closed issue #3794:
URL: https://github.com/apache/incubator-doris/issues/3794
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yangzhg opened a new pull request #3806:
URL: https://github.com/apache/incubator-doris/pull/3806
implemnets #3803
Support remove some unmeaningful order by clause.
Because of we don't support memory spill, so add a session variable to
allow remove order by for subquery in set oper
chaoyli commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r437151250
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetail.java
##
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) unde
wanpengfei-git opened a new pull request #3810:
URL: https://github.com/apache/incubator-doris/pull/3810
add circleci config.yml
This is an automated message from the Apache Git Service.
To respond to the message, please log
morningman commented on a change in pull request #3805:
URL: https://github.com/apache/incubator-doris/pull/3805#discussion_r437243146
##
File path: docs/zh-CN/administrator-guide/config/user_property.md
##
@@ -0,0 +1,69 @@
+---
+{
+"title": "User 配置项",
Review comment:
morningman edited a comment on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-641071130
I thought we had discussed it. .
If this PR is merged, the current docker image needs to be upgraded,
otherwise the new code cannot be compiled. If you think
kangkaisen commented on issue #3590:
URL:
https://github.com/apache/incubator-doris/issues/3590#issuecomment-640552425
@WingsGo Yes, the strategy should be Pluggable. I think this issue is
like HBase (Tikv) region auto merge and split, Kylin(Druid) segment merge. If
we know the best s
WingsGo commented on a change in pull request #3799:
URL: https://github.com/apache/incubator-doris/pull/3799#discussion_r437503604
##
File path:
fe/src/main/java/org/apache/doris/common/util/DynamicPartitionUtil.java
##
@@ -148,11 +151,25 @@ private static void checkStartDayO
morningman commented on a change in pull request #3715:
URL: https://github.com/apache/incubator-doris/pull/3715#discussion_r436318081
##
File path: fe/src/main/cup/sql_parser.cup
##
@@ -1364,15 +1371,16 @@ opt_broker ::=
:}
;
-opt_cluster ::=
Review comment:
chaoyli commented on pull request #3812:
URL: https://github.com/apache/incubator-doris/pull/3812#issuecomment-641309914
Create table will forbidden float/double
This is an automated message from the Apache Git Service.
To re
morningman commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-641071130
I thought we had discussed it. .
If this PR is incorporated, the current docker image needs to be upgraded,
otherwise the new code cannot be compiled. If you think
EmmyMiao87 opened a new issue #3811:
URL: https://github.com/apache/incubator-doris/issues/3811
**Describe the bug**
If user create a table with the float column as the short key, the be will
core during query.
The core log is following:
```
#0 0x017cd4f5 in encode_
Fay0529 commented on pull request #3807:
URL: https://github.com/apache/incubator-doris/pull/3807#issuecomment-641107263
> Thank u~
> Could you please update the English doc too?
> `docs/en/sql-reference/sql-statements/Data Definition/ALTER TABLE.md`
DONE
-
morningman commented on a change in pull request #3796:
URL: https://github.com/apache/incubator-doris/pull/3796#discussion_r436777422
##
File path: docs/zh-CN/administrator-guide/load-data/routine-load-manual.md
##
@@ -266,6 +266,8 @@ FE 中的 JobScheduler 根据汇报结果，继续生成后续新的 Task，或
kangkaisen closed issue #3792:
URL: https://github.com/apache/incubator-doris/issues/3792
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
EmmyMiao87 opened a new pull request #3812:
URL: https://github.com/apache/incubator-doris/pull/3812
When the user does not specify the key column, doris will automatically
supplement the key column.
However, doris does not support float or double as the key column, so when
adding the k
morningman closed issue #3802:
URL: https://github.com/apache/incubator-doris/issues/3802
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wuyunfeng commented on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-641092988
@kangkaisen Yes, can you help me to merge this?
This is an automated message from the Apache Git Ser
morningman commented on pull request #3800:
URL: https://github.com/apache/incubator-doris/pull/3800#issuecomment-640690122
Good work!
Please add English doc ~
This is an automated message from the Apache Git Service.
morningman opened a new issue #3802:
URL: https://github.com/apache/incubator-doris/issues/3802
**Describe the bug**
1. Field `partitionIndexMap` in SchemaChangeJobV2 is not persisted.
2. Pair in `indexSchemaVersionAndHashMap` does not support GSON.
**To Reproduce**
1. create
kangkaisen merged pull request #3793:
URL: https://github.com/apache/incubator-doris/pull/3793
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
wangbo commented on pull request #3320:
URL: https://github.com/apache/incubator-doris/pull/3320#issuecomment-640994595
1 use little endian when serialize hll
2 add some ut which keep same logic which be hll ut and value check
@morningman plz review
-
morningman opened a new pull request #3808:
URL: https://github.com/apache/incubator-doris/pull/3808
ISSUE: #3365
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
decster commented on issue #3469:
URL:
https://github.com/apache/incubator-doris/issues/3469#issuecomment-641010153
> // may missing key cols(partition cols or distributed cols), should
fillin default value.
> // If we want to support default values for each write txn, those
de
kangkaisen merged pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman commented on a change in pull request #3799:
URL: https://github.com/apache/incubator-doris/pull/3799#discussion_r437463262
##
File path:
fe/src/main/java/org/apache/doris/catalog/DynamicPartitionProperty.java
##
@@ -46,15 +48,14 @@
private int buckets;
pr
EmmyMiao87 commented on pull request #3677:
URL: https://github.com/apache/incubator-doris/pull/3677#issuecomment-640551247
Is it possible to unify the columns of schema change and materialized view
into one logical process in insert stmt?
-
kangkaisen commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-641067971
> @morningman
> I don't understand you very well. I think we can make this feature in our
next release, so we can merge it right now. what's your opinion about this
morningman commented on pull request #3795:
URL: https://github.com/apache/incubator-doris/pull/3795#issuecomment-640554518
Still has problem...
This is an automated message from the Apache Git Service.
To respond to the mess
morningman merged pull request #3715:
URL: https://github.com/apache/incubator-doris/pull/3715
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
kangkaisen closed issue #3452:
URL: https://github.com/apache/incubator-doris/issues/3452
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
EmmyMiao87 opened a new pull request #3805:
URL: https://github.com/apache/incubator-doris/pull/3805
Update max_user_connections by user property
```
set property `user` max_user_connections=100;
```
Change-Id: Ia2a14b7472a1e3d2065bd73ec2b5f0c081bfa5d3
-
morningman merged pull request #3795:
URL: https://github.com/apache/incubator-doris/pull/3795
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
EmmyMiao87 commented on a change in pull request #3677:
URL: https://github.com/apache/incubator-doris/pull/3677#discussion_r436593235
##
File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java
##
@@ -453,6 +453,26 @@ private void analyzeSubquery(Analyzer analyzer
morningman commented on a change in pull request #3762:
URL: https://github.com/apache/incubator-doris/pull/3762#discussion_r436788740
##
File path: be/src/olap/tablet_manager.cpp
##
@@ -98,26 +99,34 @@ OLAPStatus TabletManager::_add_tablet_unlocked(TTabletId
tablet_id, Schema
wanpengfei-git closed pull request #3810:
URL: https://github.com/apache/incubator-doris/pull/3810
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wyb commented on a change in pull request #3715:
URL: https://github.com/apache/incubator-doris/pull/3715#discussion_r437217125
##
File path: fe/src/main/cup/sql_parser.cup
##
@@ -1364,15 +1371,16 @@ opt_broker ::=
:}
;
-opt_cluster ::=
Review comment:
hadoo
yangzhg opened a new issue #3803:
URL: https://github.com/apache/incubator-doris/issues/3803
In clause like
```
select a from t order by a union all select b from t
```
The ORDER BY clause in subquery `select a from t order by a` is unmeaningful
, so a query expression that
morningman edited a comment on pull request #3795:
URL: https://github.com/apache/incubator-doris/pull/3795#issuecomment-640554518
~~Still has problem...~~
This PR has no problem.
I will create another PR to fix another problem
morningman commented on a change in pull request #3800:
URL: https://github.com/apache/incubator-doris/pull/3800#discussion_r437229082
##
File path: docs/en/extending-doris/logstash.md
##
@@ -0,0 +1,198 @@
+---
Review comment:
You need to add this doc title in the side
kangkaisen commented on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-641006446
@wuyunfeng Hi，This PR is ready to merge?
This is an automated message from the Apache Git Service.
To
morningman merged pull request #3804:
URL: https://github.com/apache/incubator-doris/pull/3804
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 5b15894 [Bug] Fix SchemaChangeJobV2's meta persist bug (#3804)
add edfa668 Add create spark load
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 4fa9d8cbe983218312de30071b16bffd4768133f
Merge: 5b15894 7f6a7c6
Author: Mingyu Chen
AuthorDate: Tue Jun 9 2
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 5b15894 [Bug] Fix SchemaChangeJobV
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new acd7a58 [Doris On ES] [1/3] Add ES
80 matches
Mail list logo
