vagetablechicken commented on issue #3469: URL: https://github.com/apache/incubator-doris/issues/3469#issuecomment-641707582
> > ``` > > // may missing key cols(partition cols or distributed cols), should fillin default value. > > // If we want to support default values for each write txn, those default values need to > > ``` > > If it's key column, fillin default value doesn't make sense, key column should be unique right? > > About default value for non-key columns, it should be write to each Txn file, maybe in the footer PB? My bad, I mix key columns with value columns. The key columns should be checked in calc_partition_and_tablet(), and if any key column is missing, we should return error(abort sending). About default value for non-key columns, footer PB has `The schema part(ColumnMetaPB)`, so the default values for non-key columns are already in the file. I didn't point out it in Design, it'll be improved. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
