WingsGo commented on issue #3698:
URL:
https://github.com/apache/incubator-doris/issues/3698#issuecomment-634462835
> LGTM, maybe we can add a new column to show some info together in JSON
format.
> So that if we want to add more info later, there is no need to add more
columns in resu
morningman commented on issue #3682:
URL:
https://github.com/apache/incubator-doris/issues/3682#issuecomment-634462573
`手动抛出异常`是指什么?
This is an automated message from the Apache Git Service.
To respond to the message, please
morningman commented on issue #3689:
URL:
https://github.com/apache/incubator-doris/issues/3689#issuecomment-634461862
I probably understand what you mean, but I am not sure whether the specific
plan is feasible. In your proposal, only the query about latency is mentioned,
which can be kn
kangkaisen commented on a change in pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#discussion_r430887312
##
File path: be/src/exec/olap_scan_node.cpp
##
@@ -884,25 +910,54 @@ Status
OlapScanNode::normalize_in_predicate(SlotDescriptor* slot, Column
morningman commented on issue #3698:
URL:
https://github.com/apache/incubator-doris/issues/3698#issuecomment-634458410
LGTM, maybe we can add a new column to show some info together in JSON
format.
So that if we want to add more info later, there is no need to add more
columns in resul
morningman commented on issue #3696:
URL:
https://github.com/apache/incubator-doris/issues/3696#issuecomment-634457445
Looking forward to your PR
This is an automated message from the Apache Git Service.
To respond to the me
decster commented on a change in pull request #3637:
URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r430881935
##
File path: be/src/olap/memory/mem_sub_tablet.cpp
##
@@ -0,0 +1,247 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mor
WingsGo opened a new issue #3698:
URL: https://github.com/apache/incubator-doris/issues/3698
Recently, I found a cluster's BE's tablets is not balance, and the balance
error msg is `path hash is not set`, I finally found that some BE cannot report
it's tablets to BE because the report_all_
sceneryback opened a new issue #3697:
URL: https://github.com/apache/incubator-doris/issues/3697
version: apachedoris/doris-dev:build-env-1.2
Json format in kafka, not array:
```
{
"id": "xxx",
"a": {
"id": "xxx"
}
}
```
a.id is in format like '11:
morningman commented on a change in pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#discussion_r430842572
##
File path: be/src/exec/olap_scan_node.cpp
##
@@ -884,25 +910,54 @@ Status
OlapScanNode::normalize_in_predicate(SlotDescriptor* slot, Column
WingsGo commented on a change in pull request #3527:
URL: https://github.com/apache/incubator-doris/pull/3527#discussion_r430827305
##
File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java
##
@@ -263,15 +263,9 @@ public void vectorizedAnalyze(Analyzer analy
wutiangan commented on a change in pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#discussion_r430844878
##
File path: be/src/exec/olap_scan_node.cpp
##
@@ -736,100 +735,114 @@ static bool ignore_cast(SlotDescriptor* slot, Expr*
expr) {
return
caiconghui opened a new issue #3696:
URL: https://github.com/apache/incubator-doris/issues/3696
Now, there are many rpcs between be and fe, and some default config in be
may cause poor performance for query or stream load. In our experiment, we find
that when we execute stream load in dori
imay merged pull request #3683:
URL: https://github.com/apache/incubator-doris/pull/3683
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
chaoyli commented on issue #3689:
URL:
https://github.com/apache/incubator-doris/issues/3689#issuecomment-633853852
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chaoyli commented on a change in pull request #3635:
URL: https://github.com/apache/incubator-doris/pull/3635#discussion_r430137045
##
File path: fe/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
##
@@ -757,10 +759,15 @@ private boolean loadTxnCommitImpl(TLoadT
chaoyli merged pull request #3635:
URL: https://github.com/apache/incubator-doris/pull/3635
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
WingsGo commented on pull request #3679:
URL: https://github.com/apache/incubator-doris/pull/3679#issuecomment-633972342
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on
acelyc111 edited a comment on issue #3687:
URL:
https://github.com/apache/incubator-doris/issues/3687#issuecomment-633494076
https://github.com/apache/incubator-doris/blob/a5922051c9bee4d75599847838596abcd8b0bd3b/be/src/olap/tablet.cpp#L681-L702
I'm not sure what is the theoretical
stalary commented on a change in pull request #3454:
URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r430430020
##
File path: fe/src/main/java/org/apache/doris/external/EsStateStore.java
##
@@ -17,94 +17,95 @@
package org.apache.doris.external;
+import
morningman merged pull request #3418:
URL: https://github.com/apache/incubator-doris/pull/3418
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman closed issue #3675:
URL: https://github.com/apache/incubator-doris/issues/3675
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
morningman opened a new issue #3693:
URL: https://github.com/apache/incubator-doris/issues/3693
**Describe the bug**
In the test, we found that a simple single-table aggregate query, even in
the case of hit rollup, still can not achieve a high QPS.
Table: `id INT, name varchar(32)
imay commented on a change in pull request #3637:
URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r430119421
##
File path: be/src/olap/memory/mem_sub_tablet.cpp
##
@@ -0,0 +1,247 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
mdianjun opened a new issue #3695:
URL: https://github.com/apache/incubator-doris/issues/3695
coredump时,be.out基本都是以下两种栈信息:
```
*** Aborted at 1590347829 (unix time) try "date -d @1590347829" if you are
using GNU date ***
PC: @ 0xf4e487 std::__push_heap<>()
*** SIGS
chaoyli opened a new issue #3689:
URL: https://github.com/apache/incubator-doris/issues/3689
Doris is absent of query monitor. It is not convenient when analyzing the
query workload.
A query monitor should cover such features.
```
1. It can exhibit running queries at present.
2.
WingsGo commented on a change in pull request #3679:
URL: https://github.com/apache/incubator-doris/pull/3679#discussion_r430122762
##
File path: fe/src/main/java/org/apache/doris/common/util/TimeUtils.java
##
@@ -268,4 +269,11 @@ public static String
checkTimeZoneValidAndStan
morningman merged pull request #3649:
URL: https://github.com/apache/incubator-doris/pull/3649
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman commented on a change in pull request #3691:
URL: https://github.com/apache/incubator-doris/pull/3691#discussion_r430459028
##
File path: be/src/olap/reader.cpp
##
@@ -532,33 +521,31 @@ OLAPStatus Reader::_capture_rs_readers(const
ReaderParams& read_params) {
morningman opened a new pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694
Fix: #3693
This CL mainly changes:
1. Add a new BE config `max_pushdown_conditions_per_column` to limit the
number of conditions of a single column that can be pushed down to stora
decster commented on a change in pull request #3637:
URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r430488162
##
File path: be/src/olap/memory/mem_sub_tablet.cpp
##
@@ -0,0 +1,247 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mor
kangkaisen commented on a change in pull request #3681:
URL: https://github.com/apache/incubator-doris/pull/3681#discussion_r429973643
##
File path: fe/src/main/java/org/apache/doris/plugin/PluginContext.java
##
@@ -17,10 +17,19 @@
package org.apache.doris.plugin;
+import
kangkaisen commented on pull request #3686:
URL: https://github.com/apache/incubator-doris/pull/3686#issuecomment-633608098
> > @EmmyMiao87 Hi, Please add a UT to cover RollupJobV2 Serde. Thanks.
>
> Added
This PR seems not update.
kangkaisen commented on a change in pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#discussion_r430832292
##
File path: be/src/exec/olap_scan_node.cpp
##
@@ -884,25 +910,54 @@ Status
OlapScanNode::normalize_in_predicate(SlotDescriptor* slot, Column
acelyc111 opened a new pull request #3690:
URL: https://github.com/apache/incubator-doris/pull/3690
Ref https://github.com/apache/incubator-doris/issues/3687
Current cumulative point calculate algorithm may skip sigleton version
rowset when the rowset has only one segment and with NONO
chaoyli commented on pull request #3691:
URL: https://github.com/apache/incubator-doris/pull/3691#issuecomment-634003343
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on
morningman commented on a change in pull request #3676:
URL: https://github.com/apache/incubator-doris/pull/3676#discussion_r430221675
##
File path: docs/en/sql-reference/sql-statements/Data Manipulation/SHOW DATA.md
##
@@ -25,22 +25,62 @@ under the License.
-->
# SHOW DATA
imay merged pull request #3685:
URL: https://github.com/apache/incubator-doris/pull/3685
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
morningman merged pull request #3681:
URL: https://github.com/apache/incubator-doris/pull/3681
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman merged pull request #3686:
URL: https://github.com/apache/incubator-doris/pull/3686
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
chaoyli edited a comment on pull request #3635:
URL: https://github.com/apache/incubator-doris/pull/3635#issuecomment-633998103
> LGTM, except for some little problem.
> And please fix UT.
I have fixed the UT
This i
morningman commented on a change in pull request #3635:
URL: https://github.com/apache/incubator-doris/pull/3635#discussion_r429979202
##
File path: fe/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
##
@@ -757,10 +759,15 @@ private boolean loadTxnCommitImpl(TLo
chaoyli commented on pull request #3635:
URL: https://github.com/apache/incubator-doris/pull/3635#issuecomment-633998103
> LGTM, except for some little problem.
> And please fix UT.
I fix the UT
This is an automated
wutiangan commented on a change in pull request #3527:
URL: https://github.com/apache/incubator-doris/pull/3527#discussion_r430819150
##
File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java
##
@@ -263,15 +263,9 @@ public void vectorizedAnalyze(Analyzer ana
chaoyli edited a comment on issue #3689:
URL:
https://github.com/apache/incubator-doris/issues/3689#issuecomment-633853852
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
acelyc111 commented on a change in pull request #3691:
URL: https://github.com/apache/incubator-doris/pull/3691#discussion_r430499952
##
File path: be/src/olap/reader.cpp
##
@@ -532,33 +521,31 @@ OLAPStatus Reader::_capture_rs_readers(const
ReaderParams& read_params) {
morningman commented on a change in pull request #3681:
URL: https://github.com/apache/incubator-doris/pull/3681#discussion_r430212984
##
File path: fe/src/main/java/org/apache/doris/plugin/PluginContext.java
##
@@ -17,10 +17,19 @@
package org.apache.doris.plugin;
+import
morningman merged pull request #3692:
URL: https://github.com/apache/incubator-doris/pull/3692
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman closed issue #3680:
URL: https://github.com/apache/incubator-doris/issues/3680
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chaoyli merged pull request #3666:
URL: https://github.com/apache/incubator-doris/pull/3666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chaoyli commented on issue #3695:
URL:
https://github.com/apache/incubator-doris/issues/3695#issuecomment-634370193
It's may be caused by dirty memory address.
You can use Address Sanitizer tools incorporated in Doris to found it.
http://doris.apache.org/master/zh-CN/developer-guide/
chaoyli commented on a change in pull request #3668:
URL: https://github.com/apache/incubator-doris/pull/3668#discussion_r430178225
##
File path: be/src/olap/tablet_meta.cpp
##
@@ -101,6 +89,8 @@ TabletMeta::TabletMeta(int64_t table_id, int64_t
partition_id,
tablet_meta_p
acelyc111 opened a new pull request #3691:
URL: https://github.com/apache/incubator-doris/pull/3691
This is a simple refactor patch on class Reader without any functional
changes.
Main refactor points:
- Remove some useless return value
- Move some class member variables to functio
kangkaisen commented on issue #3693:
URL:
https://github.com/apache/incubator-doris/issues/3693#issuecomment-634100090
Good job!
This is an automated message from the Apache Git Service.
To respond to the message, please log
morningman merged pull request #3676:
URL: https://github.com/apache/incubator-doris/pull/3676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
morningman commented on a change in pull request #3679:
URL: https://github.com/apache/incubator-doris/pull/3679#discussion_r429950455
##
File path:
fe/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
##
@@ -210,7 +215,8 @@ public void createOrUpdateRuntimeI
wuyunfeng commented on a change in pull request #3454:
URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r428034718
##
File path: fe/src/main/java/org/apache/doris/external/EsRestClient.java
##
@@ -49,48 +54,103 @@
.readTimeout(10, TimeUnit.SECOND
morningman commented on issue #3689:
URL:
https://github.com/apache/incubator-doris/issues/3689#issuecomment-634071950
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
EmmyMiao87 commented on pull request #3686:
URL: https://github.com/apache/incubator-doris/pull/3686#issuecomment-633779752
> > > @EmmyMiao87 Hi, Please add a UT to cover RollupJobV2 Serde. Thanks.
> >
> >
> > Added
>
> This PR seems not update.
=0= Added
imay merged pull request #3684:
URL: https://github.com/apache/incubator-doris/pull/3684
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
worker24h opened a new pull request #3692:
URL: https://github.com/apache/incubator-doris/pull/3692
Add check for null pointer to avoid coredump
This is an automated message from the Apache Git Service.
To respond to the mess
This is an automated email from the ASF dual-hosted git repository.
lichaoyong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1cc78fe [Enhancement] Convert metr
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 12c59ba [Thirdparty][glog][bug] co
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new fb66bac [Bug] Fix null pointer acc
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new dcd5e5d [AuditPlugin] Modify load
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 77b9acc [Stmt] Add rowCount column
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new aa4ac2d [Bug] Serialize storage fo
67 matches
Mail list logo