WingsGo commented on a change in pull request #3679:
URL: https://github.com/apache/incubator-doris/pull/3679#discussion_r430122762
##########
File path: fe/src/main/java/org/apache/doris/common/util/TimeUtils.java
##########
@@ -268,4 +269,11 @@ public static String
checkTimeZoneValidAndStandardize(String value) throws DdlEx
}
throw new DdlException("Parse time zone " + value + " error");
}
+
+ // return the number of days of give year.month
+ public static int getNumberDaysOfMonth(int year, int month) {
+ Calendar calendar = Calendar.getInstance();
+ calendar.set(year, month + 1, 0);
Review comment:
why plus one? `getNumberDaysOfMonth(2020, 1)` will return 29, and the
function name is confused
##########
File path:
fe/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
##########
@@ -149,10 +148,11 @@ public void createOrUpdateRuntimeInfo(String tableName,
String key, String value
addPartitionKeyRange = Range.closedOpen(lowerBound,
upperBound);
} catch (AnalysisException e) {
// keys.size is always equal to column.size, cannot reach this
exception
- LOG.warn("Keys size is not equal to column size. Error={}",
e.getMessage());
+ LOG.warn("Keys size is not equal to column size. Error={}, db:
{}, table: {}", e.getMessage(),
+ db.getFullName(), olapTable.getName());
Review comment:
same as following comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
