chaoyli edited a comment on issue #3517:
URL:
https://github.com/apache/incubator-doris/issues/3517#issuecomment-625588846
The metric is like this
```
[
{
"tags":{
"table_id":10010,
"metric":"scanner_rows"
},
"value":1000,
gaodayue commented on a change in pull request #3488:
URL: https://github.com/apache/incubator-doris/pull/3488#discussion_r421976455
##
File path: be/src/common/config.h
##
@@ -488,8 +488,10 @@ namespace config {
// Valid configs: ALPHA, BETA
CONF_String(default_rowse
hffariel commented on issue #3420:
URL:
https://github.com/apache/incubator-doris/issues/3420#issuecomment-625666914
Caused by relative path, should be ok now.
This is an automated message from the Apache Git Service.
To res
hffariel commented on issue #3419:
URL:
https://github.com/apache/incubator-doris/issues/3419#issuecomment-625666096
1. Sidebar menu is ok now, but still has an issue related with [vuepress nav
bar dropdown issue](https://github.com/vuejs/vuepress/pull/2339)(which could
only be fixed by t
kangpinghuang commented on a change in pull request #3296:
URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r421972254
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppUtils.java
##
@@ -0,0 +1,252 @@
+// Licensed to the Apache Software Found
WingsGo opened a new pull request #3523:
URL: https://github.com/apache/incubator-doris/pull/3523
This CL have no logic changed, just do some code refactor and use new
UtFrameWork to replace some old UT.
This is an automated
imay commented on a change in pull request #3439:
URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r421940960
##
File path:
docs/en/sql-reference/sql-functions/string-functions/append_trailing_char_if_absent.md
##
@@ -0,0 +1,58 @@
+---
+{
+"title": "appe
acelyc111 commented on pull request #3495:
URL: https://github.com/apache/incubator-doris/pull/3495#issuecomment-625632414
> It's better to add some descriptor for this pull request.
Done
This is an automated message f
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 2586f09 [Bug] Fix bug that SHOW DE
imay commented on issue #3491:
URL:
https://github.com/apache/incubator-doris/issues/3491#issuecomment-625632194
> @imay @kangkaisen can we check the binary compare type, if one type is
string and the other type is numerical such as int, bigint, we just return
the numercal type in `ge
imay opened a new pull request #3522:
URL: https://github.com/apache/incubator-doris/pull/3522
#3518
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8015d8c [Script] Make build script
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 94b3a2b [Bug] Fix string functions not support multibyte string
(#3345)
add 2f7d2c7 [BUG] Fix a
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 94b3a2b [Bug] Fix string functions
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 45814c8 [BugFix] Fix the bug that FE web can't show each fragment
execute time percent (#3497)
ad
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from f591976 [Doc] Fix the incorrect docs (#3501)
add 45814c8 [BugFix] Fix the bug that FE web can't s
gaodayue opened a new pull request #3521:
URL: https://github.com/apache/incubator-doris/pull/3521
Fixes #3520
Input to `hll_merge` could be null when hll_union_agg's parameter is
expression such as ` hll_union_agg(case when page_type = 'order' then user_hll
end)`.
--
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 0845153 [Bug] Fix constant In Predicate result error (#3511)
add f591976 [Doc] Fix the incorrect
wuyunfeng commented on a change in pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#discussion_r421932324
##
File path: be/src/exec/es/es_scroll_parser.cpp
##
@@ -275,7 +286,32 @@ int ScrollParser::get_total() {
Status ScrollParser::fill_tuple(const
gaodayue opened a new issue #3520:
URL: https://github.com/apache/incubator-doris/issues/3520
**Describe the bug**
When input to hll function is null, BE crashes with the following stack
```
*** Aborted at 1588908360 (unix time) try "date -d @1588908360" if you are
using GNU da
acelyc111 commented on a change in pull request #3495:
URL: https://github.com/apache/incubator-doris/pull/3495#discussion_r421923066
##
File path: be/src/util/path_util.cpp
##
@@ -70,13 +70,19 @@ vector split_path(const string& path) {
return segments;
}
+struct FreeDe
blackfox1983 commented on a change in pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#discussion_r421917673
##
File path: be/src/exec/es/es_scroll_parser.cpp
##
@@ -275,7 +286,32 @@ int ScrollParser::get_total() {
Status ScrollParser::fill_tuple(co
blackfox1983 commented on a change in pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#discussion_r421917742
##
File path: be/src/exec/es/es_scroll_parser.cpp
##
@@ -275,7 +286,32 @@ int ScrollParser::get_total() {
Status ScrollParser::fill_tuple(co
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0845153 [Bug] Fix constant In Pred
wuyunfeng commented on a change in pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#discussion_r421914223
##
File path: be/src/exec/es/es_scroll_parser.cpp
##
@@ -275,7 +286,32 @@ int ScrollParser::get_total() {
Status ScrollParser::fill_tuple(const
wuyunfeng commented on issue #3479:
URL:
https://github.com/apache/incubator-doris/issues/3479#issuecomment-625607639
maybe you should emphasize have no value for one batch_size
This is an automated message from the Apache
WingsGo commented on pull request #3519:
URL: https://github.com/apache/incubator-doris/pull/3519#issuecomment-625606320
For #3402
This is an automated message from the Apache Git Service.
To respond to the message, please l
WingsGo opened a new pull request #3519:
URL: https://github.com/apache/incubator-doris/pull/3519
Currently we choose BE random without check disk is available, the create
table will failed until create tablet task is sent to BE and BE will check is
there has avaliable capcity to create ta
chaoyli commented on issue #3517:
URL:
https://github.com/apache/incubator-doris/issues/3517#issuecomment-625604902
There also exists another function using log.
If every query collecting the tablet scanner rows/bytes, and write it to log.
We can access the log to get the message, it
xy720 commented on pull request #3515:
URL: https://github.com/apache/incubator-doris/pull/3515#issuecomment-625604653
LGTM!
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
chaoyli edited a comment on issue #3517:
URL:
https://github.com/apache/incubator-doris/issues/3517#issuecomment-625588846
The metric is like this
```
[
{
"tags":{
"tablet_id":10010,
"metric":"scanner_rows"
},
"value":1000,
chaoyli edited a comment on issue #3517:
URL:
https://github.com/apache/incubator-doris/issues/3517#issuecomment-625588846
The metric is like this
```
[
{
"tags":{
"tablet_id":10010,
"metric":"scanner_rows"
},
"value":1000,
imay opened a new issue #3518:
URL: https://github.com/apache/incubator-doris/issues/3518
After discussed in mailing list, we are going to add committed guideline for
Doris Committers.
Following is the draft of the guideline.
**Code Review Guidelines**
1. Always maintain a
wuyunfeng edited a comment on pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#issuecomment-625596825
Can you prefix [Doris On ES] on this PR title and describe the problem more
meticulous and accurately
wuyunfeng edited a comment on pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#issuecomment-625596825
Can you prefix [Doris On ES] on this PR title and describe the problem you
resolved more meticulous and accurately
---
wuyunfeng commented on pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#issuecomment-625596825
Can you prefix [Doris On ES] on this PR title?
This is an automated message from the Apache Git Servi
sduzh commented on a change in pull request #3493:
URL: https://github.com/apache/incubator-doris/pull/3493#discussion_r421902146
##
File path: thirdparty/build-thirdparty.sh
##
@@ -295,7 +295,7 @@ build_gtest() {
check_if_source_exist $GTEST_SOURCE
cd $TP_SOURCE_DI
This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 1893cd7 Update travis.yml (#3512)
add bc42870 Update UT compile path (#3498) (#3499)
No new revisions
chaoyli edited a comment on issue #3517:
URL:
https://github.com/apache/incubator-doris/issues/3517#issuecomment-625588846
The metric is like this
```
[
{
"tags":{
"tablet_id":10010,
"metric":"scanner_rows"
},
"value":1000,
chaoyli edited a comment on issue #3517:
URL:
https://github.com/apache/incubator-doris/issues/3517#issuecomment-625588846
The metric is like this
```
[
{
"tags":{
"tablet_id":10010,
"metric":"scanner_rows"
},
"value":1000,
chaoyli edited a comment on issue #3517:
URL:
https://github.com/apache/incubator-doris/issues/3517#issuecomment-625588846
The metric is like this
```
[
{
"tags":{
"tablet_id":10010,
"metric":"scanner_rows"
},
"value":1000,
chaoyli commented on issue #3517:
URL:
https://github.com/apache/incubator-doris/issues/3517#issuecomment-625588846
Supposing there are 1 tablets in one BE node, the metric is like this
```
[
{
"tags":{
"tablet_id":10010,
"metric":"scanner_ro
morningman commented on a change in pull request #3511:
URL: https://github.com/apache/incubator-doris/pull/3511#discussion_r421895374
##
File path: fe/src/main/java/org/apache/doris/analysis/InPredicate.java
##
@@ -54,6 +54,8 @@
private static final String IN = "in";
chaoyli opened a new issue #3517:
URL: https://github.com/apache/incubator-doris/issues/3517
Nowadays, We have no insight about the hotspot the cluster.
During the time, we don't know the scanner rows of one tablet during time.
Now we should collect the scanner rows of the tablet and s
morningman commented on a change in pull request #3511:
URL: https://github.com/apache/incubator-doris/pull/3511#discussion_r421894390
##
File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java
##
@@ -725,4 +725,58 @@ public void
testJoinPredicateTransitivityWi
WingsGo commented on pull request #3490:
URL: https://github.com/apache/incubator-doris/pull/3490#issuecomment-625583884
> @WingsGo
> This PR contains too many things. Could you please split this PR into
multiple PRs? It will make reviewer easier.
OK, I will submit code refactory
fanlongmengjd commented on issue #3370:
URL:
https://github.com/apache/incubator-doris/issues/3370#issuecomment-625578015
this time admin set frontend config("catalog_trash_expire_second" = "5")
This is an automated message
fanlongmengjd commented on issue #3370:
URL:
https://github.com/apache/incubator-doris/issues/3370#issuecomment-625577525
this issue showed again.
i checked fe.log, fe.warn, fe.audit, there was not any drop action.
but issue happened again.
![image](https://user-images.githubuser
GavinYaoer opened a new issue #3516:
URL: https://github.com/apache/incubator-doris/issues/3516
编译完成后启动fe报找不到MainClass
查看启动脚本，发现定义了CLASSPATH，但是启动时并没有用到该属性
This is an automated message from the Apache Git Service.
To re
imay commented on pull request #3490:
URL: https://github.com/apache/incubator-doris/pull/3490#issuecomment-625356854
@WingsGo
This PR contains too many things. Could you please split this PR into
multiple PRs? It will make reviewer easier.
kangkaisen commented on a change in pull request #3511:
URL: https://github.com/apache/incubator-doris/pull/3511#discussion_r421626800
##
File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java
##
@@ -725,4 +725,58 @@ public void
testJoinPredicateTransitivityWi
morningman commented on a change in pull request #3488:
URL: https://github.com/apache/incubator-doris/pull/3488#discussion_r420808809
##
File path: be/src/common/config.h
##
@@ -488,8 +488,10 @@ namespace config {
// Valid configs: ALPHA, BETA
CONF_String(default_row
kangkaisen commented on a change in pull request #3511:
URL: https://github.com/apache/incubator-doris/pull/3511#discussion_r421625898
##
File path: fe/src/main/java/org/apache/doris/analysis/InPredicate.java
##
@@ -54,6 +54,8 @@
private static final String IN = "in";
morningman commented on pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#issuecomment-625347049
@wuyunfeng Please help to review this PR.
This is an automated message from the Apache Git Service.
T
morningman commented on a change in pull request #3424:
URL: https://github.com/apache/incubator-doris/pull/3424#discussion_r421610632
##
File path: be/src/olap/delete_handler.cpp
##
@@ -105,10 +105,10 @@ OLAPStatus DeleteConditionHandler::check_condition_valid(
// 检查指定的列是
kangkaisen commented on issue #3496:
URL:
https://github.com/apache/incubator-doris/issues/3496#issuecomment-625341705
@sduzh Please refer to
http://doris.apache.org/master/zh-CN/administrator-guide/segment-v2-usage.html
Th
caiconghui commented on a change in pull request #3369:
URL: https://github.com/apache/incubator-doris/pull/3369#discussion_r421610744
##
File path:
fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
##
@@ -1346,81 +359,71 @@ public TransactionIdGenerator
morningman commented on pull request #3515:
URL: https://github.com/apache/incubator-doris/pull/3515#issuecomment-625336845
@xy720 Please review
This is an automated message from the Apache Git Service.
To respond to the mess
morningman opened a new pull request #3515:
URL: https://github.com/apache/incubator-doris/pull/3515
Fix: #3514
The callback added to the CallbackFactory should not be removed until the
transaction is aborted or visible. Otherwise, some callback method may failed
to be called.
--
morningman opened a new issue #3514:
URL: https://github.com/apache/incubator-doris/issues/3514
**Describe the bug**
After executing a delete and then execute `show delete`. It returns empty
result.
**To Reproduce**
It happens accidentally.
**Expected behavior**
`show
blackfox1983 opened a new pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513
in `enable_doc_value_scan` mode, when some fields does not been assigned,
sql like `select f1,f2..` will be failed.
so ,i resolved this bug by passing `doc_value_mod` to related class f
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1893cd7 Update travis.yml (#3512)
kangkaisen opened a new pull request #3512:
URL: https://github.com/apache/incubator-doris/pull/3512
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a change to branch kangkaisen-travis1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
at 8013a3b Update travis.yml
This branch includes the following new commits:
new 8013a3
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a commit to branch kangkaisen-travis1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 8013a3bbc9e2ade5f85c3eb0ad11d71f5d150b77
Author: kangkaisen
AuthorDate: Thu May 7 23:05:07 2020
morningman commented on pull request #3503:
URL: https://github.com/apache/incubator-doris/pull/3503#issuecomment-625310432
This is fix by #3502. This PR will be closed
This is an automated message from the Apache Git Service
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from d60bb81 [SQL Function] Calculate 'case when expr' when possible
(#3396)
add c85d847 [CompileBug]
yangzhg opened a new pull request #3502:
URL: https://github.com/apache/incubator-doris/pull/3502
fix a compile error by no return statment in non-void function
This is an automated message from the Apache Git Service.
To res
morningman commented on a change in pull request #3369:
URL: https://github.com/apache/incubator-doris/pull/3369#discussion_r421537636
##
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##
@@ -2639,6 +2641,7 @@ public void dropDb(DropDbStmt stmt) throws DdlExc
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new d60bb81 [SQL Function] Calculate '
morningman opened a new pull request #3511:
URL: https://github.com/apache/incubator-doris/pull/3511
`select 1 not in (2, NULL, 1);` should return `0`
Fix: #3510
This is an automated message from the Apache Git Servic
morningman opened a new issue #3510:
URL: https://github.com/apache/incubator-doris/issues/3510
**Describe the bug**
`select 1 not in (2, NULL, 1);`
expected: `0`
Actual: `NULL`
This is an automated message f
worker24h opened a new issue #3509:
URL: https://github.com/apache/incubator-doris/issues/3509
此issue主要讨论，导入json数据接口定义， 欢迎大家进行讨论
前提： 表1有 category,price,author三列， 以routine load导入举例说明
分类： 由于json支持嵌套，所以json数据可能很复杂，因为这里设计默认导入和精准导入
一、默认导入（不提供jsonpath）
默认导入，表示表列的顺序与json中key/val
vagetablechicken commented on issue #3507:
URL:
https://github.com/apache/incubator-doris/issues/3507#issuecomment-625183399
Higher version gcc will be more exclusive. If GCC 9+ should be taken into
account, we can use `#pragma` to turn off warnings. Or simply, improve the
build.sh, only
decster opened a new pull request #3508:
URL: https://github.com/apache/incubator-doris/pull/3508
This CL add core column related classes into the code base, including:
- Buffer
- ColumnBlock
- ColumnDelta
- Column
- DeltaIndex
- ColumnSchema and Schema
Column re
imay commented on issue #3507:
URL:
https://github.com/apache/incubator-doris/issues/3507#issuecomment-625172031
I'm not very sure, when I compile Doris with GCC 9+ there are a lot of error
caused by thirdparty header files.
It will be better to compile Doris with higher version GCC whe
vagetablechicken opened a new issue #3507:
URL: https://github.com/apache/incubator-doris/issues/3507
We only add `-Werror` in Debug mode. But build.sh usually use release mode.
It's dangerous.
If we can't fix all warnings, it better to use `-Wno-xxx`.
-
kangkaisen opened a new pull request #3506:
URL: https://github.com/apache/incubator-doris/pull/3506
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a commit to branch branch-0.12
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/branch-0.12 by this push:
new 039aeb8 Update travis.ym
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a commit to branch travis-12
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 2ad485803aa8b101af85cd387dcbf37bdf9d7d7d
Author: kangkaisen
AuthorDate: Thu May 7 18:06:46 2020 +0800
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a change to branch travis-12
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
at 2ad4858 Update travis.yml
This branch includes the following new commits:
new 2ad4858 Update
vagetablechicken commented on pull request #3503:
URL: https://github.com/apache/incubator-doris/pull/3503#issuecomment-625133378
OK, I will issue a new PR.
And the compile warnings shouldn't be ignored, we only add '-Werror' in
debug mode. I think we need `-Werror` in release mode
---
Seaven opened a new pull request #3505:
URL: https://github.com/apache/incubator-doris/pull/3505
For #3447，update plugin document
This is an automated message from the Apache Git Service.
To respond to the message, please lo
acelyc111 edited a comment on issue #3504:
URL:
https://github.com/apache/incubator-doris/issues/3504#issuecomment-625126360
```
(gdb) f 1
#1 0x0101f52b in doris::Tuple::deep_copy (this=,
desc=..., data=data@entry=0x7efe86d80280, offset=offset@entry=0x7efe86d8027c,
convert_
acelyc111 commented on issue #3504:
URL:
https://github.com/apache/incubator-doris/issues/3504#issuecomment-625126360
```
(gdb) f 1
#1 0x0101f52b in doris::Tuple::deep_copy (this=,
desc=..., data=data@entry=0x7efe86d80280, offset=offset@entry=0x7efe86d8027c,
convert_ptrs=co
acelyc111 opened a new issue #3504:
URL: https://github.com/apache/incubator-doris/issues/3504
**Describe the bug**
BE crashed when run TPC-DS test.
**To Reproduce**
Steps to reproduce the behavior:
1. load TPC-DS data
2. run SQL `SELECT asceding.rnk, i1.i_product_nam
yangzhg commented on a change in pull request #3345:
URL: https://github.com/apache/incubator-doris/pull/3345#discussion_r421335854
##
File path: gensrc/script/doris_builtins_functions.py
##
@@ -533,6 +533,10 @@
'15FunctionContextERKNS1_9StringValERKNS1_6IntValES6_
morningman edited a comment on pull request #3503:
URL: https://github.com/apache/incubator-doris/pull/3503#issuecomment-625090368
Hi @vagetablechicken
Your PR #3143 may has some problem which cause BE in our CI environment
crashed.
Some of core file shows like:
```
#0 tcm
morningman commented on pull request #3503:
URL: https://github.com/apache/incubator-doris/pull/3503#issuecomment-625090368
Hi @vagetablechicken
Your PR #3143 may has some problem which cause BE in our CI environment
crashed.
Some of core file shows like:
```
#0 tcmalloc::
yangzhg opened a new pull request #3503:
URL: https://github.com/apache/incubator-doris/pull/3503
this pr casue many localtest fail and in tablet_sink.cpp:225 requires return
statment in non-void function
This is an automate
ZengRL commented on issue #3482:
URL:
https://github.com/apache/incubator-doris/issues/3482#issuecomment-625086182
oh, I see more message in be.INFO
2020-05-07 15:24:09,351 INFO 39
[GlobalTransactionMgr.beginTransaction():193] begin transaction: txn id 4731688
with label f00c7f57f0f540
ZengRL edited a comment on issue #3482:
URL:
https://github.com/apache/incubator-doris/issues/3482#issuecomment-625076029
supplement：
① I have 300 routine load job
② Job run once in ten minutes
