kangkaisen commented on a change in pull request #3511:
URL: https://github.com/apache/incubator-doris/pull/3511#discussion_r421625898



##########
File path: fe/src/main/java/org/apache/doris/analysis/InPredicate.java
##########
@@ -54,6 +54,8 @@
     private static final String IN = "in";
     private static final String NOT_IN = "not_in";
 
+    private static final NullLiteral NULL_LITERAL = new NullLiteral();

Review comment:
       Why use static variable?  I think local variable is enough. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to