[GitHub] [incubator-doris] kangkaisen commented on pull request #3451: [Fix] Fix bug that rowset meta is deleted after compaction

2020-05-01 Thread GitBox
kangkaisen commented on pull request #3451: URL: https://github.com/apache/incubator-doris/pull/3451#issuecomment-622645340 > > @morningman Hi, How do we avoid this bug happen again?do we need add a compaction test framework to cover all compaction test cases? > > Agreed, I will try

[GitHub] [incubator-doris] acelyc111 commented on pull request #3417: [metrics] Make DorisMetrics to be a real singleton

2020-05-01 Thread GitBox
acelyc111 commented on pull request #3417: URL: https://github.com/apache/incubator-doris/pull/3417#issuecomment-622403624 > You can also change the static variable. Done This is an automated message from the Apache Gi

[incubator-doris] branch master updated: [Memory Engine] Make Tablet extensible (#3431)

2020-05-01 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 4737aff [Memory Engine] Make Table

[incubator-doris] branch master updated (54da5a4 -> 8e21827)

2020-05-01 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 54da5a4 Fix delete statement doc display not correctly (#3445) add 8e21827 [Bug][AuditPlugin] Fix

[GitHub] [incubator-doris] morningman commented on pull request #3451: [Fix] Fix bug that rowset meta is deleted after compaction

2020-05-01 Thread GitBox
morningman commented on pull request #3451: URL: https://github.com/apache/incubator-doris/pull/3451#issuecomment-622382513 > @morningman Hi, How do we avoid this bug happen again?do we need add a compaction test framework to cover all compaction test cases? Agreed, I will try to fin

[GitHub] [incubator-doris] kangkaisen commented on issue #3442: [Memory Engine] Add MemTablet type to TabletMeta

2020-05-01 Thread GitBox
kangkaisen commented on issue #3442: URL: https://github.com/apache/incubator-doris/issues/3442#issuecomment-622355933 @decster Hi, how do we expect our user to create the real in memory table (different from early `in memory` OLAP table cache )? I think if the user interface is decided,t

[incubator-doris] branch master updated: Fix delete statement doc display not correctly (#3445)

2020-05-01 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 54da5a4 Fix delete statement doc d

[GitHub] [incubator-doris] kangkaisen commented on pull request #3446: Update doris-on-es.md

2020-05-01 Thread GitBox
kangkaisen commented on pull request #3446: URL: https://github.com/apache/incubator-doris/pull/3446#issuecomment-622349704 @xbyang18 Hi, next time. would better put Chinese and English doc update to one PR. Thanks! This is

[GitHub] [incubator-doris] kangkaisen commented on pull request #3446: Update doris-on-es.md

2020-05-01 Thread GitBox
kangkaisen commented on pull request #3446: URL: https://github.com/apache/incubator-doris/pull/3446#issuecomment-622349195 Related PR: #3441 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] kangkaisen commented on issue #3447: 关于使用文档的编写建议

2020-05-01 Thread GitBox
kangkaisen commented on issue #3447: URL: https://github.com/apache/incubator-doris/issues/3447#issuecomment-622348580 @blackfox1983 很好的建议! 我们最近也一直在完善文档,你的建议都比较合理。 我们会不断改进。 也期待和欢迎你帮助社区完善文档。 感谢。 This is an automated messag

[GitHub] [incubator-doris] kangkaisen commented on pull request #3451: [Fix] Fix bug that rowset meta is deleted after compaction

2020-05-01 Thread GitBox
kangkaisen commented on pull request #3451: URL: https://github.com/apache/incubator-doris/pull/3451#issuecomment-622342997 @morningman Hi, How do we avoid this bug happen again?do we need add a compaction test framework to cover all compaction test cases?

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

2020-05-01 Thread GitBox
kangkaisen commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r418495889 ## File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -504,4 +504,106 @@ public void testDateTypeEquality() throws E

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3439: Support append_trailing_char_if_absent function

2020-05-01 Thread GitBox
kangkaisen commented on a change in pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r418492786 ## File path: be/src/exprs/string_functions.cpp ## @@ -212,6 +212,28 @@ StringVal StringFunctions::rpad( } return result; } + +Strin