kangkaisen commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r418495889
########## File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java ########## @@ -504,4 +504,106 @@ public void testDateTypeEquality() throws Exception { Catalog.getCurrentCatalog().getLoadManager().createLoadJobV1FromStmt(loadStmt, EtlJobType.HADOOP, System.currentTimeMillis()); } + + private SelectStmt getAnalyzedAndRewritedStmt(String sql) throws Exception { Review comment: I don't think so. Directly check final FE sql plan is more accurate: 1. FE send BE is the sql plan 2. Your work do indeed is changing partial plan to constant. > What we want is to check whether the plan changes as our wish So you should use `getSQLPlanOrErrorMsg ` > I think the result of getSQLPlanOrErrorMsg can't meet demand Why couldn't meet you demand? I think which could. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org