[incubator-doris] branch master updated (c9ec4e8 -> d0fe7e4)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from c9ec4e8 [UT] Fix AlterTest UT failed (#3437) add d0fe7e4 [Profile] Make running profile clearer

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3422: [Bug] Fix bug that load to data to wrong temp partitions

EmmyMiao87 commented on a change in pull request #3422: URL: https://github.com/apache/incubator-doris/pull/3422#discussion_r417792563 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java ## @@ -88,7 +88,8 @@ private final TableName tblName; priv

[GitHub] [incubator-doris] morningman commented on a change in pull request #3422: [Bug] Fix bug that load to data to wrong temp partitions

morningman commented on a change in pull request #3422: URL: https://github.com/apache/incubator-doris/pull/3422#discussion_r417789053 ## File path: fe/src/main/java/org/apache/doris/planner/StreamLoadPlanner.java ## @@ -185,6 +185,10 @@ public TExecPlanFragmentParams plan(TUni

[incubator-doris] branch master updated (a6c0d37 -> c9ec4e8)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from a6c0d37 [Thirdparty] Update ORC lib download address (#3440) add c9ec4e8 [UT] Fix AlterTest UT fa

[GitHub] [incubator-doris] Youngwb commented on a change in pull request #3439: Support append_trailing_char_if_absent function

Youngwb commented on a change in pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r417778746 ## File path: be/src/exprs/string_functions.cpp ## @@ -212,6 +212,28 @@ StringVal StringFunctions::rpad( } return result; } + +StringVa

[incubator-doris] branch master updated (25e4758 -> a6c0d37)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 25e4758 [Bug] Fix the error result when assert num rows node is used (#3436) add a6c0d37 [Thirdp

[incubator-doris] branch master updated (beb5b29 -> 25e4758)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from beb5b29 [Doc] Fix linked file not found (#3434) add 25e4758 [Bug] Fix the error result when asser

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

vagetablechicken commented on a change in pull request #3143: URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r417763651 ## File path: be/src/exec/tablet_sink.cpp ## @@ -128,54 +131,136 @@ Status NodeChannel::open_wait() { _open_closure = nullptr;

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

wangbo commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417758359 ## File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -504,4 +504,106 @@ public void testDateTypeEquality() throws Excep

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

wangbo commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417717099 ## File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -504,4 +504,106 @@ public void testDateTypeEquality() throws Excep

[GitHub] [incubator-doris] wyb commented on pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wyb commented on pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#issuecomment-621616614 > @wyb Hi, why comment the update load cluster code? Because EtlClusterDesc class is used in the load job process, and is not in this pr. I will remove the comment

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

vagetablechicken commented on a change in pull request #3143: URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r417745660 ## File path: be/src/exec/tablet_sink.h ## @@ -68,99 +154,126 @@ class NodeChannel { Status add_row(Tuple* tuple, int64_t tablet_i

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

imay commented on a change in pull request #3143: URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r417744700 ## File path: be/src/exec/tablet_sink.cpp ## @@ -128,54 +131,136 @@ Status NodeChannel::open_wait() { _open_closure = nullptr; // add bat

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

wangbo commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417741395 ## File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -504,4 +504,106 @@ public void testDateTypeEquality() throws Excep

[GitHub] [incubator-doris] kangkaisen commented on pull request #3418: [Spark load] Add spark etl cluster and cluster manager

kangkaisen commented on pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#issuecomment-621594189 @wyb Hi, why comment the update load cluster code? This is an automated message from the Apache Git S

[GitHub] [incubator-doris] kangkaisen commented on pull request #3441: Update doris-on-es.md

kangkaisen commented on pull request #3441: URL: https://github.com/apache/incubator-doris/pull/3441#issuecomment-621592151 @xbyang18 Hi, please also update `en/extending-doris/doris-on-es.md` doc, Thanks. This is an automat

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3439: Support append_trailing_char_if_absent function

kangkaisen commented on a change in pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r417732926 ## File path: be/src/exprs/string_functions.cpp ## @@ -212,6 +212,28 @@ StringVal StringFunctions::rpad( } return result; } + +Strin

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3439: Support append_trailing_char_if_absent function

kangkaisen commented on a change in pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r417732090 ## File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java ## @@ -604,6 +604,23 @@ public void analyzeImpl(Analyzer analyze

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3436: Fix the error result when assert num rows node is used

EmmyMiao87 commented on a change in pull request #3436: URL: https://github.com/apache/incubator-doris/pull/3436#discussion_r417731508 ## File path: be/src/exec/assert_num_rows_node.cpp ## @@ -45,6 +45,7 @@ Status AssertNumRowsNode::prepare(RuntimeState* state) { Status Assert

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

wangbo commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417730477 ## File path: fe/src/main/java/org/apache/doris/analysis/CaseExpr.java ## @@ -251,4 +257,72 @@ public void analyzeImpl(Analyzer analyzer) throws A

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #3143: Non blocking OlapTableSink

vagetablechicken commented on a change in pull request #3143: URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r417728936 ## File path: be/src/exec/tablet_sink.cpp ## @@ -128,54 +131,136 @@ Status NodeChannel::open_wait() { _open_closure = nullptr;

[GitHub] [incubator-doris] xbyang18 opened a new pull request #3441: Update doris-on-es.md

xbyang18 opened a new pull request #3441: URL: https://github.com/apache/incubator-doris/pull/3441 update "host" = "http://192.168.0.1:8200,http://192.168.0.2:8200"; to "hosts" = "http://192.168.0.1:8200,http://192.168.0.2:8200";,

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

wangbo commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417717099 ## File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -504,4 +504,106 @@ public void testDateTypeEquality() throws Excep

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

wangbo commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417717171 ## File path: fe/src/main/java/org/apache/doris/analysis/CaseExpr.java ## @@ -251,4 +257,72 @@ public void analyzeImpl(Analyzer analyzer) throws A

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

wangbo commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417717067 ## File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -504,4 +504,106 @@ public void testDateTypeEquality() throws Excep

[GitHub] [incubator-doris] sduzh opened a new pull request #3440: update orc download address

sduzh opened a new pull request #3440: URL: https://github.com/apache/incubator-doris/pull/3440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-doris] Youngwb opened a new pull request #3439: Support append_trailing_char_if_absent function

Youngwb opened a new pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439 support append_trailing_char_if_absent function #2598 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] imay commented on issue #3438: [Proposal] Vectorization query optimization for Doris

imay commented on issue #3438: URL: https://github.com/apache/incubator-doris/issues/3438#issuecomment-621314562 @HappenLee Vectorization is a good way to accelerate execution. However in my point of view this will change all the execution framework. So before real code work, we shoul

[GitHub] [incubator-doris] kangkaisen commented on issue #3438: [Proposal] Vectorization query optimization for Doris

kangkaisen commented on issue #3438: URL: https://github.com/apache/incubator-doris/issues/3438#issuecomment-621314331 @HappenLee I don't see the performance improve for your POC? What's your detailed design? Do you plan to still use `RowBlockV2` and `ColumnBlock`? Do y

[GitHub] [incubator-doris] HappenLee opened a new issue #3438: [Proposal] Vectorization query optimization for Doris

HappenLee opened a new issue #3438: URL: https://github.com/apache/incubator-doris/issues/3438 Motivation At present, the underlying storage in Doris is column storage.Query execution needs to be transferred to the query layer for execution by row-to-column first. Such an implement

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3422: [Bug] Fix bug that load to data to wrong temp partitions

kangkaisen commented on a change in pull request #3422: URL: https://github.com/apache/incubator-doris/pull/3422#discussion_r417421694 ## File path: fe/src/main/java/org/apache/doris/planner/StreamLoadPlanner.java ## @@ -185,6 +185,10 @@ public TExecPlanFragmentParams plan(TUni

[GitHub] [incubator-doris] imay commented on a change in pull request #3143: Non blocking OlapTableSink

imay commented on a change in pull request #3143: URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r417387499 ## File path: be/src/exec/tablet_sink.h ## @@ -68,99 +154,126 @@ class NodeChannel { Status add_row(Tuple* tuple, int64_t tablet_id); -S

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3396: (#3395)calculate 'case when expr' when possible

kangkaisen commented on a change in pull request #3396: URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417402243 ## File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -504,4 +504,106 @@ public void testDateTypeEquality() throws E

[GitHub] [incubator-doris] morningman commented on a change in pull request #3437: [UT] Fix AlterTest UT failed

morningman commented on a change in pull request #3437: URL: https://github.com/apache/incubator-doris/pull/3437#discussion_r417399371 ## File path: fe/src/test/java/org/apache/doris/alter/AlterTest.java ## @@ -135,10 +135,10 @@ public void testConflictAlterOperations() throws

[GitHub] [incubator-doris] kangkaisen commented on pull request #3428: [BugFix] document issues

kangkaisen commented on pull request #3428: URL: https://github.com/apache/incubator-doris/pull/3428#issuecomment-621273557 @hffariel Hi, This PR is reduplicated with https://github.com/apache/incubator-doris/pull/3427 ? You could refer to https://gist.github.com/robertpainsi/b63236

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3405: [Profile] Make running profile clearer and more intuitive to improve usability

kangkaisen commented on a change in pull request #3405: URL: https://github.com/apache/incubator-doris/pull/3405#discussion_r417382629 ## File path: be/src/exec/exec_node.cpp ## @@ -172,15 +172,13 @@ Status ExecNode::prepare(RuntimeState* state) { DCHECK(_runtime_profile.g

[GitHub] [incubator-doris] morningman commented on pull request #3424: allow delete duplicated non-key column using delete from

morningman commented on pull request #3424: URL: https://github.com/apache/incubator-doris/pull/3424#issuecomment-621266078 We made a bug after supporting creating materialized view on Duplicate Key table. And could you please fix it too? That is: After creating a table with colum

[GitHub] [incubator-doris] morningman commented on a change in pull request #3424: allow delete duplicated non-key column using delete from

morningman commented on a change in pull request #3424: URL: https://github.com/apache/incubator-doris/pull/3424#discussion_r417369084 ## File path: be/src/olap/olap_cond.cpp ## @@ -681,17 +681,17 @@ int Conditions::delete_pruning_filter(const std::vector& zone_maps) co f

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3436: Fix the error result when assert num rows node is used

kangkaisen commented on a change in pull request #3436: URL: https://github.com/apache/incubator-doris/pull/3436#discussion_r417377285 ## File path: be/src/exec/assert_num_rows_node.cpp ## @@ -45,6 +45,7 @@ Status AssertNumRowsNode::prepare(RuntimeState* state) { Status Assert

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3437: [UT] Fix AlterTest UT failed

kangkaisen commented on a change in pull request #3437: URL: https://github.com/apache/incubator-doris/pull/3437#discussion_r417369939 ## File path: fe/src/test/java/org/apache/doris/alter/AlterTest.java ## @@ -135,10 +135,10 @@ public void testConflictAlterOperations() throws

[GitHub] [incubator-doris] morningman commented on a change in pull request #3431: [Memory Engine] Make Tablet extensible

morningman commented on a change in pull request #3431: URL: https://github.com/apache/incubator-doris/pull/3431#discussion_r417351767 ## File path: be/src/olap/base_tablet.h ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

[incubator-doris] branch master updated: [Doc] Fix linked file not found (#3434)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new beb5b29 [Doc] Fix linked file not

[GitHub] [incubator-doris] morningman opened a new pull request #3437: [UT] Fix AlterTest UT failed

morningman opened a new pull request #3437: URL: https://github.com/apache/incubator-doris/pull/3437 Fix: #3432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] morningman commented on issue #3432: Dynamic partition bug: overwrite the origin partitions

morningman commented on issue #3432: URL: https://github.com/apache/incubator-doris/issues/3432#issuecomment-621210480 Oh, I see. It is not "overwrite", the partition p1 and p2 are dropped by the DynamicPartitionScheduler. Because the date `2020-02-01` and `2020-03-01` is "out of the ra

[GitHub] [incubator-doris] morningman commented on issue #3432: Dynamic partition bug: overwrite the origin partitions

morningman commented on issue #3432: URL: https://github.com/apache/incubator-doris/issues/3432#issuecomment-621198417 This is strange, there should not be any logic that can "overwrite" a partition... I run this UT many times locally but it can not reproduce...But seems that the CI pr

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #3436: Fix the error result when assert num rows node is used

EmmyMiao87 opened a new pull request #3436: URL: https://github.com/apache/incubator-doris/pull/3436 The child.open() function is not called before this commit. If the assert num rows node has child which process data in open function, the assert num rows node will fetch no data from chi

[GitHub] [incubator-doris] EmmyMiao87 opened a new issue #3435: The error result when assert num rows node is used

EmmyMiao87 opened a new issue #3435: URL: https://github.com/apache/incubator-doris/issues/3435 **Describe the bug** select sum from (select sum(k1) sum from baseall)t1 where sum > (select avg from (select avg(k1) avg from baseall) t2 ) ; The first level of subquery returns a non

[GitHub] [incubator-doris] WingsGo commented on issue #3432: Dynamic partition bug: overwrite the origin partitions

WingsGo commented on issue #3432: URL: https://github.com/apache/incubator-doris/issues/3432#issuecomment-621182109 > This bug may lead to data loss? > @morningman @WingsGo should investigate this issue. OK,I will try to reproduce the bug. ---

[GitHub] [incubator-doris] imay commented on issue #3433: [Spark load] Doris support Spark load

imay commented on issue #3433: URL: https://github.com/apache/incubator-doris/issues/3433#issuecomment-621172837 1. can refer this issue in related PR and issue. 2. I will create a project "Spark Load" to track this feature. 3. You can create an issue for each part of this project.

[GitHub] [incubator-doris] imay commented on issue #3432: Dynamic partition bug: overwrite the origin partitions

imay commented on issue #3432: URL: https://github.com/apache/incubator-doris/issues/3432#issuecomment-621170578 This bug may lead to data loss? @morningman @WingsGo should investigate this issue. This is an automated mes

[incubator-doris-website] branch asf-site updated (3b9aeaf -> 58d1db6)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git. from 3b9aeaf Auto Build add ebdb50d add favicon.ico new 58d1db6 Add favicon.ico The 1 revi

[incubator-doris-website] 01/01: Add favicon.ico

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 58d1db6c7fcfb2018dda841a40779a6864c5e534 Merge: 3b9aeaf ebdb50d Author: Zhao Chun AuthorDate: Wed Apr

[GitHub] [incubator-doris] WingsGo edited a comment on issue #3402: Can we give user a error msg when they create a olap table with medium which is not exists in cluster?

WingsGo edited a comment on issue #3402: URL: https://github.com/apache/incubator-doris/issues/3402#issuecomment-621145565 Hi, @morningman I found that CheckDataSizeQuota will only check by logic but not check by real disk usage. And I have some questions: 1. One solution is get real di

[GitHub] [incubator-doris] yangzhg opened a new pull request #3434: fix linked file not found

yangzhg opened a new pull request #3434: URL: https://github.com/apache/incubator-doris/pull/3434 the source file of soft link CONTRIBUTING.md is changed, make it to a regular file This is an automated message from the Apa

[GitHub] [incubator-doris] WingsGo edited a comment on issue #3402: Can we give user a error msg when they create a olap table with medium which is not exists in cluster?

WingsGo edited a comment on issue #3402: URL: https://github.com/apache/incubator-doris/issues/3402#issuecomment-621145565 Hi, @morningman I found that CheckDataSizeQuota will only check by logic but not check by real disk usage.I have some questions: 1. One solution is get real disk sp

[GitHub] [incubator-doris] WingsGo edited a comment on issue #3402: Can we give user a error msg when they create a olap table with medium which is not exists in cluster?

WingsGo edited a comment on issue #3402: URL: https://github.com/apache/incubator-doris/issues/3402#issuecomment-621145565 @morningman I found that CheckDataSizeQuota will only check by logic but not check by real disk usage.I have some questions: 1. One solution is get real disk space

[GitHub] [incubator-doris] WingsGo commented on issue #3402: Can we give user a error msg when they create a olap table with medium which is not exists in cluster?

WingsGo commented on issue #3402: URL: https://github.com/apache/incubator-doris/issues/3402#issuecomment-621145565 @morningman I found that CheckDataSizeQuota will only check by logic but not check by real disk usage.I have some questions: 1. One solution is get real disk space avaliab

[GitHub] [incubator-doris] wyb commented on issue #3433: [Spark load] Doris support Spark load

wyb commented on issue #3433: URL: https://github.com/apache/incubator-doris/issues/3433#issuecomment-621142283 design doc [Proposal] support spark load #2855 [Proposal] Support Spark Convert Doris Segment #2887 Spark load etl interface #3010 -

[incubator-doris] branch master updated: [Bug] Fix bug that help-resource.zip file is missing. (#3423)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 73a3c59 [Bug] Fix bug that help-re

[GitHub] [incubator-doris] wyb opened a new issue #3433: [Spark load] Doris support Spark load

wyb opened a new issue #3433: URL: https://github.com/apache/incubator-doris/issues/3433 For many users who want to load data into doris for the first time, they have large amount of data, about 10G+，it is hard to support to load so large data into doris at one time using Broker load or St