wangbo commented on a change in pull request #3396:
URL: https://github.com/apache/incubator-doris/pull/3396#discussion_r417741395



##########
File path: fe/src/test/java/org/apache/doris/planner/QueryPlanTest.java
##########
@@ -504,4 +504,106 @@ public void testDateTypeEquality() throws Exception {
         
Catalog.getCurrentCatalog().getLoadManager().createLoadJobV1FromStmt(loadStmt, 
EtlJobType.HADOOP,
                 System.currentTimeMillis());
     }
+
+    private SelectStmt getAnalyzedAndRewritedStmt(String sql) throws Exception 
{

Review comment:
       ```getSQLPlanOrErrorMsg ```  is unable to meet demand.What we want is to 
check whether the plan changes as our wish,so we need a  tools not only 
retwrite the plan but alse contains the customized check logic.It's obviously 
that plain sql is directly,but not a common general method,because the print 
format may change.
   Maybe list a todo here?
   Anyway,I think the result of ```getSQLPlanOrErrorMsg ```  can't meet demand




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to