[GitHub] [incubator-doris] stalary commented on issue #3305: Add field context for string field keyword type

2020-04-12 Thread GitBox
stalary commented on issue #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#issuecomment-612760776 How is the review going? I need this feature. @morningman This

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-12 Thread GitBox
WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r407321003 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java #

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-12 Thread GitBox
wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407318979 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppColumns.java ## @@ -0,0 +1,119

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-12 Thread GitBox
wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407317908 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DorisRangePartitioner.java ## @@

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-12 Thread GitBox
wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407317908 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DorisRangePartitioner.java ## @@

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-12 Thread GitBox
wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407312053 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppUtils.java ## @@ -0,0 +1,230 @@

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-12 Thread GitBox
wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407312053 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppUtils.java ## @@ -0,0 +1,230 @@

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-12 Thread GitBox
wangbo commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407312053 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppUtils.java ## @@ -0,0 +1,230 @@

[GitHub] [incubator-doris] chaoyli merged pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-12 Thread GitBox
chaoyli merged pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294 This is an automated message from the Apache Git Service.

[incubator-doris] branch master updated: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep (#3294)

2020-04-12 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new be090f5 Use read lock when iterate

[GitHub] [incubator-doris] liutang123 commented on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-12 Thread GitBox
liutang123 commented on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#issuecomment-612729982 @chaoyli Hi, do you have time to see this PR again. This PR has been online in our cluster for tw

[GitHub] [incubator-doris] morningman edited a comment on issue #3246: [metrics] Add some metrics for container size in BE

2020-04-12 Thread GitBox
morningman edited a comment on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-612625122 > OK! And I want to know that is there a doc describing all the exsited metrics? If not, I think we could provide

[GitHub] [incubator-doris] morningman commented on issue #3246: [metrics] Add some metrics for container size in BE

2020-04-12 Thread GitBox
morningman commented on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-612625122 > OK! And I want to know that is there a doc describing all the exsited metrics? If not, I think we could provide a way,

[GitHub] [incubator-doris] morningman commented on issue #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

2020-04-12 Thread GitBox
morningman commented on issue #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#issuecomment-612624616 This feature is done by another PR, close this. -

[GitHub] [incubator-doris] morningman closed pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

2020-04-12 Thread GitBox
morningman closed pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] acelyc111 edited a comment on issue #3246: [metrics] Add some metrics for container size in BE

2020-04-12 Thread GitBox
acelyc111 edited a comment on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-612606111 > > > I have a question about dynamic collect the metric. > > > If people can remember so many metrics and use ht

[GitHub] [incubator-doris] acelyc111 commented on issue #3246: [metrics] Add some metrics for container size in BE

2020-04-12 Thread GitBox
acelyc111 commented on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-612606111 > > > I have a question about dynamic collect the metric. > > > If people can remember so many metrics and use http serv

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3305: Add field context for string field keyword type

2020-04-12 Thread GitBox
wuyunfeng commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407176067 ## File path: be/src/exec/es/es_predicate.cpp ## @@ -298,8 +302,12 @@ Status EsPredicate::b

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3305: Add field context for string field keyword type

2020-04-12 Thread GitBox
wuyunfeng commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407176067 ## File path: be/src/exec/es/es_predicate.cpp ## @@ -298,8 +302,12 @@ Status EsPredicate::b

[GitHub] [incubator-doris] morningman commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-12 Thread GitBox
morningman commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#discussion_r407061670 ## File path: be/src/olap/tablet_manager.cpp ## @@ -960,28 +960,

[GitHub] [incubator-doris] acelyc111 edited a comment on issue #3246: [metrics] Add some metrics for container size in BE

2020-04-12 Thread GitBox
acelyc111 edited a comment on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-612574756 > @acelyc111 Hi, Would better add a doc to list all new metrics and describe the metrics meaning. Thanks. @k

[GitHub] [incubator-doris] acelyc111 commented on issue #3246: [metrics] Add some metrics for container size in BE

2020-04-12 Thread GitBox
acelyc111 commented on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-612574756 > @acelyc111 Hi, Would better add a doc to list all new metrics and describe the metrics meaning. Thanks. OK! And I