acelyc111 commented on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-612606111 > > > I have a question about dynamic collect the metric. > > > If people can remember so many metrics and use http server to get it? > > > Why not add it into DorisMetric instead? > > > > > > Yes, I register all of these metrics to DorisMetric, via a new added macro in be/src/util/doris_metrics.h., and user can visit '/metrics' to obtain all metrics. > > I mean you can write the variable in doris_metrics.h, it's can be a unified entrance. > The followers can easy know metrics in doris through reading doris_metris.h. Good advice, done.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
