[GitHub] [incubator-doris] chaoyli commented on issue #3246: [metrics] Add some metrics for container size in BE

2020-04-10 Thread GitBox
chaoyli commented on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-612282382 > > I have a question about dynamic collect the metric. > > If people can remember so many metrics and use http server to

[GitHub] [incubator-doris] HangyuanLiu closed issue #3297: Rewrite some count expr case

2020-04-10 Thread GitBox
HangyuanLiu closed issue #3297: Rewrite some count expr case URL: https://github.com/apache/incubator-doris/issues/3297 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-doris] HangyuanLiu commented on issue #3298: Add count rewrite rule

2020-04-10 Thread GitBox
HangyuanLiu commented on issue #3298: Add count rewrite rule URL: https://github.com/apache/incubator-doris/pull/3298#issuecomment-612102266 I made a mistake in my thinking,I temporarily shut down the PR This is an automated m

[GitHub] [incubator-doris] HangyuanLiu closed pull request #3298: Add count rewrite rule

2020-04-10 Thread GitBox
HangyuanLiu closed pull request #3298: Add count rewrite rule URL: https://github.com/apache/incubator-doris/pull/3298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3191: DeleteV2

2020-04-10 Thread GitBox
xy720 commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r406811099 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,684 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3191: DeleteV2

2020-04-10 Thread GitBox
xy720 commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r406810388 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,684 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3191: DeleteV2

2020-04-10 Thread GitBox
xy720 commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r406810458 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,684 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3191: DeleteV2

2020-04-10 Thread GitBox
xy720 commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r406809075 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,684 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3191: DeleteV2

2020-04-10 Thread GitBox
xy720 commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r406809237 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,684 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] xy720 commented on a change in pull request #3191: DeleteV2

2020-04-10 Thread GitBox
xy720 commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r406808944 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,684 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] chaoyli commented on issue #3298: Add count rewrite rule

2020-04-10 Thread GitBox
chaoyli commented on issue #3298: Add count rewrite rule URL: https://github.com/apache/incubator-doris/pull/3298#issuecomment-612070999 If emtpy table, count(1) = 0, which will results? This is an automated message from the A

[GitHub] [incubator-doris] morningman commented on issue #3300: Use Google/CCTZ to replace boost at timezone function

2020-04-10 Thread GitBox
morningman commented on issue #3300: Use Google/CCTZ to replace boost at timezone function URL: https://github.com/apache/incubator-doris/pull/3300#issuecomment-612068757 We have to update the thirdparty dependency of our CI environment, or the compilation will be failed. I will update

[GitHub] [incubator-doris] morningman opened a new pull request #3302: [Bug] Fix bug that user plugin dir is removed after installing the plugin

2020-04-10 Thread GitBox
morningman opened a new pull request #3302: [Bug] Fix bug that user plugin dir is removed after installing the plugin URL: https://github.com/apache/incubator-doris/pull/3302 When user install a FE plugin from a directory, the directory should not be removed after installing. --

[GitHub] [incubator-doris] morningman opened a new issue #3301: [Bug] The user's plugin dir is removed after installing the plugin

2020-04-10 Thread GitBox
morningman opened a new issue #3301: [Bug] The user's plugin dir is removed after installing the plugin URL: https://github.com/apache/incubator-doris/issues/3301 **Describe the bug** When user install a FE plugin from directory: ``` install plugin from "/my/path/to/plugin/";

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #3300: Use Google/CCTZ to replace boost at timezone function

2020-04-10 Thread GitBox
HangyuanLiu opened a new pull request #3300: Use Google/CCTZ to replace boost at timezone function URL: https://github.com/apache/incubator-doris/pull/3300 For #3263 This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] liutang123 edited a comment on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
liutang123 edited a comment on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#issuecomment-612041189 > > By add logs, we found that `TabletManager::start_trash_sweep` will take write lock for a

[GitHub] [incubator-doris] liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#discussion_r406765575 ## File path: be/src/olap/tablet_manager.cpp ## @@ -960,28 +960,

[GitHub] [incubator-doris] liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#discussion_r406765575 ## File path: be/src/olap/tablet_manager.cpp ## @@ -960,28 +960,

[GitHub] [incubator-doris] liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#discussion_r406765575 ## File path: be/src/olap/tablet_manager.cpp ## @@ -960,28 +960,

[GitHub] [incubator-doris] liutang123 commented on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
liutang123 commented on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#issuecomment-612041189 > > By add logs, we found that `TabletManager::start_trash_sweep` will take write lock for a long t

[GitHub] [incubator-doris] liutang123 opened a new issue #3299: start_trash_sweep holds tablet map write lock for a long time

2020-04-10 Thread GitBox
liutang123 opened a new issue #3299: start_trash_sweep holds tablet map write lock for a long time URL: https://github.com/apache/incubator-doris/issues/3299 In our cluster, there are many stream load jobs. We found that these jobs slow down periodically. By add logs, we found that Ta

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #3298: Add count rewrite rule

2020-04-10 Thread GitBox
HangyuanLiu opened a new pull request #3298: Add count rewrite rule URL: https://github.com/apache/incubator-doris/pull/3298 For #3297 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] HangyuanLiu opened a new issue #3297: Rewrite some count expr case

2020-04-10 Thread GitBox
HangyuanLiu opened a new issue #3297: Rewrite some count expr case URL: https://github.com/apache/incubator-doris/issues/3297 Query statements such as “select min(user_id) from test having count(1) > 0“ may be generated by some BI tools. But having(count(1)) > 0 doesn't make sense. It's a

[GitHub] [incubator-doris] liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#discussion_r406765575 ## File path: be/src/olap/tablet_manager.cpp ## @@ -960,28 +960,

[incubator-doris] branch branch-0.11 created (now 9a3e60b)

2020-04-10 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch branch-0.11 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. at 9a3e60b Fix bug when use ZoneMap/BloomFiter on column with REPLACE/REPLACE_IF_NOT_NULL (#3288) T

[incubator-doris] branch branch-0.11 created (now 411a67d)

2020-04-10 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch branch-0.11 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. at 411a67d Fix bug when use ZoneMap/BloomFiter on column with REPLACE/REPLACE_IF_NOT_NULL (#3288) T

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #3296: spark data preparation process, issue #3295

2020-04-10 Thread GitBox
kangpinghuang opened a new pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296 To resolve issue #3295, Now this pr accomplish the following tasks: 1. data etl 2. data repartition and bucket 3. rollup data build

[GitHub] [incubator-doris] kangpinghuang opened a new issue #3295: spark data preparation process

2020-04-10 Thread GitBox
kangpinghuang opened a new issue #3295: spark data preparation process URL: https://github.com/apache/incubator-doris/issues/3295 To solve #2855, we intent to do elt by using spark cluster The pr #3010 has resolve the spark job submission job. The issue #2940 has resolve the global

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3283: Support setting replica quota in db level

2020-04-10 Thread GitBox
caiconghui commented on a change in pull request #3283: Support setting replica quota in db level URL: https://github.com/apache/incubator-doris/pull/3283#discussion_r406675498 ## File path: fe/src/main/java/org/apache/doris/common/FeConstants.java ## @@ -31,6 +31,7 @@

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3283: Support setting replica quota in db level

2020-04-10 Thread GitBox
caiconghui commented on a change in pull request #3283: Support setting replica quota in db level URL: https://github.com/apache/incubator-doris/pull/3283#discussion_r406670610 ## File path: fe/src/main/java/org/apache/doris/common/FeConstants.java ## @@ -31,6 +31,7 @@

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3283: Support setting replica quota in db level

2020-04-10 Thread GitBox
caiconghui commented on a change in pull request #3283: Support setting replica quota in db level URL: https://github.com/apache/incubator-doris/pull/3283#discussion_r40386 ## File path: fe/src/main/java/org/apache/doris/common/FeConstants.java ## @@ -31,6 +31,7 @@

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3283: Support setting replica quota in db level

2020-04-10 Thread GitBox
caiconghui commented on a change in pull request #3283: Support setting replica quota in db level URL: https://github.com/apache/incubator-doris/pull/3283#discussion_r40254 ## File path: fe/src/main/java/org/apache/doris/catalog/Database.java ## @@ -450,6 +488,12 @@ pu

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3283: Support setting replica quota in db level

2020-04-10 Thread GitBox
kangkaisen commented on a change in pull request #3283: Support setting replica quota in db level URL: https://github.com/apache/incubator-doris/pull/3283#discussion_r406664320 ## File path: fe/src/main/java/org/apache/doris/catalog/Database.java ## @@ -450,6 +488,12 @@ pu

[GitHub] [incubator-doris] imay commented on a change in pull request #3283: Support setting replica quota in db level

2020-04-10 Thread GitBox
imay commented on a change in pull request #3283: Support setting replica quota in db level URL: https://github.com/apache/incubator-doris/pull/3283#discussion_r406661924 ## File path: fe/src/main/java/org/apache/doris/common/FeConstants.java ## @@ -31,6 +31,7 @@ publ

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3283: Support setting replica quota in db level

2020-04-10 Thread GitBox
kangkaisen commented on a change in pull request #3283: Support setting replica quota in db level URL: https://github.com/apache/incubator-doris/pull/3283#discussion_r406660640 ## File path: fe/src/main/java/org/apache/doris/common/FeConstants.java ## @@ -31,6 +31,7 @@

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
chaoyli commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#discussion_r406658150 ## File path: be/src/olap/tablet_manager.cpp ## @@ -960,28 +960,36

[GitHub] [incubator-doris] kangkaisen commented on issue #3246: [metrics] Add some metrics for container size in BE

2020-04-10 Thread GitBox
kangkaisen commented on issue #3246: [metrics] Add some metrics for container size in BE URL: https://github.com/apache/incubator-doris/pull/3246#issuecomment-611934466 @acelyc111 Hi, Would better add a doc to list all new metrics and describe the metrics meaning. Thanks. ---

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-10 Thread GitBox
WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r406655873 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java #

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-10 Thread GitBox
WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r406655847 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java #

[GitHub] [incubator-doris] imay commented on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
imay commented on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#issuecomment-611932036 > By add logs, we found that `TabletManager::start_trash_sweep` will take write lock for a long time.

[GitHub] [incubator-doris] kangkaisen commented on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
kangkaisen commented on issue #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#issuecomment-611930999 @liutang123 Please add a issue for this PR. ---

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-10 Thread GitBox
kangkaisen commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r406641632 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ##

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-10 Thread GitBox
kangkaisen commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r406647112 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ##

[GitHub] [incubator-doris] liutang123 opened a new pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-10 Thread GitBox
liutang123 opened a new pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294 In our cluster, there are many stream load jobs. We found that these jobs slow down periodically. By add logs,