xy720 commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r406811099
########## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ########## @@ -0,0 +1,684 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.load; + +import com.google.common.base.Joiner; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import org.apache.doris.analysis.BinaryPredicate; +import org.apache.doris.analysis.DeleteStmt; +import org.apache.doris.analysis.IsNullPredicate; +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.analysis.Predicate; +import org.apache.doris.analysis.SlotRef; +import org.apache.doris.catalog.Catalog; +import org.apache.doris.catalog.Column; +import org.apache.doris.catalog.Database; +import org.apache.doris.catalog.KeysType; +import org.apache.doris.catalog.MaterializedIndex; +import org.apache.doris.catalog.MaterializedIndex.IndexExtState; +import org.apache.doris.catalog.OlapTable; +import org.apache.doris.catalog.Partition; +import org.apache.doris.catalog.PartitionType; +import org.apache.doris.catalog.Replica; +import org.apache.doris.catalog.Table; +import org.apache.doris.catalog.Tablet; +import org.apache.doris.catalog.TabletInvertedIndex; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.AnalysisException; +import org.apache.doris.common.Config; +import org.apache.doris.common.DdlException; +import org.apache.doris.common.ErrorCode; +import org.apache.doris.common.ErrorReport; +import org.apache.doris.common.UserException; +import org.apache.doris.common.io.Writable; +import org.apache.doris.common.util.ListComparator; +import org.apache.doris.common.util.TimeUtils; +import org.apache.doris.mysql.privilege.PrivPredicate; +import org.apache.doris.qe.ConnectContext; +import org.apache.doris.service.FrontendOptions; +import org.apache.doris.task.AgentBatchTask; +import org.apache.doris.task.AgentTaskExecutor; +import org.apache.doris.task.AgentTaskQueue; +import org.apache.doris.task.DeleteTask; +import org.apache.doris.task.MasterTaskExecutor; +import org.apache.doris.task.PushTask; +import org.apache.doris.thrift.TPriority; +import org.apache.doris.thrift.TPushType; +import org.apache.doris.thrift.TTaskType; +import org.apache.doris.transaction.GlobalTransactionMgr; +import org.apache.doris.transaction.TabletCommitInfo; +import org.apache.doris.transaction.TransactionState; +import org.apache.doris.transaction.TransactionStatus; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.io.DataInput; +import java.io.DataOutput; +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashSet; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.LinkedBlockingQueue; +import java.util.concurrent.locks.ReentrantReadWriteLock; + +public class DeleteHandler implements Writable { + private static final Logger LOG = LogManager.getLogger(DeleteHandler.class); + + // TransactionId -> DeleteTask + private Map<Long, DeleteTask> idToDeleteTask; + + // Db -> DeleteInfo list + private Map<Long, List<DeleteInfo>> dbToDeleteInfos; + + private MasterTaskExecutor executor; + + private BlockingQueue<DeleteTask> queue; + + private DeleteTaskChecker checker; + + private ReentrantReadWriteLock lock; + + public void readLock() { + lock.readLock().lock(); + } + + public void readUnlock() { + lock.readLock().unlock(); + } + + private void writeLock() { + lock.writeLock().lock(); + } + + private void writeUnlock() { + lock.writeLock().unlock(); + } + + + public DeleteHandler() { + idToDeleteTask = Maps.newHashMap(); + dbToDeleteInfos = Maps.newHashMap(); + executor = new MasterTaskExecutor(Config.delete_thread_num); + queue = new LinkedBlockingQueue(Config.delete_thread_num); + lock = new ReentrantReadWriteLock(true); + // start checker + checker = new DeleteTaskChecker(queue); + checker.start(); + } + + public void process(DeleteStmt stmt) throws DdlException { + String dbName = stmt.getDbName(); + String tableName = stmt.getTableName(); + String partitionName = stmt.getPartitionName(); + List<Predicate> conditions = stmt.getDeleteConditions(); + Database db = Catalog.getInstance().getDb(dbName); + if (db == null) { + throw new DdlException("Db does not exist. name: " + dbName); + } + + DeleteTask deleteTask = null; + DeleteInfo deleteInfo = null; + long transactionId; + db.readLock(); + try { + Table table = db.getTable(tableName); + if (table == null) { + throw new DdlException("Table does not exist. name: " + tableName); + } + + if (table.getType() != Table.TableType.OLAP) { + throw new DdlException("Not olap type table. type: " + table.getType().name()); + } + OlapTable olapTable = (OlapTable) table; + + if (olapTable.getState() != OlapTable.OlapTableState.NORMAL) { + throw new DdlException("Table's state is not normal: " + tableName); + } + + + if (partitionName == null) { + if (olapTable.getPartitionInfo().getType() == PartitionType.RANGE) { + throw new DdlException("This is a range partitioned table." + + " You should specify partition in delete stmt"); + } else { + // this is a unpartitioned table, use table name as partition name + partitionName = olapTable.getName(); + } + } + + Partition partition = olapTable.getPartition(partitionName); + if (partition == null) { + throw new DdlException("Partition does not exist. name: " + partitionName); + } + + List<String> deleteConditions = Lists.newArrayList(); + + // pre check + checkDeleteV2(olapTable, partition, conditions, deleteConditions, true); + + // generate label + String label = "delete_" + UUID.randomUUID(); + + // begin txn here and generate txn id + transactionId = Catalog.getCurrentGlobalTransactionMgr().beginTransaction(db.getId(), + Lists.newArrayList(table.getId()), label,"FE: " + FrontendOptions.getLocalHostAddress(), + TransactionState.LoadJobSourceType.FRONTEND, Config.stream_load_default_timeout_second); + + TransactionState state = Catalog.getCurrentGlobalTransactionMgr() + .getTransactionState(transactionId); + if (state == null) { + throw new DdlException("begin transaction failed, cancel delete"); + } + + deleteInfo = new DeleteInfo(db.getId(), olapTable.getId(), tableName, + partition.getId(), partitionName, + -1, 0, deleteConditions); + + // task in fe + deleteTask = new DeleteTask(transactionId, deleteInfo); + + writeLock(); + try { + idToDeleteTask.put(transactionId, deleteTask); + } finally { + writeUnlock(); + } + + // task sent to be + AgentBatchTask batchTask = new AgentBatchTask(); + + for (MaterializedIndex index : partition.getMaterializedIndices(IndexExtState.VISIBLE)) { + long indexId = index.getId(); + int schemaHash = olapTable.getSchemaHashByIndexId(indexId); + + for (Tablet tablet : index.getTablets()) { + long tabletId = tablet.getId(); + + // set push type + TPushType type = TPushType.DELETE; + + Set<Long> allReplicas = new HashSet<Long>(); + + for (Replica replica : tablet.getReplicas()) { + long replicaId = replica.getId(); + allReplicas.add(replicaId); + + // create push task for each replica + PushTask pushTask = new PushTask(null, + replica.getBackendId(), db.getId(), olapTable.getId(), + partition.getId(), indexId, + tabletId, replicaId, schemaHash, + -1, 0, "", -1, 0, + -1, type, conditions, + true, TPriority.NORMAL, + TTaskType.REALTIME_PUSH, + transactionId, + Catalog.getCurrentGlobalTransactionMgr().getTransactionIDGenerator().getNextTransactionId()); + pushTask.setIsSchemaChanging(true); + + if (AgentTaskQueue.addTask(pushTask)) { + batchTask.addTask(pushTask); + deleteTask.addTablet(tabletId); + deleteTask.addPushTask(pushTask); + } + + } + } + } + + // submit push tasks + if (batchTask.getTaskNum() > 0) { + AgentTaskExecutor.submit(batchTask); + queue.put(deleteTask); + } + + } catch (Throwable t) { + LOG.warn("error occurred during delete process", t); + throw new DdlException(t.getMessage(), t); + } finally { + db.readUnlock(); + } + + long timeout = deleteTask.getTimeout(); + LOG.info("waiting delete task finish, signature: {}, timeout: {}", transactionId, timeout); + // wait until delete task finish or timeout + deleteTask.join(timeout); + if (deleteTask.isQuorum()) { + commitTask(deleteTask, db); + } else { + boolean isSuccess = cancelTask(deleteTask, "delete task timeout"); + if (isSuccess) { + throw new DdlException("timeout when waiting delete"); + } + } + + // wait until transaction state become visible + afterCommit(deleteTask, db, timeout); + } + + private void afterCommit(DeleteTask deleteTask, Database db, long leftTime) throws DdlException { + try { + long startDeleteTime = System.currentTimeMillis(); + long transactionId = deleteTask.getSignature(); + while (true) { + db.writeLock(); + try { + // check if the job is aborted in transaction manager + TransactionState state = Catalog.getCurrentGlobalTransactionMgr() + .getTransactionState(transactionId); + if (state == null) { + LOG.warn("cancel delete, transactionId {}, because could not find transaction state", transactionId); + cancelTask(deleteTask,"transaction state lost"); + return; + } + TransactionStatus status = state.getTransactionStatus(); + switch (status) { + case ABORTED: + cancelTask(deleteTask,"delete transaction is aborted in transaction manager [" + state + "]"); + return; + case COMMITTED: + LOG.debug("delete task is already committed, just wait it to be visible, transactionId {}, transaction state {}", transactionId, state); + return; + case VISIBLE: + LOG.debug("delete committed, transactionId: {}, transaction state {}", transactionId, state); + removeTask(deleteTask); + return; + } + if (leftTime < System.currentTimeMillis() - startDeleteTime) { + cancelTask(deleteTask, "delete timeout when waiting transaction commit"); + } + } finally { + db.writeUnlock(); + } + Thread.sleep(1000); + } + } catch (Exception e) { + String failMsg = "delete unknown, " + e.getMessage(); + LOG.warn(failMsg, e); + throw new DdlException(failMsg); + } + } + + public class DeleteTaskChecker extends Thread { + private BlockingQueue<DeleteTask> queue; + + public DeleteTaskChecker(BlockingQueue<DeleteTask> queue) { + this.queue = queue; + } + + @Override + public void run() { + LOG.info("delete task checker start"); + try { + loop(); + } finally { + synchronized(queue) { + queue.clear(); + } + } + } + + public void loop() { + while (true) { + try { + DeleteTask task = queue.take(); + while (!task.isQuorum()) { + long signature = task.getSignature(); + if (task.isCancel()) { + break; + } + if (!executor.submit(task)) { + Thread.sleep(1000); + continue; + } + // re add to the tail + queue.put(task); + } + // remove task isQuorum or isCanceled + removeTask(task); + } catch (InterruptedException e) { + // do nothing + } + } + } + } + + private void commitTask(DeleteTask task, Database db) { + long transactionId = task.getSignature(); + GlobalTransactionMgr globalTransactionMgr = Catalog.getCurrentGlobalTransactionMgr(); + TransactionState transactionState = globalTransactionMgr.getTransactionState(transactionId); + List<TabletCommitInfo> tabletCommitInfos = new ArrayList<TabletCommitInfo>(); + db.writeLock(); + try { + TabletInvertedIndex invertedIndex = Catalog.getCurrentInvertedIndex(); + for (TabletDeleteInfo tDeleteInfo : task.getTabletDeleteInfo()) { + for (Replica replica : tDeleteInfo.getFinishedReplicas()) { + // the inverted index contains rolling up replica + Long tabletId = invertedIndex.getTabletIdByReplica(replica.getId()); + if (tabletId == null) { + LOG.warn("could not find tablet id for replica {}, the tablet maybe dropped", replica); + continue; + } + tabletCommitInfos.add(new TabletCommitInfo(tabletId, replica.getBackendId())); + } + } + globalTransactionMgr.commitTransaction(db.getId(), transactionId, tabletCommitInfos); + } catch (UserException e) { + LOG.warn("errors while commit delete, transaction [{}], reason is {}", + transactionState.getTransactionId(), e); + cancelTask(task, transactionState.getReason()); + } finally { + db.writeUnlock(); + } + } + + public void removeTask(DeleteTask task) { + task.unJoin(); + writeLock(); + try { + long signature = task.getSignature(); + if (idToDeleteTask.containsKey(signature)) { + idToDeleteTask.remove(signature); + } + for (PushTask pushTask : task.getPushTasks()) { + AgentTaskQueue.removePushTask(pushTask.getBackendId(), pushTask.getSignature(), + pushTask.getVersion(), pushTask.getVersionHash(), + pushTask.getPushType(), pushTask.getTaskType()); + } + if (task.isQuorum()) { + DeleteInfo deleteInfo = task.getDeleteInfo(); + long dbId = deleteInfo.getDbId(); + if (dbToDeleteInfos.containsKey(dbId)) { + dbToDeleteInfos.get(dbId).add(deleteInfo); + } else { + List<DeleteInfo> deleteInfoList = Lists.newArrayList(); + deleteInfoList.add(deleteInfo); + dbToDeleteInfos.put(dbId, deleteInfoList); + } + Catalog.getInstance().getEditLog().logFinishSyncDelete(deleteInfo); Review comment: I will put it in afterVisible() in interface AbstractTxnStateChangeCallback instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
