[GitHub] [incubator-doris] wangbo commented on a change in pull request #2922: AlterJobV2 Pending Status Replay Fix Bug

2020-02-16 Thread GitBox
wangbo commented on a change in pull request #2922: AlterJobV2 Pending Status Replay Fix Bug URL: https://github.com/apache/incubator-doris/pull/2922#discussion_r380016716 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -1702,8 +1702,18 @@ public

[GitHub] [incubator-doris] wangbo commented on a change in pull request #2922: AlterJobV2 Pending Status Replay Fix Bug

2020-02-16 Thread GitBox
wangbo commented on a change in pull request #2922: AlterJobV2 Pending Status Replay Fix Bug URL: https://github.com/apache/incubator-doris/pull/2922#discussion_r380016645 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -1702,8 +1702,18 @@ public

[GitHub] [incubator-doris] lingbin merged pull request #2918: Some refactor on `TabletManager`

2020-02-16 Thread GitBox
lingbin merged pull request #2918: Some refactor on `TabletManager` URL: https://github.com/apache/incubator-doris/pull/2918 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[incubator-doris] branch master updated (f20eb12 -> feef077)

2020-02-16 Thread lingbin
This is an automated email from the ASF dual-hosted git repository. lingbin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from f20eb12 [util] Import ThreadPool and Thread from KUDU (#2915) add feef077 Some refactors on `TabletM

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2918: Some refactor on `TabletManager`

2020-02-16 Thread GitBox
lingbin commented on a change in pull request #2918: Some refactor on `TabletManager` URL: https://github.com/apache/incubator-doris/pull/2918#discussion_r380005093 ## File path: be/src/olap/tablet_manager.cpp ## @@ -212,120 +191,133 @@ bool TabletManager::_check_tablet_i

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2918: Some refactor on `TabletManager`

2020-02-16 Thread GitBox
lingbin commented on a change in pull request #2918: Some refactor on `TabletManager` URL: https://github.com/apache/incubator-doris/pull/2918#discussion_r380005113 ## File path: be/src/olap/tablet_manager.cpp ## @@ -83,42 +72,42 @@ OLAPStatus TabletManager::_add_tablet_un

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2918: Some refactor on `TabletManager`

2020-02-16 Thread GitBox
chaoyli commented on a change in pull request #2918: Some refactor on `TabletManager` URL: https://github.com/apache/incubator-doris/pull/2918#discussion_r380002318 ## File path: be/src/olap/tablet_manager.cpp ## @@ -212,120 +191,133 @@ bool TabletManager::_check_tablet_i

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2918: Some refactor on `TabletManager`

2020-02-16 Thread GitBox
chaoyli commented on a change in pull request #2918: Some refactor on `TabletManager` URL: https://github.com/apache/incubator-doris/pull/2918#discussion_r379996880 ## File path: be/src/olap/tablet_manager.cpp ## @@ -83,42 +72,42 @@ OLAPStatus TabletManager::_add_tablet_un

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2922: AlterJobV2 Pending Status Replay Fix Bug

2020-02-16 Thread GitBox
kangkaisen commented on a change in pull request #2922: AlterJobV2 Pending Status Replay Fix Bug URL: https://github.com/apache/incubator-doris/pull/2922#discussion_r379997934 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -1702,8 +1702,18 @@ pu

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2922: AlterJobV2 Pending Status Replay Fix Bug

2020-02-16 Thread GitBox
kangkaisen commented on a change in pull request #2922: AlterJobV2 Pending Status Replay Fix Bug URL: https://github.com/apache/incubator-doris/pull/2922#discussion_r379998028 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -1702,8 +1702,18 @@ pu

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2921: diable column both in select list and aggregate functions when using GROUPING SETS/CUBE/ROLLUP

2020-02-16 Thread GitBox
kangkaisen commented on a change in pull request #2921: diable column both in select list and aggregate functions when using GROUPING SETS/CUBE/ROLLUP URL: https://github.com/apache/incubator-doris/pull/2921#discussion_r379995223 ## File path: fe/src/main/java/org/apache/doris/analy

[GitHub] [incubator-doris] kangkaisen commented on issue #2847: Doris support in memory olap table

2020-02-16 Thread GitBox
kangkaisen commented on issue #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#issuecomment-586827030 **Update the PR to Fix conflict only, not change from morningman last review.** --

[GitHub] [incubator-doris] wangbo opened a new pull request #2922: AlterJobV2 Pending Status Replay Fix Bug

2020-02-16 Thread GitBox
wangbo opened a new pull request #2922: AlterJobV2 Pending Status Replay Fix Bug URL: https://github.com/apache/incubator-doris/pull/2922 #2920 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] yangzhg opened a new pull request #2921: diable column both in select list and aggregate functions when using GROUPING SETS/CUBE/ROLLUP

2020-02-16 Thread GitBox
yangzhg opened a new pull request #2921: diable column both in select list and aggregate functions when using GROUPING SETS/CUBE/ROLLUP URL: https://github.com/apache/incubator-doris/pull/2921 diable column both in select list and aggregate functions when using GROUPING SETS/CUBE/ROLLUP -

[GitHub] [incubator-doris] wangbo opened a new issue #2920: AlterJobV2 Pending Status Replay Fix Bug

2020-02-16 Thread GitBox
wangbo opened a new issue #2920: AlterJobV2 Pending Status Replay Fix Bug URL: https://github.com/apache/incubator-doris/issues/2920 **Bug Description** The TabletInvertedIndex isn't a Persistence class. In the Loading image process,Doris first load olaptable from image, Then using

[GitHub] [incubator-doris] worker24h opened a new issue #2919: Invalid memory address in doris::memory_copy

2020-02-16 Thread GitBox
worker24h opened a new issue #2919: Invalid memory address in doris::memory_copy URL: https://github.com/apache/incubator-doris/issues/2919 **Describe the bug** When I change schema `char(20)` to `varchar(20)` cause coredump. The follow is backtrace: (gdb) bt #0 doris::memory_co

[GitHub] [incubator-doris] lingbin opened a new pull request #2918: Some refactor on `TabletManager`

2020-02-16 Thread GitBox
lingbin opened a new pull request #2918: Some refactor on `TabletManager` URL: https://github.com/apache/incubator-doris/pull/2918 1. Add some comments to make the code easier to understand; 2. Make the metric `create_tablet_requests_failed` to be accurate; 3. Some internal methods use

[GitHub] [incubator-doris] kangkaisen edited a comment on issue #2902: bitmap_union_count support window function

2020-02-16 Thread GitBox
kangkaisen edited a comment on issue #2902: bitmap_union_count support window function URL: https://github.com/apache/incubator-doris/pull/2902#issuecomment-586809826 > How about adding a unit test for `bitmap_union_count()` window function? I will add a UT for `bitmap_get_value`, Bu

[GitHub] [incubator-doris] yangzhg opened a new pull request #2917: fix local test failed

2020-02-16 Thread GitBox
yangzhg opened a new pull request #2917: fix local test failed URL: https://github.com/apache/incubator-doris/pull/2917 fix a local test failed This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2902: bitmap_union_count support window function

2020-02-16 Thread GitBox
kangkaisen commented on a change in pull request #2902: bitmap_union_count support window function URL: https://github.com/apache/incubator-doris/pull/2902#discussion_r379979832 ## File path: be/src/exprs/bitmap_function.h ## @@ -46,6 +46,9 @@ class BitmapFunctions {

[GitHub] [incubator-doris] kangkaisen commented on issue #2902: bitmap_union_count support window function

2020-02-16 Thread GitBox
kangkaisen commented on issue #2902: bitmap_union_count support window function URL: https://github.com/apache/incubator-doris/pull/2902#issuecomment-586809826 > How about adding a unit test for `bitmap_union_count()` window function? I will add a UT for `bitmap_get_value`, But If we want

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2914: [UDF] Fix bug that UDF can't handle constant null value

2020-02-16 Thread GitBox
kangkaisen commented on a change in pull request #2914: [UDF] Fix bug that UDF can't handle constant null value URL: https://github.com/apache/incubator-doris/pull/2914#discussion_r379978549 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java #

[incubator-doris] branch master updated (43583e7 -> f20eb12)

2020-02-16 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 43583e7 Fix orc load bug (#2912) add f20eb12 [util] Import ThreadPool and Thread from KUDU (#2915

[GitHub] [incubator-doris] chaoyli merged pull request #2915: [util] Import ThreadPool and Thread from KUDU

2020-02-16 Thread GitBox
chaoyli merged pull request #2915: [util] Import ThreadPool and Thread from KUDU URL: https://github.com/apache/incubator-doris/pull/2915 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] hexian55 opened a new issue #2916: doris on es report 500 Internal Privoxy Error

2020-02-16 Thread GitBox
hexian55 opened a new issue #2916: doris on es report 500 Internal Privoxy Error URL: https://github.com/apache/incubator-doris/issues/2916 **Describe the bug** A clear and concise description of what the bug is. test doris on es, create es table: CREATE EXTERNAL TABLE `doris_ta

[GitHub] [incubator-doris] HangyuanLiu commented on issue #2911: Support not_empty function and empty function

2020-02-16 Thread GitBox
HangyuanLiu commented on issue #2911: Support not_empty function and empty function URL: https://github.com/apache/incubator-doris/pull/2911#issuecomment-586792476 > Is it necessary to implement this function? Why not using `length(str) == 0`? @morningman I think is necessary ,lengt

[GitHub] [incubator-doris] trueeyu commented on issue #2910: [PROPOSAL] Remove unused LLVM related codes

2020-02-16 Thread GitBox
trueeyu commented on issue #2910: [PROPOSAL] Remove unused LLVM related codes URL: https://github.com/apache/incubator-doris/issues/2910#issuecomment-586779930 Let me handle it. This is an automated message from the Apache Gi

[GitHub] [incubator-doris] chaoyli opened a new pull request #2915: [util] Import ThreadPool and Thread from KUDU

2020-02-16 Thread GitBox
chaoyli opened a new pull request #2915: [util] Import ThreadPool and Thread from KUDU URL: https://github.com/apache/incubator-doris/pull/2915 Thread pool design point: All tasks submitted directly to the thread pool enter a FIFO queue and are dispatched to a worker thread when one

[GitHub] [incubator-doris] chaoyli edited a comment on issue #2896: Import a new ThreadPool Framework

2020-02-16 Thread GitBox
chaoyli edited a comment on issue #2896: Import a new ThreadPool Framework URL: https://github.com/apache/incubator-doris/issues/2896#issuecomment-586089869 1. import scoped_refptr from gutil #2899 [done] 2. import ConditionVariable from Kudu #2905 3. import ThreadPool #2915

[GitHub] [incubator-doris] morningman commented on a change in pull request #2902: bitmap_union_count support window function

2020-02-16 Thread GitBox
morningman commented on a change in pull request #2902: bitmap_union_count support window function URL: https://github.com/apache/incubator-doris/pull/2902#discussion_r379903105 ## File path: be/src/exprs/bitmap_function.h ## @@ -46,6 +46,9 @@ class BitmapFunctions {

[GitHub] [incubator-doris] morningman commented on issue #2911: Support not_empty function and empty function

2020-02-16 Thread GitBox
morningman commented on issue #2911: Support not_empty function and empty function URL: https://github.com/apache/incubator-doris/pull/2911#issuecomment-586704100 Is it necessary to implement this function? Why not using `length(str) == 0`? -

[GitHub] [incubator-doris] morningman commented on a change in pull request #2914: [UDF] Fix bug that UDF can't handle constant null value

2020-02-16 Thread GitBox
morningman commented on a change in pull request #2914: [UDF] Fix bug that UDF can't handle constant null value URL: https://github.com/apache/incubator-doris/pull/2914#discussion_r379900376 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java #

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2914: [UDF] Fix bug that UDF can't handle constant null value

2020-02-16 Thread GitBox
kangkaisen commented on a change in pull request #2914: [UDF] Fix bug that UDF can't handle constant null value URL: https://github.com/apache/incubator-doris/pull/2914#discussion_r379898235 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java #

[incubator-doris] branch master updated: Fix orc load bug (#2912)

2020-02-16 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 43583e7 Fix orc load bug (#2912) 43583e

[GitHub] [incubator-doris] imay merged pull request #2912: Fix some bug in orc load

2020-02-16 Thread GitBox
imay merged pull request #2912: Fix some bug in orc load URL: https://github.com/apache/incubator-doris/pull/2912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[incubator-doris] branch master updated: Add disable_storage_page_cache config (#2890)

2020-02-16 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 6c33f80 Add disable_storage_page_c

[GitHub] [incubator-doris] kangkaisen merged pull request #2890: Add disable_storage_page_cache config

2020-02-16 Thread GitBox
kangkaisen merged pull request #2890: Add disable_storage_page_cache config URL: https://github.com/apache/incubator-doris/pull/2890 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman opened a new pull request #2914: [UDF] Fix bug that UDF can't handle constant null value

2020-02-16 Thread GitBox
morningman opened a new pull request #2914: [UDF] Fix bug that UDF can't handle constant null value URL: https://github.com/apache/incubator-doris/pull/2914 This CL modify the `evalExpr()` of `ExpressionFunctions`, so that it won't change the `FunctionCallExpr` to `NullLiteral` when the

[GitHub] [incubator-doris] morningman opened a new issue #2913: [UDF] UDF can handle null value

2020-02-16 Thread GitBox
morningman opened a new issue #2913: [UDF] UDF can handle null value URL: https://github.com/apache/incubator-doris/issues/2913 **Describe the bug** When creating a udf, which may want to handle the null value, for example: ``` BooleanVal string_empty_or_null(const StringVal& st