kangkaisen commented on a change in pull request #2914: [UDF] Fix bug that UDF
can't handle constant null value
URL: https://github.com/apache/incubator-doris/pull/2914#discussion_r379978549
##########
File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java
##########
@@ -144,15 +145,6 @@ private synchronized void registerFunctions() {
}
}
this.functions = mapBuilder.build();
-
- // Functions that need to handle null.
- ImmutableSet.Builder<String> setBuilder =
- new ImmutableSet.Builder<String>();
- setBuilder.add("if");
- setBuilder.add("hll_hash");
- setBuilder.add("concat_ws");
- setBuilder.add("ifnull");
- this.nonNullResultWithNullParamFunctions = setBuilder.build();
Review comment:
I See.
But if this change is only to make the `nonNullResultWithNullParamFunctions`
definition Obviously. I think normal java class is better than python script,
because current IDE is very powerful, we could very easily find the definition.
Besides，I think if not performance reason, we shouldn't use code gen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
