Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-10 Thread via GitHub
squakez closed pull request #4797: feat(trait): let camel framework manage Kamelets URL: https://github.com/apache/camel-k/pull/4797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-10 Thread via GitHub
squakez commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1754849876 > > I am thinking of what side effect it brings now that the Kamelet is not treated as a source anymore. Obviously the code parsing for dependencies is now skipped for Kamelets, but are t

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1752710311 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.4% --> 33.3% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-09 Thread via GitHub
squakez commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1752642361 > I am thinking of what side effect it brings now that the Kamelet is not treated as a source anymore. Obviously the code parsing for dependencies is now skipped for Kamelets, but are the

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-09 Thread via GitHub
christophd commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1752592545 I am thinking of what side effect it brings now that the Kamelet is not treated as a source anymore. Obviously the code parsing for dependencies is now skipped for Kamelets, but are th

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-09 Thread via GitHub
christophd commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1752589979 > @christophd the Yaks check is failing because we need to provide the dependencies when creating a Kamelet. Is there any way to do that easily in > > https://github.com/apache/

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1752585672 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.4% --> 33.3% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1752507663 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.4% --> 33.3% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-06 Thread via GitHub
squakez commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1750764960 @christophd the Yaks check is failing because we need to provide the dependencies when creating a Kamelet. Is there any way to do that easily in https://github.com/apache/camel-k/blob/292

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-06 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1750695207 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.4% --> 33.3% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-06 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1750464315 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.4% --> 33.3% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-06 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1750210131 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.4% --> 33.3% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-05 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1749123657 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.4% --> 33.3% (Coverage difference: **-.1%**) -- This is an automated mes

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-05 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1748676836 :camel: **Thank you for contributing!** Code Coverage Report :heavy_check_mark: - Coverage unchanged. -- This is an automated message from the Apache Git Service. To r

Re: [PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-05 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1748639244 :camel: **Thank you for contributing!** Code Coverage Report :warning: - Coverage changed: 33.3% --> 33.2% (Coverage difference: **-.1%**) -- This is an automated mes

[PR] feat(trait): let camel framework manage Kamelets [camel-k]

2023-10-05 Thread via GitHub
squakez opened a new pull request, #4797: URL: https://github.com/apache/camel-k/pull/4797 With this PR we get rid off the very first Kamelets runtime execution which translated the Kamelets into a route templates. We let now the Camel runtime to use the Kamelets as they are expected in